all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 53505@debbugs.gnu.org
Subject: [bug#53505] [PATCH] .dir-locals.el: Don't mess up indentation of prepend and append.
Date: Wed, 26 Jan 2022 20:26:21 +0100	[thread overview]
Message-ID: <48410bfa442f971803d45230594b60ff1b3e7af8.camel@gmail.com> (raw)
In-Reply-To: <87o83yivts.fsf@gnu.org>

Hi!

Am Mittwoch, dem 26.01.2022 um 12:24 +0100 schrieb Ludovic Courtès:
> Hi!
> 
> Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:
> 
> > The current version appears to assume special values in the first
> > and second package, but it's either all lists (default append) or
> > all package input expressions (inside modify-inputs), which
> > themselves are either packages or a list consisting of a package
> > and a string.
> > 
> > * .dir-locals.el: Drop (eval . (put 'prepend 'scheme-indent-
> > function 2))
> > and (eval . (put 'append 'scheme-indent-function 2)).
> 
> Yeah it’s been bothering me too.  :-)
> 
> We can keep ‘prepend’ though as it doesn’t clash with anything.
It might not clash, but is its behaviour correct?  IIRC, prepend and
append take a list of packages inside modify-inputs, so if I wanted to
add spam, ham, eggs, milk and butter to a python-package, I'd write
that as

(modify-inputs my-package
  (prepend python-spam
       python-ham
     python-eggs
     python-milk
     python-butter))

That doesn't seem right, now does it?




  reply	other threads:[~2022-01-26 19:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 16:36 [bug#53505] [PATCH] .dir-locals.el: Don't mess up indentation of prepend and append Liliana Marie Prikler
2022-01-26 11:24 ` Ludovic Courtès
2022-01-26 19:26   ` Liliana Marie Prikler [this message]
2022-01-28 23:03     ` Ludovic Courtès
2022-01-29  7:51       ` bug#53505: " Liliana Marie Prikler
2022-01-26 20:39 ` [bug#53505] " Tobias Geerinckx-Rice via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48410bfa442f971803d45230594b60ff1b3e7af8.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=53505@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.