all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Arun Isaac <arunisaac@systemreboot.net>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 27859@debbugs.gnu.org
Subject: [bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode.
Date: Fri, 28 Jul 2017 17:13:38 +0530	[thread overview]
Message-ID: <4823d772.ADkAACbGIQwAAAAAAAAAAAPbn-sAAAACwQwAAAAAAAW9WABZeyNz@mailjet.com> (raw)
In-Reply-To: <20170728083731.18027-1-go.wigust@gmail.com>


Thanks for the patch!

> +(define-public emacs-rpm-spec-mode
> +  (let ((commit "bbce63f042ea07aa8c2fe67e02357c8521624293")
> +        (revision "1"))
> +    (package
> +      (name "emacs-rpm-spec-mode")
> +      (version (string-append "0.0.1-" revision "."
> +                              (string-take commit 7)))

version should be 0.16. Look at line 7 of rpm-spec-mode.el.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url (string-append
> +                            "https://src.fedoraproject.org/git/rpms"
> +                            "/emacs-rpm-spec-mode.git"))
> +                      (commit commit)))
> +                (file-name (string-append name "-" version "-checkout"))
> +                (sha256
> +                 (base32
> +                  "0cznnm5jmi38xr8ycnmkcyp60a9nvq9rlhy2w3lij4070n6xzcb4"))))

It would be nice if upstream provided a release tarball. We wouldn't
have to clone their git repo. Could you ask them about it?

> +      (build-system emacs-build-system)
> +      (home-page (string-append "http://pkgs.fedoraproject.org/cgit/rpms"
> +                                "/emacs-rpm-spec-mode.git"))
> +      (synopsis "Emacs major mode for editing RPM spec files")
> +      (description "@code{emacs-rpm-spec-mode} provides Emacs major mode for
> +editing RPM spec files.")
> +      (license license:gpl2+))))

LGTM, otherwise!

  reply	other threads:[~2017-07-28 11:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28  8:37 [bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode Oleg Pykhalov
2017-07-28 11:43 ` Arun Isaac [this message]
     [not found] ` <9fc41018.ADkAACbGIQ0AAAAAAAAAAAPNhpIAAAACwQwAAAAAAAW9WABZeyNz@mailjet.com>
2017-07-28 14:56   ` Oleg Pykhalov
2017-07-29 11:17     ` bug#27859: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4823d772.ADkAACbGIQwAAAAAAAAAAAPbn-sAAAACwQwAAAAAAAW9WABZeyNz@mailjet.com \
    --to=arunisaac@systemreboot.net \
    --cc=27859@debbugs.gnu.org \
    --cc=go.wigust@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.