From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OPaOKbjVhmCtFgEAgWs5BA (envelope-from ) for ; Mon, 26 Apr 2021 17:01:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EN48JbjVhmBnRwAAB5/wlQ (envelope-from ) for ; Mon, 26 Apr 2021 15:01:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F663DA19 for ; Mon, 26 Apr 2021 17:01:12 +0200 (CEST) Received: from localhost ([::1]:48174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb2jX-000306-Dy for larch@yhetil.org; Mon, 26 Apr 2021 11:01:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb2iV-0002qw-GC for guix-devel@gnu.org; Mon, 26 Apr 2021 11:00:07 -0400 Received: from mail.zaclys.net ([178.33.93.72]:34271) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb2iS-0004G9-4n for guix-devel@gnu.org; Mon, 26 Apr 2021 11:00:07 -0400 Received: from [192.168.1.115] (lsl43-1_migr-78-195-19-20.fbx.proxad.net [78.195.19.20] (may be forged)) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 13QExtlK017303 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 26 Apr 2021 16:59:55 +0200 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 13QExtlK017303 Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1619449196; bh=3FX+aydaAPq3cOj7Bjx8xSDukLel1so4Wg84wA2vVsY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=UOCRXWt5MIE1clrgLlqygu7tz0+F/yACYBBQImpawBceb2cUjI+JuEsqOBzqj00tL fJ1yJOzyW4PK2/91sUJC03M5xIowC5e6thC8/3XzmeQ49XDITnzFcUf71GXPXJJoL+ WtvdlopMS1k/H+n7X9bM/lt99xj9l1czWgxAtgq4= Message-ID: <475c152f2e4bf0b566324223f2f5e3598279b87f.camel@zaclys.net> Subject: Re: A "cosmetic changes" commit that removes security fixes From: =?ISO-8859-1?Q?L=E9o?= Le Bouter To: Mark H Weaver , Leo Famulari Cc: Maxim Cournoyer , Raghav Gururajan , Guix Devel , Leo Prikler , Sou Bunnbu Date: Mon, 26 Apr 2021 16:59:49 +0200 In-Reply-To: <8735vgkttf.fsf@netris.org> References: <87tunz11mf.fsf@netris.org> <87r1j30xmo.fsf@netris.org> <87czumypz3.fsf@netris.org> <87o8e4zy5k.fsf@gmail.com> <5cbbfa9b258fb28beb9288685ccc85b4d015cd8a.camel@zaclys.net> <8735vgkttf.fsf@netris.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-JMVu2lKeQ1lagbPz6jK0" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Received-SPF: pass client-ip=178.33.93.72; envelope-from=lle-bout@zaclys.net; helo=mail.zaclys.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619449272; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=3FX+aydaAPq3cOj7Bjx8xSDukLel1so4Wg84wA2vVsY=; b=ES1QQDrK8RAXZQ/PF184rpMeU9PrHByUkpZQ/NlZ7VBxgOvWQ5Z1wkpCO3xdZWFUQ6cuDD avMKJ/lwJDAuTs4icgmSj6OkxM7vJVkzeyMtdwvMh341jEsv7zehENgluIwh5yncoKhylI 2MKKKAUxhpHNVeMzWM2FfuXmLD8+g47XUNT27IuB/Gr2VU6quCMrYzNQWDp9hdwtOjHD9h 3HHRxREJJjuoBP79q416lGsJg/fqs8CwKsJFdbphZD9ZE1/Z4n/hp/iVM7MNjZ0qQKH5Q3 yrDL0+mdDl9o+DTvXGQz0zHDT0uTSNztHWTYGefZ4LFO/Ix2sqKfHBorGiMI1Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619449272; a=rsa-sha256; cv=none; b=HW5hQDGxizHYpDsQqT3BnG5UXvSCdhvrF0re04aRRI2ZTrWQafs8GaGLumQELqmb2VklSH hdTwsEG7PR2HvTdxpvrisPCOilLy+ocg/wGlkOPfaYESDS+MQjC3Qq1tLq/dAklXwoAUoA cMdDd7W6XMWzwvVxaFmCu7vK0RuCTYF6LO0qJ+i126PMgWwv/F74VnAKG/VB9IddC1g6Aw 6AGIALSv0nsV9BSVkUxAWrYA4sguRHW2bT/0G2uYbfuj+rTN+Hi+dJYc0DI8SItnbQ4CSb xqmA7J1W5eA8jo2ksuc2wg92NQnx27UDSLNQJf2ap7SxD1zRQymX1gZDnYUbyg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=zaclys.net header.s=default header.b=UOCRXWt5; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -4.38 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=zaclys.net header.s=default header.b=UOCRXWt5; dmarc=pass (policy=reject) header.from=zaclys.net; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: 5F663DA19 X-Spam-Score: -4.38 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3sHdqhrpc26f --=-JMVu2lKeQ1lagbPz6jK0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2021-04-24 at 03:46 -0400, Mark H Weaver wrote: > Hi L=C3=A9o, >=20 > L=C3=A9o Le Bouter writes: >=20 > > On Fri, 2021-04-23 at 15:18 -0400, Leo Famulari wrote: > > > L=C3=A9o and Raghav, you need to keep learning our workflow around > > > security updates. It's not okay to remove security patches and > > > later > > > update a package to a fixed version in a different commit. `git > > > rebase` is the tool to learn for cases like this one. > >=20 > > I knew about this but I didnt feel like telling Raghav to do yet > > another rebase. I felt like Raghav was taking on with so much > > already. >=20 > This response is what native English speakers call a "red herring" > ;: something that misleads > or > distracts from a relevant or important question. >=20 > Why do I say that? As I pointed out elsewhere in this thread, >=20 > https://lists.gnu.org/archive/html/guix-devel/2021-04/msg00366.html >=20 > it appears that Raghav didn't actually remove the security fixes; it > appears that *you* did. Therefore, I fail to see how it could have > been > avoided by asking Raghav to do another rebase. >=20 > From the IRC logs cited in the message above, it appears that you > took > the liberty of modifying Raghav's "cosmetic changes" commits to also > remove security fixes in the re-indented packages, while claiming in > the > summary lines that you were "ungraft[ing]" cairo and glib. >=20 > =20 > https://git.sr.ht/~lle-bout/guix/commit/a045a48dd961f0c5c3d536dcc3fd21d9c= 08d2d50 > =20 > https://git.sr.ht/~lle-bout/guix/commit/6477daa338fbf1c9edacfc3690aca77ca= cfe0008 >=20 > Can you please explain what went wrong here? >=20 > Thanks, > Mark >=20 Hello Mark, I will not answer anything to you anymore because I feel like you do not write messages in a constructive way. L=C3=A9o --=-JMVu2lKeQ1lagbPz6jK0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmCG1WUACgkQRaix6GvN EKb+PRAAugVNmMDVjAfuqiUCx+38L9/7miP+be84keTaS+AfZtGAGth2RhKwHcAu Cdf0BGHlV5Mw24W2yw0n8Fc3TwgNPtiPxImRks1BaVJDvrn+TyMZJy4SxQgf2eFI y2iWLNw+xOafPQuMXtfLIgf1XFMBzh8NR1h5NS/trmuVw6nRWgtJTei1lDpFIKDv 7ii3DN8clQfCj3+SqMkSmcKg+9zSpBG10iGcU0Re6u0G0LSdOIbwl8DD4wJAHpRi ZTTmVtaIv834INmC7/hjbYqjVgOnwvdF9KZgBkPacE2lv2e62vRn0xls1Ud2FVgR JkD4ACCKY6kikaA0qnloUpToAEL9X5mxyUBSoRrpVt+AvyQleoMQV6jhhUaqxwZb Uke2X3qtZWHqpy2ZDRMY2IJviz/+iWAbmN3plVbHzJKTuiXX6mrSy7LJVcRUHmky LEBxO6aNVdqBpcpy8KIKWIGNsn6vyLYQuqEVsHbVIG0ocpKZhtN2fDIoKS1n2QGi j7U+2wUc++8h23pXjakFHsus/QHpLP5lpFXW2uDRSy4GeaoDNR8B+biXp1NAXyAy aGQOfhIE1tL9DXrAG6o0B87LG+Uc9k0DlEtYXGewW0/onBumS+c1q5f7RCmfk4cf O/nNpKq6OFZqZ1gbL0T7dO00Uvr4tWyXu00uUok4G0zXJ4rX88w= =Kcfs -----END PGP SIGNATURE----- --=-JMVu2lKeQ1lagbPz6jK0--