From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +NRCE3nAyWDaGgAAgWs5BA (envelope-from ) for ; Wed, 16 Jun 2021 11:12:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cBn5DnnAyWBLNQAAbx9fmQ (envelope-from ) for ; Wed, 16 Jun 2021 09:12:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A7DC422032 for ; Wed, 16 Jun 2021 11:12:24 +0200 (CEST) Received: from localhost ([::1]:53498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltRax-0003tE-Dy for larch@yhetil.org; Wed, 16 Jun 2021 05:12:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40832) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltRac-0003sS-Qq for guix-patches@gnu.org; Wed, 16 Jun 2021 05:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ltRac-0003f2-IN for guix-patches@gnu.org; Wed, 16 Jun 2021 05:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ltRac-0000sm-A9 for guix-patches@gnu.org; Wed, 16 Jun 2021 05:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48703] [PATCH 0/4] Update python-numpy References: In-Reply-To: Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Jun 2021 09:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48703 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48703@debbugs.gnu.org Received: via spool by 48703-submit@debbugs.gnu.org id=B48703.16238346713327 (code B ref 48703); Wed, 16 Jun 2021 09:12:02 +0000 Received: (at 48703) by debbugs.gnu.org; 16 Jun 2021 09:11:11 +0000 Received: from localhost ([127.0.0.1]:51541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltRZn-0000rb-JJ for submit@debbugs.gnu.org; Wed, 16 Jun 2021 05:11:11 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ltRZk-0000rC-9s for 48703@debbugs.gnu.org; Wed, 16 Jun 2021 05:11:10 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id DDA03240028 for <48703@debbugs.gnu.org>; Wed, 16 Jun 2021 11:11:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1623834661; bh=CQR1XE2M8WPZ0ByFMd/kydLAtoLmSAKIok5dWGUzJpI=; h=Subject:From:To:Date:From; b=RzDgDAWmZEApKOwED57G50VqRF6IYdfPDwojLoxttO5Ow33/PA9AVxKjWlIVCFsNu 6u5X7b23DaoChgjcUrAnT4AVs+58InFKQnQa1fA7FMoDbwxBD97W2fcAnchvqhZfbj WdWgfUnANGtG7uVNeVi0hwfh+rwGKWH/+jlqNZmZmgyi19vU+VATcU1jwKffxTYZKF Qh146DjHDrzsvZRF9O8NxdlfqgNuYPRR9zfCHb893M1AAnj2KQvItGlpAqrtczvFPh 4Crpd7+S7SIvlZJpszlGo8tGYcKon/iP3l3js1AyS5aeJtYSfnURFC8U/KrUXhwJEO iA8Pb8aRzGwHQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4G4fYc5bn7z6tmJ for <48703@debbugs.gnu.org>; Wed, 16 Jun 2021 11:11:00 +0200 (CEST) Message-ID: <462a8613b51f255d4c004c1619c8200535574086.camel@posteo.net> From: Vinicius Monego Date: Wed, 16 Jun 2021 09:10:52 +0000 Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1623834744; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FQMsfxHST66+SeIDJJ7WmEqXuXOPN0DnDXi1p1Kxoks=; b=OdxwIlsipOedDQo6zWoImo4r22WS+TGtISYstzcpneis5u5g//9XvyUtUm+fxiqFp5ad50 Jf4zz1npio6lKg89R/Z1m5Kgt4BmNMAV0Sm8qqu1k5WXnLH2FWLPWvSPR92bhIWaoDhAFY YViPtY1GfZ9D3APJtrJIq7Omnrdb2uwnnacqXABp5lTwItnuYBDTezpfCJnHvUr4NLw8xN ksdjHD8izHWcIZJqI/amvQ7Uz9t+4wnPoaWQs7tMASh5vQMhCWD9R9Cxa5Z21Ith1q8ok7 MvikNZcUtgl0NdIS73ARI7d8DZevsv+isqC2EnZRgfoq4rIZrFFHgao1hhFqSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1623834744; a=rsa-sha256; cv=none; b=TYB0hDAC261n4EbA5lOKpLkrMw5dQGX3L1e5iSg3Aix596qYmWI1Ys6fVLJgv1eBRUzGLk GtZjN87jbVDSWlozwc7Onc3vAjvz9vUe/g33ymm0sdCO+Xg2dlqU3+tbIMuEJIoEqc2dkB IyRN7TPMFEeJwK8D7d06SRi2hZSaf8+DxvixXxdfl9CmQQU3hJN6Iu09syum0ymrXawxw7 M/6aVOqwWyqXxpm7eEWq+mgxSuJUuymAff3y9g6Eac1ZyqD3/n/YnCx2BX9nyiYVsJlstO EqqPsMkriVQhJHJVo4PA3kLEiXOwuwLOQnTswRWnGvpHf2b8kU0ZUSUO5mQSyQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=RzDgDAWm; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.32 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=RzDgDAWm; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A7DC422032 X-Spam-Score: -1.32 X-Migadu-Scanner: scn1.migadu.com X-TUID: qJZWeYkN0tzb Hello, Since this is a mid to long term update (the packages have quite a few [heavy] dependents), I'd like to suggest some refactoring. I will talk about each package separately. - python-numpy: 1. Why is it sourced from a tar.gz in the github releases page and not from PyPI or a checkout? I had a look at the PyPI source file and the tests are provided. If that source is required, a comment would help. 2. > ;; Tests can only be run after the library has been installed and not > ;; within the source directory. I'm not sure if pytest was invoked manually or if the runtests.py script was executed to reach that conclusion. Numpy uses the tests under subdirectories structure. In that case, tests should run with "python -m pytest --pyargs numpy" or "pytest -- pyargs numpy". I have this generic template that worked for all of my packages so far: > (replace 'check > (lambda* (#:key inputs outputs tests? #:allow-other-keys) > (when tests? > (add-installed-pythonpath inputs outputs) > (invoke "python" "-m" "pytest" "--pyargs" "numpy")))) NumPy could be a special case, but a more detailed comment would help. 3. #:tests? is not respected. 4. Don't return #t in the phases. - python-scipy 1. Same comment about tests from NumPy. Overriding the check would also allow removing the 'disable-broken-tests phase. 2. #:tests? is not respected here either. 3. Don't return #t in the phases. 4. Since documentation is being built, it would be good to have the sphinx theme for scipy ready. The current documentation doesn't have any CSS. Not a big problem though. - python-matplotlib 1. Respect #:tests?. 2. Don't return #t in the phases. LGTM otherwise. - python-pandas 1. I think the check phase could be simplified by using the same pytest structure suggested in numpy and scipy. 2. Respect #:tests? 3. Don't return #t in the phases.