From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Lepiller <julien@lepiller.eu>
Subject: Re: Packaging async and underscore
Date: Fri, 30 Nov 2018 17:08:11 +0100
Message-ID: <457c8004267eef9c76f22457ae45fde8@lepiller.eu>
References: <b50a9db6-0d8f-a25e-85f7-67c2a8eef3ea@riseup.net>
	<70F182DB-C157-4763-A4C6-89985545661C@lepiller.eu>
	<0e5afb2d-c182-6be4-ba2d-6a6f7dd45ac9@riseup.net>
	<1150DF84-4952-4401-A8D0-3E05A4D0EB74@lepiller.eu>
	<cdeb68b8-fb69-0414-6f76-3689e1cd190a@riseup.net>
	<23f36a0d-a5ef-5457-1d8e-61fbebda91c4@riseup.net>
	<87zhu3b41w.fsf@gnu.org> <87va4qxf8e.fsf@posteo.net>
	<a8199901-536e-03fd-f3e0-ccda7f539fe9@riseup.net>
	<62a1a976-ed2f-a68d-0aa8-d6fb6bd46c14@riseup.net>
	<8684f18c-af86-4b67-9b54-fe5d755cde14@riseup.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42323)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1gSlL0-0001R7-8F
	for guix-devel@gnu.org; Fri, 30 Nov 2018 11:08:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <julien@lepiller.eu>) id 1gSlKx-0003Fe-KF
	for guix-devel@gnu.org; Fri, 30 Nov 2018 11:08:18 -0500
Received: from lepiller.eu ([2a00:5884:8208::1]:36928)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <julien@lepiller.eu>) id 1gSlKx-0003Cw-7H
	for guix-devel@gnu.org; Fri, 30 Nov 2018 11:08:15 -0500
Received: from webmail.lepiller.eu (static-176-182-42-79.ncc.abo.bbox.fr
	[176.182.42.79]) by lepiller.eu (OpenSMTPD) with ESMTPSA id cb62ff94
	(TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO)
	for <guix-devel@gnu.org>; Fri, 30 Nov 2018 16:05:39 +0000 (UTC)
In-Reply-To: <8684f18c-af86-4b67-9b54-fe5d755cde14@riseup.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

Le 2018-11-30 15:17, swedebugia a écrit :
> On 2018-11-22 02:02, swedebugia wrote:
>> Hi
>> 
>> On 2018-11-22 00:22, swedebugia wrote:
>> snip
>> 
> snip
> 
>> While investigating the top libraries* packages with most depends in 
>> npm I found the following:
>> 
>> Lib        Dep    DevDep    RecdevDep    Dependants    license
>> underscore    0    12    2400+        18000+        mit
>> async        1    37    2696        26069        mit
> 
> I succeded in packaging the latest underscore. I discovered a bug in
> the build system and fixed it to be able to build it. (see the diff
> attached)
> 
> Debian packaged a 4 year old async 0.8.0 that has 0 dep and only
> uglify-js as devdep (which we already have packaged). From 0.9.2
> lodash was made a devdep.

Thanks, I'll merge that with my version of the patches, and send them 
both for review. I think they are already very good, unless you think we 
need more time to make sure the build system is perfect.

Could you explain why this is necessary? In what case does this 
directory doesn't exist? I also wonder if it can be the case that 
node_modules is a file or a symlink that isn't catched by your check...