From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id aINzLZXQzmXxLQAA62LTzQ:P1 (envelope-from ) for ; Fri, 16 Feb 2024 04:03:49 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id aINzLZXQzmXxLQAA62LTzQ (envelope-from ) for ; Fri, 16 Feb 2024 04:03:49 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=bG9rfXOU; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708052629; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vUOeYLjww0UkklO8LMraaVV7s/SBK1EGkscBZtctIgk=; b=YXgWIgf3T0Ie3qoae29JR4rQjPyaXkPXpKGlrmqWJ5YS1C1v+XyVXdfmB6/pkOWIx62pUg ai/S5t0TKOMyPgqMO4DwcLRDdAODD4w100RTDgxvxkXj7n0DfarVD8N/W0elmaD9X1FQUR KkFeVOO/g9AUzxDUsz521zLKOr88KzrmKGrNg0t9kDIOS3lCl0O8bsKSd4w8TEimw68XaX d8P/j1lkiIxcOkCiqVX/yz0cKbCl4bVVhVyKTP5PksEu0AuBs/gaQWy4NIZf3y+WkdQQ3F 1LaBpbCEBmh1D+YSuKH61PXycWlUvDeXIQM2f0GNLO4iw3ROlcc7M83SlZww2w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=bG9rfXOU; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708052629; a=rsa-sha256; cv=none; b=u3CotyPTNaJZO4z2wWDTHkNBG6MAKI0HWwN+z3ogMTClXs/+yHGajYmbHTgs00v7qir0Ta DFundhHwbTHvMFQKLmwfdDeHpKvu4f0QHfqehCRwo4/dYWay7xyHfYxOIyKMOiehVOKdES BuXiGEGsxGy3Ba/oQe8PlFLA6AX+Uznjzmlx9v2B4O5JrSK/8rH4Q1aFzhHApPU38M/QkC g3lS9iAmjHKHDT4SKaJ0DM7hfqaT9Nv82Mp5wemM3j4oqgkLmQB4dhI4b+/aJYT1Xtd6VX ETVtZoK2f/zaPPgSSxwLpd5bvdtLgatFgNwtLPJpwaGcHxcwU7SPrWTnhp0WMg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9205C15F14 for ; Fri, 16 Feb 2024 04:03:49 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raoVt-0004SU-JU; Thu, 15 Feb 2024 22:03:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raoVr-0004S2-KB for guix-patches@gnu.org; Thu, 15 Feb 2024 22:03:43 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raoVr-0008FS-BS for guix-patches@gnu.org; Thu, 15 Feb 2024 22:03:43 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raoWA-0006gM-9H for guix-patches@gnu.org; Thu, 15 Feb 2024 22:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69131] [PATCH 1/2] gnu: Add passt. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 16 Feb 2024 03:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69131 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69131@debbugs.gnu.org Received: via spool by 69131-submit@debbugs.gnu.org id=B69131.170805259525629 (code B ref 69131); Fri, 16 Feb 2024 03:04:02 +0000 Received: (at 69131) by debbugs.gnu.org; 16 Feb 2024 03:03:15 +0000 Received: from localhost ([127.0.0.1]:57712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raoVO-0006fI-Ix for submit@debbugs.gnu.org; Thu, 15 Feb 2024 22:03:15 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]:31003) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raoVL-0006f4-Tl for 69131@debbugs.gnu.org; Thu, 15 Feb 2024 22:03:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1708052566; x=1708311766; bh=vUOeYLjww0UkklO8LMraaVV7s/SBK1EGkscBZtctIgk=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=bG9rfXOUNltxHZwx4oF9WrguVEQQTos6rzL0oOfoezq+SC0iWTt3k95rZQPquHBOU VmR7Po/hsNJYCS52vwvwGQHcKEjdHLII59e3tSyTAgTWWrr9CuzCjjDqlGqimgaXEL qmR3GKsWzBHCKqrHlV3xjOcJmQBcMDe4lX4oI41wzOOLrQYswHNJJa4NqM7GejNUwt hRC3JIUloAiRlGUGHK2J8Li5DwgAznONxsXpDOp+rL3BscWcDnUPzOy2YwJxk7rZcZ xT+h/e98uUlH1aXcQgosGsfs9FeFxPlgU83Tavnn2ylgURGM3AoaM0vvqng9AjwQPd gZD99e5g9YYFA== Date: Fri, 16 Feb 2024 03:02:43 +0000 Message-ID: <44375893-d991-49cf-a050-68ce493de299@protonmail.com> In-Reply-To: References: Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.98 X-Spam-Score: -6.98 X-Migadu-Queue-Id: 9205C15F14 X-Migadu-Scanner: mx13.migadu.com X-TUID: 2lp3noDZCQsz "Add passt" review notes: The following checklist is based on the items listed in the manual (22.7=20 "Submitting Patches"). Each checklist item may have one of the following=20 statuses: C: Commitable. This item looks as expected for a final commit. CC: Commitable with Context. Like commitable, but some notes have been=20 added providing context about anything notable or unusual. These notes=20 are provided for transparency or to set expectations for the committer=20 and should not be interpreted as meaning that I object to the patch. MR: Minor Repair. There is something about the patch which I think=20 should ideally be changed, but I do not think that the commit should be=20 held up for this reason alone. A: Attention. Something in the patch needs attention from the author,=20 the committer, or both. Resolving the matter may or may not require a=20 change to the patch. Blank: I did not review this aspect of the patch. [CC] Applies cleanly (commit bd87416648929f38c0173f047776d7675ea8a10d) [CC] Cryptographic hash [C ] Synopsis & Description [C ] Package license matches source license [C ] No compiler warnings [CC] `guix lint` output [MR] `guix style` output [C ] Package builds (my host is an x86_64 Xen guest) [=C2=A0 ] Builds for other architectures [C ] No bundled software [=C2=A0 ] Works in container with minimal inputs [C ] `guix size` output [C ] Dependent packages (`guix refresh --list-dependent PACKAGE`) [C ] `guix build --rounds=3D2` [C ] Gender-neutral wording [C ] One set of related changes [=C2=A0 ] Simulated guix pull # Patch Application The copyright statement in the first patch does not apply cleanly=20 because commit 6002e9e7711136373de5a6325769e9c7d11032c9 recently added=20 it already, but git successfully processed that diff after manually=20 deleting the chunk from the patch. # Cryptographic Signatures I was not able to locate signatures for either the source tarball or the=20 git commits. # Guix Lint Output The linter printed two notes, one that the 'generic-html' updater failed=20 to find upstream releases and another indicated that archives are not=20 available from either Software Heritage or Disarchive. As I understand=20 it, these issues issues should not block the package. Not every package=20 has an automatic updater (though it would be nice if they did) and the=20 release page for this project is atypical. The 'archival' section in the=20 "Invoking 'guix lint'" chapter (9.8) indicates that the Software=20 Heritage will pick up the source at some point in the future. # Guix Style output (Minor repair) The tool made some reasonable-looking changes. I'm not sure if it would=20 be appropriate for me to add a new patch to this thread that applies=20 these changes. # Runs in a container with minimal inputs This package wants to use QEMU, and my machine is already a Xen guest. I=20 know that there are some complications when it comes to nested=20 virtualization. The demo script (at #$output/share/doc/passt/demo.sh)=20 did not "just work" for me, but it's not clear to me that this is a=20 problem with the package. I tried running it with the following: ``` $ # Extra inputs are for the shell script $ ./pre-inst-env guix shell -C iproute2 coreutils util-linux-with-udev=20 passd [env]$=20 /gnu/store/wgzlv2chrxmk4y4m4fxx8g7x0z59cb98-passt-2023_12_30.f091893/share/= doc/passt/demo.sh ```