all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Adam Faiz <adam.faiz@disroot.org>, 64362@debbugs.gnu.org
Cc: iyzsong@envs.net
Subject: [bug#64362] [PATCH 3/3] gnu: Add mc2mt.
Date: Fri, 30 Jun 2023 20:23:25 +0200	[thread overview]
Message-ID: <43ba5dee30a02e26492f0ae8b29946bf88d9e652.camel@gmail.com> (raw)
In-Reply-To: <77adeda8-6ab9-19f5-4b47-bed7a9f12a42@disroot.org>

Am Freitag, dem 30.06.2023 um 17:34 +0800 schrieb Adam Faiz:
> From 0555ce12cecf1f5244d9ca973a7686b3d9d5bc3d Mon Sep 17 00:00:00
> 2001
> Message-Id:
> <0555ce12cecf1f5244d9ca973a7686b3d9d5bc3d.1688116740.git.adam.faiz@di
> sroot.org>
> In-Reply-To: <cover.1688116740.git.adam.faiz@disroot.org>
> References: <cover.1688116740.git.adam.faiz@disroot.org>
> From: AwesomeAdam54321 <adam.faiz@disroot.org>
> Date: Fri, 30 Jun 2023 16:56:23 +0800
> Subject: [PATCH 3/3] gnu: Add mc2mt.
> 
> * gnu/packages/game-development.scm (mc2mt): New variable.
> ---
>  gnu/packages/game-development.scm | 68
> +++++++++++++++++++++++++++++++
>  1 file changed, 68 insertions(+)
> 
> diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-
> development.scm
> index 52f8a3787d..6a5656e3f3 100644
> --- a/gnu/packages/game-development.scm
> +++ b/gnu/packages/game-development.scm
> @@ -56,6 +56,7 @@ (define-module (gnu packages game-development)
>    #:use-module (guix utils)
>    #:use-module (guix build-system cmake)
>    #:use-module (guix build-system gnu)
> +  #:use-module (guix build-system pyproject)
>    #:use-module (guix build-system python)
>    #:use-module (guix build-system scons)
>    #:use-module (gnu packages)
> @@ -1744,6 +1745,73 @@ (define-public ois
>      (home-page "https://github.com/wgois/OIS")
>      (license license:zlib)))
>  
> +(define-public mc2mt
> +  (let ((commit "039dbc26466a430e03c646dc5a9bd0822637a87a")
> +        (revision "0"))
> +  (package
> +    (name "mc2mt")
> +    (version (git-version "0.1" revision commit))
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/listia/mc2mt")
> +             (commit commit)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "1vnaznwgm87x0n5dp14363p2h54lpzalynrrd6lbs6wgrqq7fq9i"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        #~(begin
> +            (copy-recursively "mc2mt.py" "mc2mtlib/mc2mt.py")
> +            (substitute* "mc2mtlib/__init__.py"
> +              (("from . import minetest_world" all)
> +               (string-append "from . import mc2mt\n"
> +                              all)))
> +            (substitute* "mc2mtlib/argument_parser.py"
> +              (("mineclone2") "mineclone"))
> +            (substitute* "mc2mtlib/mc2mt.py"
> +              (("if __name__ == '__main__':")
> +               "def mc2mt():")
> +              (("(from mc2mtlib import )\\*" all import)
> +               (string-append
> +                import "argument_parser\n"
> +                import "minetest_world\n"
> +                import "blob_writer\n"
> +                import "block_functions\n"
> +                import "block_conversion\n"
> +                import "section_conversion\n\n"
> +                "parse_args = argument_parser.parser.parse_args")))
> +            (with-output-to-file "MANIFEST.in"
> +              (lambda _
> +                (format #t
> +                        "\
> +include mc2mtlib/mods/*.json~%")))
> +            (with-output-to-file "pyproject.toml"
> +              (lambda _
> +                (format #t
> +                        "\
> +[build-system]~@
> +requires = ['setuptools']~@
> +build-backend = 'setuptools.build_meta'~@
> +~@
> +[project]~@
> +name = 'mc2mt'~@
> +version = '0.1'~@
> +dependencies = ['anvil-parser']~@
> +~@
> +[project.scripts]~@
> +mc2mt = 'mc2mtlib:mc2mt.mc2mt'~%")))))))
This snippet looks like you really want to write a patch or two.
> +    (build-system pyproject-build-system)
> +    (propagated-inputs (list python-anvil-parser))
> +    (arguments
> +     (list #:tests? #f)) ; no tests
> +    (synopsis "Minecraft to Minetest world converter")
> +    (description "@code{mc2mt} is a Minecraft to Minetest world
> converter.
> +It can convert worlds from Minecraft 1.9 and later.")
> +    (home-page "https://github.com/listia/mc2mt")
> +    (license license:expat))))
> +
I think we should tone down on the usage of "Minecraft" in synopses and
descriptions.  In particular for the dependencies it ought to describe
the file formats without referring to the program that produces them.

Cheers

  reply	other threads:[~2023-06-30 18:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-30  9:10 [bug#64362] [PATCH 0/3] gnu: Add mc2mt Adam Faiz via Guix-patches via
2023-06-30  9:21 ` [bug#64362] [PATCH 1/3] gnu: Add python-nbt Adam Faiz via Guix-patches via
2023-06-30  9:22   ` [bug#64362] [PATCH 2/3] gnu: Add python-anvil-parser Adam Faiz via Guix-patches via
2023-06-30  9:34     ` [bug#64362] [PATCH 3/3] gnu: Add mc2mt Adam Faiz via Guix-patches via
2023-06-30 18:23       ` Liliana Marie Prikler [this message]
2023-07-01  3:20         ` Adam Faiz via Guix-patches via
2023-07-01  5:31           ` Liliana Marie Prikler
2023-07-01 11:40             ` [bug#64362] [PATCH v1 1/3] gnu: Add python-nbt Adam Faiz via Guix-patches via
2023-07-01 11:42               ` [bug#64362] [PATCH v1 2/3] gnu: Add python-anvil-parser Adam Faiz via Guix-patches via
2023-07-01 11:44                 ` [bug#64362] [PATCH v1 3/3] gnu: Add mc2mt Adam Faiz via Guix-patches via
2023-07-01 14:14 ` Adam Faiz via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43ba5dee30a02e26492f0ae8b29946bf88d9e652.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=64362@debbugs.gnu.org \
    --cc=adam.faiz@disroot.org \
    --cc=iyzsong@envs.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.