From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org, guix-commits@gnu.org
Subject: Re: branch master updated: gnu: Add r-loomr.
Date: Thu, 10 Sep 2020 11:13:52 +0200 [thread overview]
Message-ID: <436d649127861cd5e0f642551ece6729ed7500cb.camel@gnu.org> (raw)
In-Reply-To: <877dt36iqx.fsf@elephly.net>
Hi Ricardo,
On Wed, 2020-09-09 at 18:02 +0200, Ricardo Wurmus wrote:
> Hi Roel,
>
> > This is an automated email from the git hooks/post-receive script.
> >
> > roelj pushed a commit to branch master
> > in repository guix.
> >
> > The following commit(s) were added to refs/heads/master by this
> > push:
> > new 1f56ec0 gnu: Add r-loomr.
> > 1f56ec0 is described below
> >
> > commit 1f56ec08af704bdc7aa3e143bf5ce351c5306dea
> > Author: Roel Janssen <roel@gnu.org>
> > AuthorDate: Wed Sep 9 16:56:02 2020 +0200
> >
> > gnu: Add r-loomr.
> >
> > * gnu/packages/bioinformatics.scm (r-loomr): New variable.
>
> This is not free software. See
>
> https://github.com/mojaveazure/loomR/pull/24
Oh shoot. I'm sorry I didn't see this discussion!
> Aside from this, I would like to say two things:
>
> > gnu/packages/bioinformatics.scm | 26 ++++++++++++++++++++++++++
>
> Let’s please not add R packages to (gnu packages bioinformatics) when
> it
> can be avoided. (In this case there’s no CRAN package, so it’s
> fine.)
Where would I add a non-CRAN and non-Bioconductor package to? Perhaps
this situation won't occur again, and should raise a flag, because I
think I've never had this case before.
> > +(define-public r-loomr
> > + (package
> > + (name "r-loomr")
> > + (version "0.2.0-beta")
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append
> > + "https://github.com/mojaveazure/loomR/archive/"
> > + version ".tar.gz"))
>
> This is not okay as these generated tarballs are not stable. I
> haven’t
> seen these patches on guix-patches before — maybe I missed them. But
> we
> have been avoiding these kind of URLs since a long time and had I
> seen
> the patches on guix-patches I and other would probably have pointed
> this
> out.
>
> Can you please revert this ASAP?
I see you've reverted it already. Thanks for that!
I will default to submitting patches to guix-patches again. I thought
it was trivial enough to just push. My mistake.
Kind regards,
Roel Janssen
next prev parent reply other threads:[~2020-09-10 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200909145626.7782.91114@vcs0.savannah.gnu.org>
2020-09-09 16:02 ` branch master updated: gnu: Add r-loomr Ricardo Wurmus
2020-09-10 9:13 ` Roel Janssen [this message]
2020-09-10 10:38 ` Ricardo Wurmus
2020-09-10 12:01 ` zimoun
2020-09-10 12:23 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=436d649127861cd5e0f642551ece6729ed7500cb.camel@gnu.org \
--to=roel@gnu.org \
--cc=guix-commits@gnu.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.