From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id eG97FaLzvWYpAwEAqHPOHw:P1 (envelope-from ) for ; Thu, 15 Aug 2024 12:25:06 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id eG97FaLzvWYpAwEAqHPOHw (envelope-from ) for ; Thu, 15 Aug 2024 14:25:06 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=QlbTQ15K; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=E3IDGBTA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1723724706; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=YLy4x6pg6UkuAcldG3pctb8eVCK8B5J0yQVfDuafFWI=; b=kqr0bLtm/TRJUITrfe5pngxmv5In9VOZAs5sdaeTDiTn+acYNBHC+5rAbvvWJC26eE42iA DyVw9ZksccKNfNwNwg44WzSHvZTZDewNMV7RoIJl3Nvidk8XMrQZlaeiNBSPcSLZoJTHV+ TGEK13mC8mWr4je72DWs2Tw808w9d9FC06yFApcDczJT2HX5i1KC8AJYGzTzlNV1XUsNFL gsFj0QKPYKGdPovPdjasEGE/Cb4ZzNgcvZMO8OfBSLeFYkbg7H55yH08DsKvu5x1PRsTbd D7rXMGUcRD8Ni6sZIAQiS+4EIVq5ey0+7AyWOIgZPjdeUVmFXM/9nJ+G6WVlew== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1723724706; a=rsa-sha256; cv=none; b=d5EaE1JouUnfKyRBpE1tDjpthob8vL0CblxbcHBw1sXdl0oqB3q6VTyIcGfNvpi1Ja8Ow/ /soYfTnyYW94fVBICoSic6mftJ20brQkY5NByMt9D2xK0Ci/I/QF+RU6TaOql3XW0p/YiE CY+duhMrRh6mDzh2xbhUijeYCaBn48OPU1ii0wT8n7kj4sY1iXngV+8qba9Fwd/rLL7OCf xcuPk40rStGdgGpXOC7NWahGW26UV3onAk75r7SAxdFBhnRTjQItxfqXzZI8QhORto8PRO wagLxD23zTPrpESeAPQjx+cWB/KYbO8dnVsN9reNpvdv84J0v/9vspxwTsh2EQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=QlbTQ15K; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=E3IDGBTA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B199103A9 for ; Thu, 15 Aug 2024 14:25:05 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1seZWp-0008Qn-6P; Thu, 15 Aug 2024 08:24:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1seZWl-0008Px-GF for guix-patches@gnu.org; Thu, 15 Aug 2024 08:24:27 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1seZWl-0001Ic-7M for guix-patches@gnu.org; Thu, 15 Aug 2024 08:24:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=From:MIME-Version:Date:To:In-Reply-To:References:Subject; bh=YLy4x6pg6UkuAcldG3pctb8eVCK8B5J0yQVfDuafFWI=; b=QlbTQ15KzjrhIUdicU7qlTum8Gs3z1hGoWcwHUWjfDQ9rnM3ptm37eotZTM703fvu02rmGoE8ZrvrYBjKHP4rWDGZpLyYTYggN1QVbX0f4ev9xUGhXME875jtVHWOPjn4TIdh4vTU4mkMwdyxfo9alfCeAVJo5e4LKzNNOFGu/zNTA3YtHiqveCWyLVqZEUcj70OJT7r5XGo+bxn3pkIHLTKk63zgAfyd9xt72MTmFOuqR8w2lU3W1bFp2qvgz1Uy6jnhzWnxe3BjKZ47eA6495ccuPZ08UKAagjOW228sf1uVAt+1xaHTrfhFy0AGkHf5CW5rf93xhQwrGyNpTSCw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1seZXK-0003ct-5r for guix-patches@gnu.org; Thu, 15 Aug 2024 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72621] [PATCH] gnu: Add clasp. References: In-Reply-To: Resent-From: Aleksej Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Aug 2024 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72621 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 72621@debbugs.gnu.org Received: via spool by 72621-submit@debbugs.gnu.org id=B72621.172372469913916 (code B ref 72621); Thu, 15 Aug 2024 12:25:02 +0000 Received: (at 72621) by debbugs.gnu.org; 15 Aug 2024 12:24:59 +0000 Received: from localhost ([127.0.0.1]:48472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seZXG-0003cN-Dj for submit@debbugs.gnu.org; Thu, 15 Aug 2024 08:24:58 -0400 Received: from layka.disroot.org ([178.21.23.139]:52938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1seYQF-0001ki-4v for 72621@debbugs.gnu.org; Thu, 15 Aug 2024 07:13:40 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8691D4127B for <72621@debbugs.gnu.org>; Thu, 15 Aug 2024 13:12:59 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qUEHSki-w_gR for <72621@debbugs.gnu.org>; Thu, 15 Aug 2024 13:12:58 +0200 (CEST) Message-ID: <434b0060-b39e-4704-861f-a8628ee1993c@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1723720378; bh=KQRYCxfoKfq/ciK3ZuHJMYqE6SkjR5wElUn4AiCxgtc=; h=Date:To:From:Subject; b=E3IDGBTANHTG8RxpvqpS7UvwxKhBYOW5hhnkd3zBjaG15kZtqg/Lqy9dOFveAtS11 JFzT6bKk288VwmYnaG+KNfEomJ6CnC2ROYMfJKlkqDiPWH9PFOOWW905yA+DR2amDA fC9Gb3+KCGoJ0F2pHGxRmu5T5UgOFD4Ul9jJXY5Zw2BoUlWYTiPEaYimEAddejur9z M0VZVzE6rG/G0FW0EpkvsrTz6xEZgUPW1kzWGquc5hZxT1n4BBf76uoiHr5+KPC9kt S1qlegnnhOmAvRlPvqBNWwDTHGzjo/0GXqyKfhNx6f+3WtNW615QP5n2hLOHNmNhYJ L2wQ/F2nAc9Rg== Date: Thu, 15 Aug 2024 14:12:58 +0300 MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 15 Aug 2024 08:24:56 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Aleksej X-ACL-Warn: , Aleksej via Guix-patches From: Aleksej via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 5B199103A9 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -6.96 X-Spam-Score: -6.96 X-TUID: ieV2Cp75IB5I Hi! I've applied your patch, and it seems to have some problems. 1) We already have the package with name "clasp", consider renaming it to something like "clasp-cl". 2) The license of clasp should be "lgpl2.1+", not "lgpl2.1". 3) After renaming run "guix lint" on the package, it has quite a lot of warnings. 4) I see you use gnu-build-system, and modify it a lot to use ninja. We have meson-build-system in GNU Guix, shouldn't it be used instead? Also I've looked at clasp git repo, they have package definition for GNU Guix, maybe you should check it out! -- Best regards, Lesik Edelweiss