From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id APiHL9M/UGSJlAAASxT56A (envelope-from ) for ; Tue, 02 May 2023 00:40:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aHB/L9M/UGRTIwEA9RJhRA (envelope-from ) for ; Tue, 02 May 2023 00:40:19 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 306BA2C4D1 for ; Tue, 2 May 2023 00:40:19 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptcBf-0001Ap-VT; Mon, 01 May 2023 18:40:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptcBe-0001Af-Bt for guix-patches@gnu.org; Mon, 01 May 2023 18:40:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptcBe-00089v-2Q for guix-patches@gnu.org; Mon, 01 May 2023 18:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptcBd-0000qf-Ma for guix-patches@gnu.org; Mon, 01 May 2023 18:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63117] [PATCH] gnu: yt-dlp: Change input. Resent-From: Dominik Delgado Steuter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 01 May 2023 22:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63117 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jack Hill Cc: 63117@debbugs.gnu.org Received: via spool by 63117-submit@debbugs.gnu.org id=B63117.16829807573196 (code B ref 63117); Mon, 01 May 2023 22:40:01 +0000 Received: (at 63117) by debbugs.gnu.org; 1 May 2023 22:39:17 +0000 Received: from localhost ([127.0.0.1]:41210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcAu-0000pT-TI for submit@debbugs.gnu.org; Mon, 01 May 2023 18:39:17 -0400 Received: from delgado.nrw ([217.160.67.216]:51416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptcAs-0000pD-FJ for 63117@debbugs.gnu.org; Mon, 01 May 2023 18:39:15 -0400 Message-ID: <42c9cb81-aeb2-6fd5-44be-ebe8e73c2682@delgado.nrw> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=delgado.nrw; s=mail; t=1682980748; bh=wKGQODQYRwEMyCKKicp4jX8MslFJkKjqOLiftlqugrk=; h=Date:Subject:To:References:From:Cc:In-Reply-To:From; b=VP5pfnc40EEGFG+ma5y+yI5sVnJUS4RSqUfrCd0oFtX6PkA9myDieuSxQa1VPEgKB uVOuvMzVPBs0pBEY0/ll9AYWnr8CeXhOm7utIm4q3cBNDh/QhP3dsKfVCFi+DIz0g6 PG4V0noRT65t8lBw9NNRC8FgBiWhv6Jo7KRnCbheJ5I+ou/dffZ9ponD7zgQgq57Hm xk1gqJfhIRdChKng9CXysJqn9BUfb4zKIt1iWFHZbQZ/TdYeyVLeJb6BZZSdLGoLYX zaLL+ag5QvHGMu09+y/Ur4ytUiaDqTJOOby1Ygf0d+BjsLvXeulR0o9wQD4jCC/i9x jvNJR9v852jSw== Date: Tue, 2 May 2023 00:39:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US References: <20230427143200.13000-1-d@delgado.nrw> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Dominik Delgado Steuter X-ACL-Warn: , Dominik Delgado Steuter via Guix-patches From: Dominik Delgado Steuter via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682980819; a=rsa-sha256; cv=none; b=YQAGeiipQH8m6XOzy4Qu7OtMnTtki899dIPQugfia5Z8JTBoxMpqA+hZ2f65yW3Zn6ve92 st39Qx37x8tQCzVxCfBg3lCYlURVjMKDglySRtcD37eI4+6ISzi1F9PecgT8lmtLPfrsDX RaERN2INH5dnwJJNXF3f9bb2O7VKsg1OwW8S1MlzhyYqorqPfd1lkGj5O2m+Q10BawaxcS RJVnzkHD8VF+yWq6ti8uxUMZYKseTGbOBOIkurRlX6k/jd0XPCXVUiYQ/eeuBVHdvJJGzH VCxQy75erw/hsa44+xH8EgOjx0Rne0QQYwMhuubGftjAx23SvZAmySnEkj/gmw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=delgado.nrw header.s=mail header.b=VP5pfnc4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682980819; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=ZBsmJQogngTaOxrcHComxnRDMbpIg5g+I1iVddDbQ6g=; b=RaIUrJGss6ecWfDmCyLS1RysLsXqc9NlB79SgMt4zsP09hiTPjGOIPg5rk7OTlLRlMrVVv f5+gkKHCYxeJGwaQGi6Zll23CDhhlA6ISVdjgrnGvva/WUz6j4yXl/a6F2eXMDSNqv+jeb 6VWzl43oUCRdE9Jz6hVXB6QRoLoDnDrETMUyH/JR1N7NYvpU+A6JKtUX0F8Rv5vTJtI0u0 x0lEflhLhFWJp6CUJpQ+uus12txgck7GQKc2JIAtASzfMoIOh7bVHh6jwAfuIiA3/Tgmc3 wGuDponMzcnRIzhBpd+ruLmsXvKxgq1OCGy+3+C43PNGYuZ3q4G4lPIRkKmzGw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=delgado.nrw header.s=mail header.b=VP5pfnc4; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.21 X-Spam-Score: -2.21 X-Migadu-Queue-Id: 306BA2C4D1 X-TUID: DNgPmrSjx4lU Hi Jack, thanks for reviewing my patch. You are probably right that yt-dlp only needs the path and not necessarily the propagated-input. I will try to figure out how exactly to do that and then send the updated patch. Regards, Dominik Am 29.04.23 um 06:36 schrieb Jack Hill: > On Thu, 27 Apr 2023, Dominik Delgado Steuter via Guix-patches via wrote: > >> yt-dlp complained when the "--add-metadata" flag was used. >> youtube-dl does not need ffmpeg as a propagated-input, though. > > Dominik, > > Thanks for working on improving our yt-dlp package. Can you explain a > little more about why yt-dlp needs ffmpeg to be propagated? I haven't > looked too closely, but I suspect yt-dlp just want to be able to call > ffmpeg at runtime. If that's true, then I think it would be better to > use substitute* in a phase so that yt-dlp can use the full path to > ffmpeg, and not clutter folks' profiles. > > If I'm correct, can you provide an updated patch that does that? I'm > happy to provide more guidance if you need it. > > If I'm wrong and ffmpeg needs to be propagated for some other reason, > can you add a comment in the code explaining the need? > > Best, > Jack