From: Luca Cirrottola <luca.cirrottola@inria.fr>
To: "Ludovic Courtès" <ludovic.courtes@inria.fr>
Cc: 72071@debbugs.gnu.org
Subject: [bug#72071] [PATCH 0/2] Fix hdf5-parallel-openmpi
Date: Thu, 25 Jul 2024 12:08:45 +0200 (CEST) [thread overview]
Message-ID: <415462361.19799395.1721902125892.JavaMail.zimbra@inria.fr> (raw)
In-Reply-To: <874j8ltlph.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 3014 bytes --]
Hello Ludo'!
Yes, after applying the first patch with the package version update, a failure appears in "test_check_version" (I attach the log for future reference). I don't know if this happens now because of an update in the HDF5 package, or because the old version failed before reaching this test.
Anyway, this test compares two versions of a file generated according to the template in src/libhdf5.settings.in, the first one generated in the "configure" phase, the second one in the "check" phase. Since the "patch-settings" phase modifies the first file, the test fails.
Thanks for the explanations for the "patch-settings" phase! I will come back in the next message with a replacement for the second patch which hopefully does not break the expected behaviour.
Thanks,
Luca
----- Mail original -----
> De: "Ludovic Courtès" <ludovic.courtes@inria.fr>
> À: "Luca Cirrottola" <luca.cirrottola@inria.fr>
> Cc: 72071@debbugs.gnu.org
> Envoyé: Vendredi 19 Juillet 2024 18:01:30
> Objet: Re: [bug#72071] [PATCH 0/2] Fix hdf5-parallel-openmpi
> Hello Luca!
>
> Luca Cirrottola <luca.cirrottola@inria.fr> skribis:
>
>> Package hdf5-parallel-openmpi builds often fail with the error reported in
>> https://issues.guix.gnu.org/68313 . The issue has been discussed in
>> https://github.com/open-mpi/ompi/issues/11240 and
>> https://github.com/HDFGroup/hdf5/issues/2196, and solved by
>> https://github.com/HDFGroup/hdf5/pull/3421 that is included in HDF5 release
>> 1.14.3. My proposed solution consists of two commits, the first for updating
>> the HDF5 version in hdf5-parallel-openmpi to 1.14.3, the second for fixing a
>> new test error due to the recipe modifying a file which is used as a test
>> reference (my proposition is to remove this modification, but I don't know why
>> it was introduced in the first place, so thanks for any comment about this).
>>
>> Luca Cirrottola (2):
>> Solve issue https://issues.guix.gnu.org/68313 by updating HDF5 version
>> to 1.14.3 (containing the official fix
>> https://github.com/HDFGroup/hdf5/pull/3421).
>
> This first patch LGTM.
>
> Do I get it right that there’s one test failure if we apply just this
> one patch?
>
>> Fix broken HDF5 test: Do not modify the file src/libhdf5.settings
>> generated by the configure script, as it will be checked against a
>> new version generated by the test code in
>> test/test_check_version.sh.in.
>
> Here, the ‘patch-settings’ phase was here (1) to ensure bit-for-bit
> reproducible builds regardless of the kernel (the “Uname” change), and
> (2) to avoid keeping references to the compiler (hdf5 would depend on
> GCC & co., so its closure as reported by ‘guix size hdf5’ would be much
> bigger than necessary).
>
> I haven’t looked at ‘test_check_version.sh.in’, but can you think of a
> way to preserve the changes ‘patch-settings’ makes while still allowing
> that test to pass?
>
> Thanks,
> Ludo’.
[-- Attachment #2: ypb72f7f2xc13a3sjb5jwg45gsjw1g-hdf5-parallel-openmpi-1.14.3.drv.gz --]
[-- Type: application/gzip, Size: 75819 bytes --]
next prev parent reply other threads:[~2024-07-25 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 9:40 [bug#72071] [PATCH 0/2] Fix hdf5-parallel-openmpi Luca Cirrottola
2024-07-12 9:48 ` [bug#72071] [PATCH 1/2] Solve issue https://issues.guix.gnu.org/68313 by updating HDF5 version to 1.14.3 (containing the official fix https://github.com/HDFGroup/hdf5/pull/3421) Luca Cirrottola
2024-07-12 9:49 ` [bug#72071] [PATCH 2/2] Fix broken HDF5 test: Do not modify the file src/libhdf5.settings generated by the configure script, as it will be checked against a new version generated by the test code in test/test_check_version.sh.in Luca Cirrottola
2024-07-19 16:01 ` [bug#72071] [PATCH 0/2] Fix hdf5-parallel-openmpi Ludovic Courtès
2024-07-25 10:08 ` Luca Cirrottola [this message]
2024-07-25 12:49 ` [bug#72071] [PATCH 0/1] Split the patch-settings phase into copy-settings, patch-settings-for-build, restore-settings-for-check, patch-settings-for-install Luca Cirrottola
2024-07-25 12:49 ` [bug#72071] [PATCH 1/1] Backup original settings, so they can be restored before the check phase and patched again before the install phase (since the install-data target depends on this file) Luca Cirrottola
2024-07-29 17:36 ` [bug#72071] [PATCH 0/2] A clean series of patches Luca Cirrottola
2024-07-29 17:36 ` [bug#72071] [PATCH 1/2] Solve issue https://issues.guix.gnu.org/68313 by updating HDF5 version to 1.14.3 (containing the official fix https://github.com/HDFGroup/hdf5/pull/3421) Luca Cirrottola
2024-07-29 17:36 ` [bug#72071] [PATCH 2/2] Skip test_check_version since the patch-settings phase needs to modify the test reference file Luca Cirrottola
2024-08-19 10:37 ` bug#72071: [PATCH 0/2] A clean series of patches Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415462361.19799395.1721902125892.JavaMail.zimbra@inria.fr \
--to=luca.cirrottola@inria.fr \
--cc=72071@debbugs.gnu.org \
--cc=ludovic.courtes@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.