From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id dhGfDklRwWHIZQAAgWs5BA (envelope-from ) for ; Tue, 21 Dec 2021 05:00:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iHmzCUlRwWEmYQAAB5/wlQ (envelope-from ) for ; Tue, 21 Dec 2021 04:00:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CFFC228195 for ; Tue, 21 Dec 2021 05:00:08 +0100 (CET) Received: from localhost ([::1]:48520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzWJr-0003HI-Nh for larch@yhetil.org; Mon, 20 Dec 2021 23:00:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzWJm-0003Gq-Q5 for guix-patches@gnu.org; Mon, 20 Dec 2021 23:00:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:40395) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzWJm-0007Fg-H1 for guix-patches@gnu.org; Mon, 20 Dec 2021 23:00:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzWJm-0000CB-Fv for guix-patches@gnu.org; Mon, 20 Dec 2021 23:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 07/45] guix: node-build-system: Add #:absent-dependencies argument. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Dec 2021 04:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Timothy Sample Cc: 51838@debbugs.gnu.org, Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.1640059158660 (code B ref 51838); Tue, 21 Dec 2021 04:00:02 +0000 Received: (at 51838) by debbugs.gnu.org; 21 Dec 2021 03:59:18 +0000 Received: from localhost ([127.0.0.1]:51941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzWJ3-0000AY-MV for submit@debbugs.gnu.org; Mon, 20 Dec 2021 22:59:18 -0500 Received: from mail-ua1-f54.google.com ([209.85.222.54]:34385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzWIx-0000AC-TK for 51838@debbugs.gnu.org; Mon, 20 Dec 2021 22:59:16 -0500 Received: by mail-ua1-f54.google.com with SMTP id u40so21418451uad.1 for <51838@debbugs.gnu.org>; Mon, 20 Dec 2021 19:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=H22DkQBFuif+G224bYg3YF+FPhBgkBklDE+ECeOkVEM=; b=R4+Xsz1lyCblJOVPpcx2bU0ij+fWGql7jF4CkLlfhMGk9/RG4xlQliPZd0gvwf0F40 8S1x/dx31FXrnUYNkpCpna3H8NPyZM5MeFUKHzlB0mkM3ZmmnVA3/5e046O8YwVH3qBP TypkBfmC8kRYKbbP9sMRLy0eDndmJYLYp1P0ZXOEZJ4im9PJchff0/h4IGBJg0IocOdO FGH6AVQPYxwCRkmQ2XlTw9TMWEWOSpPL4L2PYbu/D7uFkAhe8q0Rq0w6ecaeAmqdleWr 2lQvFZEBwsTF3NgHVCHU2cPGMNuhhvq87DHflReV31WPJHHqGga0fuaGwaHZFDSwA4M9 Nanw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=H22DkQBFuif+G224bYg3YF+FPhBgkBklDE+ECeOkVEM=; b=gWxYplohQngzbmEwICzxWRk6oQCHSITM40OWUoTo4O9q/Hc8zkTp7sCDgqL9v7Lgoe Q59RLowgs1JUKT6ExkF+TwZPx8fNV7ELUWbJkeudxkF194s9l3/Bs2N4IIt6PgVUuS/s r+AaZypgW2nbVU2rnM7JsJTH2V0VFIP9zyOUuSVgNXgRU3VFDqCiz/a0lwu7PE094m8W QvmjPVyVlJnJdiy01jbRMIZhxJ8UuJJMJHH7VCtCDUVYzS5Y8oF09KXdchc/HGB/8Ocn 8kzE14RVxygAy6k3IhmIysEp8SShMjjTIrIiF6bgjLxhIFu13ow8p8COHLV1QT6qHg4o fSLA== X-Gm-Message-State: AOAM531Ym+ejxc3cNRl8xNFcHJuuTETIIdalbBsVezxtdq+9fsgiDS+A D5ilAJ5/kcKaGks3gOA9MmX2CA== X-Google-Smtp-Source: ABdhPJzvBPNj+ScoGcn5yzo46gxAH46nSpW96jCpiao/8QZ+MP0WyQXQB4bR2j0+va0LLyW+cvYfow== X-Received: by 2002:a05:6102:3a0c:: with SMTP id b12mr462198vsu.48.1640059146219; Mon, 20 Dec 2021 19:59:06 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id m25sm441027vsl.34.2021.12.20.19.59.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Dec 2021 19:59:06 -0800 (PST) Message-ID: <41461d4f-5e7d-d9be-51c4-7a58c4f7570f@philipmcgrath.com> Date: Mon, 20 Dec 2021 22:59:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-8-philip@philipmcgrath.com> <87k0g36xp3.fsf@ngyro.com> <871r2a7hme.fsf@ngyro.com> <815f327e36ecd24066179586997947ecd8f31150.camel@gmail.com> <33696592-8a3a-8260-bf27-652cf78727a6@philipmcgrath.com> <2c803ea8f5c5c16c892f5528f63a4c7e98470c5b.camel@gmail.com> <314a0ea4-a851-6642-0a59-d4c61d65c242@philipmcgrath.com> <35164d79ab6ae1c0595d27f023376cf98ab1a39d.camel@gmail.com> <9533cfc8-b822-edc0-67ac-7e2c9aeacb09@philipmcgrath.com> <87r1a7118r.fsf@ngyro.com> From: Philip McGrath In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640059208; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=H22DkQBFuif+G224bYg3YF+FPhBgkBklDE+ECeOkVEM=; b=av6WHooSkDcYe0mv21YJ2OkAbUPYzG3Yrv1GYBgfQdSzMUshCMEhVvp5XolLRjn6SNOjX1 tBds9lrD3I2pLjlxL93wdl5GR22WZy3TP+WiYdxw8YGcBgEPjmV4FPhBwYQE0urPsgKeXp NT4RO+m+7IzoeRNhp8K6LNFYLnfnzFs6Evk2TtCZz0WtyYyEbMiAPWRL6P4psZd1xEIkvK l0h0p36S96p2kH3RwR6QbnMLYL2k8wkvyhMjYkzt71/6rlb00Rd5vdf+jk2jpYjm4GawEx oUBaanYtUYrzx8guVa4NODIe4vbGuWWMLFBihh5B1gqx0LICWTiodit/gImlGg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640059208; a=rsa-sha256; cv=none; b=dHlgtV87rNOACMovZFi81v0BDKROn40BHj3Mg4J03c6tDAT9QHVAuf1qx2LgzpZtLxlaHi ApLtaeYzVA4BJNDdTwxYJe8R9ihGrSNKC8dSFpyuiPiLP5rfarUWrRzjkFVcIn9NgmDSJS ppfLi4jE5GqKgBau5QGLbck7JoLLMqgHKpV+xaS1UN+t0oScEr7GDWYA2lUkK4kLi5aIWR Nzqied1uBUUNWi+QNV8pZVhcvhkLekih/rI4PJPnG/7OK7W2PFf4tPY+6CAqiQ4MFY0Qrt DNLDQZLI5/zgWD0/Er1CKgPE1aHrLEt26ncXWkNl76AxylaJ+njpCUWtRwltmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=R4+Xsz1l; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.82 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=R4+Xsz1l; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CFFC228195 X-Spam-Score: -0.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: o3Fq6es6Naux Hi all, On 12/20/21 17:00, Liliana Marie Prikler wrote: > Hi Timothy, > > Am Montag, dem 20.12.2021 um 15:15 -0500 schrieb Timothy Sample: >> Hi Philip, >> >> Philip McGrath writes: >> >>> If we took your final suggestion above, I think we'd have something >>> like this: >>> >>> ``` >>> #:phases >>> (modify-phases %standard-phases >>>   (add-after 'unpack 'delete-dependencies >>>     (make-delete-dependencies-phase '("node-tap")))) >>> ``` >> >> I’m perfectly happy with this if it’s a compromise we all can agree on. >> It is exactly what popped into my imagination when I read Liliana’s >> suggestion.  I guess the one thing missing is that it would not >> necessarily be implemented on top of better “package.json” >> manipulation support.  That said, it doesn’t preclude providing that >> support if/when the need arises. > In my personal opinion, we would write that support first and perhaps > the shorthands later. I could live with the above as a compromise. My reservation regarding: > > (add-after 'patch-dependencies 'drop-junk > (lambda _ > (with-atomic-json-replacement "package.json" > (lambda (json) (delete-dependencies json '("node-tap")))))) > is that `with-atomic-json-replacement` would make (guix build json)'s representation a part of node-build-system's API, which it currently is not. For the reasons I detailed in my last email, I think that would open up a larger can of worms than it might seem. Liliana, I'm not entirely certain, but my impression from: >> I’m probably not “someone else” enough at this point, but I guess we >> can ask the maintainers to weigh in/help facilitate.  We try to move >> forward by consensus, and maybe replacing the keyword with a phase- >> making procedure will get us there.  Liliana, what do you say?  Have >> we found an approach we can agree on?  If not, I think that we’re >> probably stuck and will need some fresh voices to move forward. > I personally think phase making is out of scope and we need a solid > foundation first. That said, if Philip does provide both that > foundation and a good reason to have a phase-making procedure, I'm > willing to strike a compromise. was that you would still have objections to something like: >>> ``` >>> #:phases >>> (modify-phases %standard-phases >>> (add-after 'unpack 'delete-dependencies >>> (make-delete-dependencies-phase '("node-tap")))) >>> ``` unless it came together with code like `with-atomic-json-replacement` for more general "package.json" transformations. If that's the case, then I guess we should do as Jelle suggests: On 12/20/21 18:10, Jelle Licht wrote: > I believe the best thing to do would be to push the earlier > uncontroversial node patches. > > Perhaps we can get some of the gurus/victims of other build systems > involved on guix-devel as none of the fundamental issues you've been > talking about for a while are node-specific. As long as we want to reach > some kind on consensus, I believe writing/reviewing more code does not > get us to a desirable outcome at this time. > > - Jelle > -Philip