* [bug#71950] [PATCH] services: web: Return success from nginx-action.
@ 2024-07-05 15:01 Tomas Volf
2024-07-10 14:06 ` bug#71950: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Tomas Volf @ 2024-07-05 15:01 UTC (permalink / raw)
To: 71950; +Cc: Tomas Volf
Previous value of #f lead to `head reload nginx' returning exit code 1,
complicating usage from scripts (and other actions). Returning #t fixes that.
Any actual failures are still covered by the invoke call above.
* gnu/services/web.scm (nginx-shepherd-service)[nginx-action]<-s>: Return #t.
Change-Id: I4ce1645798a85baddeb0f5bd702a2567db3c7aaa
---
gnu/services/web.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index b73cd30fe7..af4d6de658 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -831,7 +831,7 @@ (define (nginx-shepherd-service config)
#~(lambda _
(invoke #$nginx-binary "-c" #$config-file #$@args)
(match '#$args
- (("-s" . _) #f)
+ (("-s" . _) #t)
(_
;; When FILE is true, we cannot be sure that PID-FILE will
;; be created, so assume it won't show up. When FILE is
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#71950: [PATCH] services: web: Return success from nginx-action.
2024-07-05 15:01 [bug#71950] [PATCH] services: web: Return success from nginx-action Tomas Volf
@ 2024-07-10 14:06 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2024-07-10 14:06 UTC (permalink / raw)
To: Tomas Volf; +Cc: 71950-done
Tomas Volf <~@wolfsden.cz> skribis:
> Previous value of #f lead to `head reload nginx' returning exit code 1,
> complicating usage from scripts (and other actions). Returning #t fixes that.
> Any actual failures are still covered by the invoke call above.
>
> * gnu/services/web.scm (nginx-shepherd-service)[nginx-action]<-s>: Return #t.
>
> Change-Id: I4ce1645798a85baddeb0f5bd702a2567db3c7aaa
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-10 14:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-05 15:01 [bug#71950] [PATCH] services: web: Return success from nginx-action Tomas Volf
2024-07-10 14:06 ` bug#71950: " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.