From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kP4FL9ELrWAA/wAAgWs5BA (envelope-from ) for ; Tue, 25 May 2021 16:38:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WHe/KtELrWCrLAAA1q6Kng (envelope-from ) for ; Tue, 25 May 2021 14:38:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6C22815E1B for ; Tue, 25 May 2021 16:38:09 +0200 (CEST) Received: from localhost ([::1]:35916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llYC8-0006tI-Fu for larch@yhetil.org; Tue, 25 May 2021 10:38:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llYC2-0006kp-85 for guix-patches@gnu.org; Tue, 25 May 2021 10:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34978) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llYC1-0005JK-Vx for guix-patches@gnu.org; Tue, 25 May 2021 10:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llYC1-0000He-SM for guix-patches@gnu.org; Tue, 25 May 2021 10:38:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48637] [PATCH] website: Add publications page Resent-From: Luis Felipe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 25 May 2021 14:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48637 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "pelzflorian (Florian Pelz)" Cc: "48637@debbugs.gnu.org" <48637@debbugs.gnu.org> Received: via spool by 48637-submit@debbugs.gnu.org id=B48637.16219534341033 (code B ref 48637); Tue, 25 May 2021 14:38:01 +0000 Received: (at 48637) by debbugs.gnu.org; 25 May 2021 14:37:14 +0000 Received: from localhost ([127.0.0.1]:46524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llYBG-0000Gb-8q for submit@debbugs.gnu.org; Tue, 25 May 2021 10:37:14 -0400 Received: from mail-40135.protonmail.ch ([185.70.40.135]:35442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llYBD-0000GM-Q1 for 48637@debbugs.gnu.org; Tue, 25 May 2021 10:37:13 -0400 Date: Tue, 25 May 2021 14:37:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1621953425; bh=gL42iMwD3LMPXWcHoNwbb8LNKEjk9mkCwyHNWObewhQ=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=SFBATKgufOS2a2W1ryNXqMu+MsOFYV/MZZVr4ZzZa+eZwhFXwvFE1+Hx/XOLEJN30 1Ta0bSxvmMVWPYcNk3cWu3vkmeR3dO7UY8kglIEAidjo6BEJHWwfGVDwlQaerfD2N7 e4+4kjT2Tc+X4aaaNED4747Zn1dRW2s9QH4axKzM= Message-ID: <3mZyc8pra0TLSyJS6RlWIrQGBnje7dT_EMRBeOdFC_Z2wsZGoaI1rVNVtoiI57KEOvolEiahl6j7M4UBsoO0NsuieAfDPIkZQ-MR8C5UhAE=@protonmail.com> In-Reply-To: <20210525134405.hmevensj5m42iluo@pelzflorian.localdomain> References: <4BtcqLwBY7LgeYhUd41lhUUAcT5n2Zn9OTJUzGswTuBpLla8nBHyrQ3kJzwEMI9E7MPEnr6wBqSeCMqByldZ6i5jPR8B7ZtEi0XhwextyQo=@protonmail.com> <20210525134405.hmevensj5m42iluo@pelzflorian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Luis Felipe X-ACL-Warn: , Luis Felipe via Guix-patches From: Luis Felipe via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621953489; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gL42iMwD3LMPXWcHoNwbb8LNKEjk9mkCwyHNWObewhQ=; b=mM249D7u3fIZS6dETh0TKbhPfdDP2jihHfZCvTvbJqPVeS9+45ccyzXh2EKmUR3wTmucnQ o4RhAl9QAaLQRLFuWcXNJ28hXkbN4sMuVRLkzmLw0B0134GsTl0NrwMPNLAWCgo2tdf8ic 6hwhjdaVfgxCP7cq7z29VA/n8ymcjDOpl6cwbVcrgqWE9C0NB146yUi+uCxkWcUo0CfeCp wY/U3xYn+19cBVANpaiRlwf8Oe8qaWSPL7Qqks5LIS7YQNN4nfC45M7Yc6jK90ZQRBsuaf 3lPbM6V8aNxuHt6yYUPEsMr4N3QY1ry3LWqEC8dSbWeadaM4lPoWJK2pvBSUvg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621953489; a=rsa-sha256; cv=none; b=TqY/OAFzBZMfY1bww8faSIH1/eJK7sbaAX6F1jVQ37abh8V0xU+9VXFLgRjoufut6f0fFz Lc/sPYZGt8g6xLCTY7MvRCIEEQYaiJpF+ZiSIg7UvgK2BQnIXXlU6goVxBYaNivfNq31sF VYNgNLJV58gtZeEpU7nFJJYAlk5gnqIDicfNHzscX6rCukuMjPGG2pCGvJoMUkRnwidAPp gSdoqBGKPEJRujQvp6cOOwnb4sMOefU+Yy2CgucEpVzblPNNV38pBgFipG+rwpqhFEd78U O9T4NJ05LJLL98Gvlq86t9/dRR1GcC2R3f+VpSM/g4952RJyNcn3WcpybpAxdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=SFBATKgu; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.43 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail header.b=SFBATKgu; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6C22815E1B X-Spam-Score: -1.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: +ulIhK/keTYO =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Tuesday, May 25, 2021 1:44 PM, pelzflorian (Florian Pelz) wrote: > On Mon, May 24, 2021 at 11:35:24PM +0000, Luis Felipe via Guix-patches vi= a wrote: > > > Hi, > > This patch adds a new Publications page to the website. > > Nice! > > I could not test yet, but maybe make the date string in > > > +(define (publication->shtml publication) > > > > - "Return an SHTML representation of the given publication object. > > - > > - PUBLICATION () > > - A publication object as defined in (apps media types)." > > > > > > - `(a > > - (@ (class "publication-preview") > > - (href ,(publication-url publication))) > > > > > > - > > - (h3 > > - (@ (lang ,(publication-language publication)) > > > > > > - (class "publication-title")) > > > > > > - ,(publication-title publication)) > > > > > > - > > - (p > > - (@ (class "publication-info")) > > > > > > - ,(G_ `("Published " > > > > > > - ,(date->string (publication-date publication) "~b ~d, ~Y= ") > > > > > > translatable like website/apps/blog/templates/components.scm line 33. Yeah. Would it as follows? (I still struggle with i18n): (p (@ (class "publication-info")) ,(G_ `("Published " ,(date->string (publication-date publication) (C_ "SRFI-19 date->string format" "~b ~d, ~Y")) " by " ,(string-join (publication-authors publication) ", ")))) Also, I think the delimiter for "string-join" in the list of authors should= be translated because that comma is not used in Japanese, for example. So = would it be ok like this: (p (@ (class "publication-info")) ,(G_ `("Published " ,(date->string (publication-date publication) (C_ "SRFI-19 date->string format" "~b ~d, ~Y")) " by " ,(string-join (publication-authors publication) (C_ "Separator of items in a list" ", "))))) I'm still unsure about when I should use a context and when a TRANSLATORS c= omment... > > +(define (publication-list-t publications) > > > > - "Return the Publication list page in SHTML. > > - > > - PUBLICATIONS (list of ) > > - See the (apps media types) module for information on the > > > > > > - type." > > > > > > - (theme > > - #:title (C_ "webpage title" '("Publications")) > > - #:description > > - (G_ "A list of written publications about GNU Guix.") > > - #:keywords > > - ;; TRANSLATORS: |-separated list of webpage keywords. > > - (string-split (G_ "Publications|Papers") #\|) > > I don=E2=80=99t know, but should there really be only none of the other p= ages=E2=80=99 > SEO keywords? All other occurrences of #:keywords begin with > > GNU|Linux|Unix|Free software Hmm, I don't know... Last time I checked, I think I saw that search engines= care more about the page content than meta keywords. So I don't think it w= ould make a difference. Also, if it turns out to be important to repeat these keywords in all pages= , maybe it would be better to add these by default in (apps base templates = theme).