From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasile Dumitrascu Subject: Re: [PATCH] gnu: Add emacs-aggresive-indent-mode. Date: Fri, 24 Mar 2017 02:56:00 +0000 Message-ID: <3ee44466-76bc-68b6-611e-40192214331a@yahoo.com> References: <39ee52d0-582a-77a3-39c0-b59b53b6048b@yahoo.com> <871stn6evg.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crFP0-0002d6-N8 for guix-devel@gnu.org; Thu, 23 Mar 2017 22:56:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crFOx-0002ll-IQ for guix-devel@gnu.org; Thu, 23 Mar 2017 22:56:34 -0400 Received: from nm24-vm9.bullet.mail.ir2.yahoo.com ([212.82.97.33]:44626) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1crFOx-0002kn-1y for guix-devel@gnu.org; Thu, 23 Mar 2017 22:56:31 -0400 In-Reply-To: <871stn6evg.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke , guix-devel@gnu.org Hi You are correct. I have recreated the patch as I have trashed the old repo clone, please find below the new version. Thank you, Vasile * gnu/packages/emacs.scm (emacs-aggressive-indent): New variable. --- gnu/packages/emacs.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index b84faaff0..33a919458 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -20,6 +20,7 @@ ;;; Copyright © 2017 Christopher Baines ;;; Copyright © 2017 Mathieu Othacehe ;;; Copyright © 2017 Clément Lassieur +;;; Copyright © 2017 Vasile Dumitrascu ;;; ;;; This file is part of GNU Guix. ;;; @@ -1080,6 +1081,26 @@ like. It can be linked with various Emacs mail clients (Message and Mail mode, Rmail, Gnus, MH-E, and VM). BBDB is fully customizable.") (license license:gpl3+))) +(define-public emacs-aggressive-indent + (package + (name "emacs-aggressive-indent") + (version "1.8.3") + (source (origin + (method url-fetch) + (uri (string-append "https://elpa.gnu.org/packages/" + "aggressive-indent-" version ".el")) + (sha256 + (base32 + "0jnzccl50x0wapprgwxinp99pwwa6j43q6msn4gv437j7swy8wnj")))) + (build-system emacs-build-system) + (home-page "https://elpa.gnu.org/packages/aggressive-indent.html") + (synopsis "Minor mode to aggressively keep your code always indented") + (description + "@code{aggressive-indent-mode} is a minor mode that keeps your code +always indented. It reindents after every change, making it more reliable +than @code{electric-indent-mode}.") + (license license:gpl2+))) + (define-public emacs-ag (package (name "emacs-ag") -- 2.11.0 Marius Bakke: > Vasile Dumitrascu writes: > >> * gnu/packages/emacs.scm (emacs-aggresive-indent-mode): New variable. > > Thanks! > >> --- >> gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm >> index 547c44033..301552839 100644 >> --- a/gnu/packages/emacs.scm >> +++ b/gnu/packages/emacs.scm >> @@ -1066,6 +1066,31 @@ like. It can be linked with various Emacs mail >> clients (Message and Mail >> mode, Rmail, Gnus, MH-E, and VM). BBDB is fully customizable.") >> (license license:gpl3+))) >> >> +(package > > Hmm. This should be enclosed in a 'define-public' block. > >> + (name "emacs-aggresive-indent-mode") > ^^^ > > There should be an extra 's' here. Also '-mode' can be dropped. > > >> + (version "1.8.3") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "https://elpa.gnu.org/packages/" >> + "aggressive-indent-" version ".el")) >> + (sha256 >> + (base32 >> + "0jnzccl50x0wapprgwxinp99pwwa6j43q6msn4gv437j7swy8wnj")))) >> + (build-system emacs-build-system) >> + (home-page "https://elpa.gnu.org/packages/aggressive-indent.html") >> + (synopsis "Minor mode to aggressively keep your code always indented") >> + (description >> + "`electric-indent-mode' is enough to keep your code nicely aligned when >> +all you do is type. However, once you start shifting blocks around, >> +transposing lines, or slurping and barfing sexps, indentation is bound >> +to go wrong. >> + >> +`aggressive-indent-mode' is a minor mode that keeps your code always >> +indented. It reindents after every change, making it more reliable >> +than `electric-indent-mode'.") > > The quotes in the description should be replaced with @code{} blocks. > Running `./pre-inst-env guix lint emacs-aggressive-indent` should warn > about this. I also think that the second paragraph is sufficient. > > Can you send an updated patch? Please also add a copyright line for > yourself at the top of the file. > > TIA! > > >> + (license gpl2+)) >> + >> (define-public emacs-async >> (package >> (name "emacs-async") >> -- >> 2.11.0