From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GJOcCLp29GA0fwEAgWs5BA (envelope-from ) for ; Sun, 18 Jul 2021 20:45:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KEdfBLp29GDCFAAAB5/wlQ (envelope-from ) for ; Sun, 18 Jul 2021 18:45:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C95A27B8B for ; Sun, 18 Jul 2021 20:45:13 +0200 (CEST) Received: from localhost ([::1]:58528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5Bmq-0005nl-Sc for larch@yhetil.org; Sun, 18 Jul 2021 14:45:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5Bmg-0005eW-A4 for guix-patches@gnu.org; Sun, 18 Jul 2021 14:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45714) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5Bmg-0003nU-2N for guix-patches@gnu.org; Sun, 18 Jul 2021 14:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5Bmg-00037P-1Q for guix-patches@gnu.org; Sun, 18 Jul 2021 14:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49547] [PATCH v2 2/4] home-services: Add home-run-on-change-service-type Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 18 Jul 2021 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49547 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Andrew Tropin , 49547@debbugs.gnu.org Received: via spool by 49547-submit@debbugs.gnu.org id=B49547.162663384811853 (code B ref 49547); Sun, 18 Jul 2021 18:45:01 +0000 Received: (at 49547) by debbugs.gnu.org; 18 Jul 2021 18:44:08 +0000 Received: from localhost ([127.0.0.1]:57255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5Blo-000357-5x for submit@debbugs.gnu.org; Sun, 18 Jul 2021 14:44:08 -0400 Received: from newton.telenet-ops.be ([195.130.132.45]:32858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5Blm-00034z-Mv for 49547@debbugs.gnu.org; Sun, 18 Jul 2021 14:44:07 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by newton.telenet-ops.be (Postfix) with ESMTPS id 4GSVW14LwSzMqqJm for <49547@debbugs.gnu.org>; Sun, 18 Jul 2021 18:17:33 +0200 (CEST) Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id WgHX250070mfAB406gHXYc; Sun, 18 Jul 2021 18:17:32 +0200 Message-ID: <3e972a6c839a48edf7fecb88a3ad4fd9bc0dfcee.camel@telenet.be> From: Maxime Devos Date: Sun, 18 Jul 2021 18:17:31 +0200 In-Reply-To: <87fswg2cd0.fsf@trop.in> References: <875yxem679.fsf@trop.in> <87fswg2cd0.fsf@trop.in> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-viPv9Fv7hxpLtIqaG2vR" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1626625052; bh=DQmmJqOz0YcQP9cllhbOxyZ1EeB0KEc9y3nkK5SjUaQ=; h=Subject:From:To:Date:In-Reply-To:References; b=BEVb5M7KOysfWtV45sBa839SFT173zr0QSXVyImEf88m9BuFTFS5qq9Hc5Z5UlrR4 Z8eDWwtPw30kH5E/cXsfV9r9RU3Hd9MV4w7IyQodRpUAMNwWddGTd0vmbPnfFkBZh5 LhnUORk8daOGav/wV3GB7zeUQAJFF5O9rvxNPY+nb/xZoq6IOS43GbUN1FANlmAPxs 3WtPcw1ToGHKsJK98MQWMfBxZKajLh37uPhrVZMU8jQW1qQdkMblhzJHUciG5Kzfci MT5elbLh/GIDdLJbqIWmogs3ud3Tea5Rdf3n0eXMQX1FFPNWsab5Bpo/0yQrPyTFLw N3VtL5qB9Bcaw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1626633913; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=DQmmJqOz0YcQP9cllhbOxyZ1EeB0KEc9y3nkK5SjUaQ=; b=qrD6eI9rHPahW08yD7HAdKEN4YZwa8Je6xsm2hz/FVSqg3qzx0eWJbAuDI35OELf1fctSq 0cgy2n4/X93ijo8if6kP5hvRREKTVAyC674B81Dm35z8P1co8RVxtApLbENPtCNF4qrzi+ DPemrLMBGhlatSAtiJbIzBNra5/hwYUVW9Sq9ud+NZ8j1JzPDzq+Ad8WfEcWzaQCkxLpLS C3f+rs1oCAuHTCXw3xXCHXX2UcFhJUmGNfNJRxKBIoEtaKhYwWkyJ83Nf2qZa7fxCh/0p3 272xUhci7yGIQ3ZKTzpnhnSs+8zA8sHg0ikn+4Q9rXb9tPxQ5ggNaV5UZwzBgw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1626633913; a=rsa-sha256; cv=none; b=uRr/hVcGqHMwc4cq4d5WxevE6MaPEyVXdu90+fMLcaZdfBdCYHeBl3xtP0W3rgZph3aA2V pI0NvbomiU539tlBDq/NfMYBKnXv5shoHFyoCzN7vpeblMrTPJuQz2k/GklgUq0wamoMGe Gb3CzHw38YNrLZKM6QTO8rg1x4B9EmxnourPd0gV8jB8KzxBzqeRX00jjJ7PQDlMQl3zXP n6RZQrW4mt/QIDScVTYCnGps8ABtCullmELDs3EG+PuZh+wHPgcmdF/W1wc3eHsauDpPDx iKlNHj6Hth0vx9ALb0am6wdW6dhi0f/oNMgHUl3iMy6Or1fpddw3EEcDx/6a9Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=BEVb5M7K; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=BEVb5M7K; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: C95A27B8B X-Spam-Score: -3.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3o9EJnXY77um --=-viPv9Fv7hxpLtIqaG2vR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Andrew Tropin schreef op do 15-07-2021 om 11:46 [+0300]: > No specific reason. Yep, spawning a new process can be expensive, but > it's not clear how much time will take the comparison itself and if it > worth it to optimize "startup time". I'm not very fluent with guile > internals and not sure if reimplementation of cmp in guile would improve > or worsen the performance, but it obviously could intoduce some bugs. I > found Xinglu's idea of the usage of well-tested cmp to be a reasonable > solution here. Sounds reasonable to me. > Also, this service is expected to be used with small amount of files and > because many of them are symlinks to the store even smaller number of > them will trigger the execution of cmp, so I find the performance > optimization to be preliminary here and propose to address the issue > when and if it appear someday. >=20 > However, the ideas about size and inodes are good, easy to implement and > I find them potentially useful to prevent unecessary external process > spawning. The patch with those improvements are below: [...] Greetings, Maxime. --=-viPv9Fv7hxpLtIqaG2vR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYPRUGxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7hIgAPsExp+jqfgfoKVMHgODzJREQOdI yT8ZpvE3XC/p2J51bwEA0Hj3KBHI2TnyUq0uZUkpRrsGFKF9tB/9gdb4IjCF5gA= =sLoh -----END PGP SIGNATURE----- --=-viPv9Fv7hxpLtIqaG2vR--