From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uB2cJDXRK2JbLQAAgWs5BA (envelope-from ) for ; Fri, 11 Mar 2022 23:46:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 6OpMITXRK2JxcwEAauVa8A (envelope-from ) for ; Fri, 11 Mar 2022 23:46:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3FA2533EB0 for ; Fri, 11 Mar 2022 23:46:13 +0100 (CET) Received: from localhost ([::1]:55670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nSo1T-00030E-9S for larch@yhetil.org; Fri, 11 Mar 2022 17:46:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nSo1K-0002xX-1V for guix-patches@gnu.org; Fri, 11 Mar 2022 17:46:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44754) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nSo1J-0004Dq-Of for guix-patches@gnu.org; Fri, 11 Mar 2022 17:46:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nSo1J-00084p-MT for guix-patches@gnu.org; Fri, 11 Mar 2022 17:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#54304] [PATCH] Don't fix git executable location during Elixir build Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Mar 2022 22:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Cees de Groot , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 54304@debbugs.gnu.org, Tobias Geerinckx-Rice Received: via spool by 54304-submit@debbugs.gnu.org id=B54304.164703875831036 (code B ref 54304); Fri, 11 Mar 2022 22:46:01 +0000 Received: (at 54304) by debbugs.gnu.org; 11 Mar 2022 22:45:58 +0000 Received: from localhost ([127.0.0.1]:38651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSo1F-00084V-SA for submit@debbugs.gnu.org; Fri, 11 Mar 2022 17:45:58 -0500 Received: from laurent.telenet-ops.be ([195.130.137.89]:33540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nSo1E-00084N-6x for 54304@debbugs.gnu.org; Fri, 11 Mar 2022 17:45:56 -0500 Received: from [172.20.10.5] ([188.188.45.72]) by laurent.telenet-ops.be with bizsmtp id 5Alt2700K1ZSGwU01Aluit; Fri, 11 Mar 2022 23:45:54 +0100 Message-ID: <3df7ef98867c4077efc34a335b193a6fda333cb2.camel@telenet.be> From: Maxime Devos Date: Fri, 11 Mar 2022 23:45:53 +0100 In-Reply-To: References: <3FC21903-C19B-49C1-B865-7D15E1B3EC74@tobias.gr> <2D451842-1953-44AE-A6E8-B50EC77A26A0@tobias.gr> <_Zczh2RFJMdo3Xxkpzzzfq2LT3_PlZVB2huEPbAOcMoPnxeZWSZD7_BJfMZewYiM_LRQk4y6ScvTx_M7L-JQau-5IDMIe9G-req83waeb5o=@evrl.com> <87wnh0w41s.fsf_-_@gnu.org> <3772387f64195fabd6d4a69a4d29912e43896ba9.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-N5FjIaWg6QaHheKB4z2F" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1647038754; bh=7OGJwGr0a+vNwFZUzKOJXBVTVfHD7sRN3PCQ8koKcEY=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=KtiKlw0mAWo2uSCQzXddSOASrZkOfheQ4pHNvDugFRoAYuyPmxM/mLLMKpwmNTd9y UGO9tnv1fTzMlBb0uUG9VgLIld/Fo2EGpKuUsWg/720GJDxEQQPJ2YSOsUqLYPcj23 Jxr0IhdCWzcNw+dPCPAU6tIrPA/x7wy0D1QOlFPPpoaIanOvRAig6Yt8qgxM0bcvNu 6oMzCjgqvEClu2r4AXSDuX0tts/XFoluvh3/VFVH0g11bYdctUWjxTqK5KVDKjbXMm yqWs3lVsB7SXJcSXlSAYHN1Vfn+g74xu0V2hwcxrPfoW4PaERQRR+JT4hHHS6ab7EQ jxY7aLbjNxiaQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647038773; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=7OGJwGr0a+vNwFZUzKOJXBVTVfHD7sRN3PCQ8koKcEY=; b=VcggXlvfFKcCgo7LpLs+ShWkyMYFtJwIW2/LWrVI/ckNk+hLr1EavH8O8Lts7CSxR9ZMit 0SZU1pWNtkkuCY0jE1Gy3ZBmOZHHs1ke3Ncp8YmZD18B2L7n7RVxONHxWfU4OB1qseBRUd MxIIkPGPt+ro4BwwBh/MV2h3VOqug84xBnQyH7lVf+P+qppXkDx0DQr4KyRjrAOjuCrED9 xRbAzWfwXzkH196IGmJ/+8SjX3CT7jCwpYgToiqYUnUfeUqbX27gXpq0rs9pyIzkmOFmgf eOkPHaetUQotji+x46CCAPbTpVZJaciznP7sdgbBBNZ81g1VzseOcK6QEvX6QA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647038773; a=rsa-sha256; cv=none; b=cAVgm2JIpzit+CTkGy+FI6sLXmDzExr6GpHkWmVNm5SG9rz/yfHEoPmgBQbWSyN2xnyPmI NReLnoI4OtyhaAKf4JWKGcOob2t9RPIAUzzxAN8ZmTcmS/eQxwPZ06cAyDKmlpcI7lS79d +ObGbvbuXr8xcHdNAfIf01Lf4vX1D/sfaopC7XjXgLD1FJeO3yYDeDHlTLdi1QAtzJaZF2 MV8JaObQcwuzTHCHsGB6oP0z+IBOSd5lbKXcf1f2plpTzB7fB6PHGO5YIKK8JpPIv+3fci wzne3y3meYgx7twumJFMMIpyCDomYHizoWD9jzWX99U3jNFkrW164NRz9GF9zg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=KtiKlw0m; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 2.81 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=KtiKlw0m; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3FA2533EB0 X-Spam-Score: 2.81 X-Migadu-Scanner: scn0.migadu.com X-TUID: GlDhWShzT9bH --=-N5FjIaWg6QaHheKB4z2F Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cees de Groot schreef op vr 11-03-2022 om 22:36 [+0000]: > Well, feel free to do the patching work. Realize that you are going > to do work for a) a very small group of developers (Elixir is a small > language and Guix isn=E2=80=99t hardly a widely spread system to begin wi= th), > b) a subset of those that need git dependencies, and c) a subset of > _those_ that need these dependencies on a project source tree that > itself was not checked out with git (otherwise the git executable > will already be in the environment and everything will work).=C2=A0 This is not only for the subset that uses git dependencies. It is for anyone writing and using Elixir packages, see my paragraph about reference baking (in general, not git-specific): > The only remaining reasons for removing it, appear to be avoiding > having to tackle the reference obfuscating issue -- sooner or later > (*), I expect there will eventually be an elixir-build-system and a > few elixir packages. These elixir packages might need a few > 'substitute*'- style hardcoding. So eventually, I expect the issue > will reappear again and frequently at that, so we might as well try > to fix it now. More specifically, you could look at how, say, 'info-reader' uses 'substitute*', 'search-input-file', 'gunzip' and 'gzip' Greetings, Maxime. --=-N5FjIaWg6QaHheKB4z2F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYivRIRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7opGAQCCAAUNyCWGHd4XPvnKKtlP3h0W 2iC1voPQRxJ1bpWHjwD+OlMO0b8648Y2DvzND/g2+M2qIReLNRQvfj9XDrcpywc= =HJ63 -----END PGP SIGNATURE----- --=-N5FjIaWg6QaHheKB4z2F--