[bug#74024] [PATCH] gnu: Add gnome-shell-extension-quick-close-in-overview

[bug#74024] [PATCH] gnu: Add gnome-shell-extension-quick-close-in-overview

[Qwel via Guix-patches via]

---
 gnu/packages/gnome-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index a09c0befb0..63eaa85ff9 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -1277,6 +1277,41 @@ (define-public gnome-shell-extension-vitals
 bar of the GNOME Shell.")
     (license license:gpl2+)))
 
+(define-public gnome-shell-extension-quick-close-in-overview
+  (package
+    (name "gnome-shell-extension-quick-close-in-overview")
+    (version "1.9.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/p91paul/middleclickclose")
+             (commit (string-append "v" version))))
+       (sha256
+        (base32 "11jsagvcmpnakp1s4hh84anl23hprmkwlyb9ykbpqc64glpwp7ff"))
+       (file-name (git-file-name name version))))
+    (build-system copy-build-system)
+    (arguments
+     (list
+      #:install-plan
+      #~'(("." "share/gnome-shell/extensions/"
+           #:include-regexp ("\\.compiled$" "\\.js(on)?$" "\\.mo$")))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'install 'compile-schemas
+            (lambda _
+              (with-directory-excursion
+               "middleclickclose@paolo.tranquilli.gmail.com/schemas"
+               (invoke "glib-compile-schemas" ".")))))))
+    (native-inputs (list `(,glib "bin")))
+    (synopsis
+     "Gnome shell extension for closing apps in overview with a middle click")
+    (description
+     "Close windows with a button click (the middle one by default) when in
+ overview mode.")
+    (home-page "https://github.com/p91paul/middleclickclose")
+    (license license:gpl2)))
+
 (define-public arc-theme
   (package
     (name "arc-theme")

base-commit: 2394a7f5fbf60dd6adc0a870366adb57166b6d8b
-- 
2.46.0

[bug#74024] [PATCH] gnu: Add gnome-shell-extension-quick-close-in-overview

[Liliana Marie Prikler]

Am Freitag, dem 25.10.2024 um 22:58 +0200 schrieb Qwel:
> ---
Missing ChangeLog.

>  gnu/packages/gnome-xyz.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
> index a09c0befb0..63eaa85ff9 100644
> --- a/gnu/packages/gnome-xyz.scm
> +++ b/gnu/packages/gnome-xyz.scm
> @@ -1277,6 +1277,41 @@ (define-public gnome-shell-extension-vitals
>  bar of the GNOME Shell.")
>      (license license:gpl2+)))
>  
> +(define-public gnome-shell-extension-quick-close-in-overview
> +  (package
> +    (name "gnome-shell-extension-quick-close-in-overview")
> +    (version "1.9.1")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/p91paul/middleclickclose")
> +             (commit (string-append "v" version))))
> +       (sha256
> +        (base32
> "11jsagvcmpnakp1s4hh84anl23hprmkwlyb9ykbpqc64glpwp7ff"))
> +       (file-name (git-file-name name version))))
> +    (build-system copy-build-system)
> +    (arguments
> +     (list
> +      #:install-plan
> +      #~'(("." "share/gnome-shell/extensions/"
> +           #:include-regexp ("\\.compiled$" "\\.js(on)?$"
> "\\.mo$")))
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-before 'install 'compile-schemas
> +            (lambda _
> +              (with-directory-excursion
> +               "middleclickclose@paolo.tranquilli.gmail.com/schemas"
> +               (invoke "glib-compile-schemas" ".")))))))
> +    (native-inputs (list `(,glib "bin")))
> +    (synopsis
> +     "Gnome shell extension for closing apps in overview with a
> middle click")
> +    (description
> +     "Close windows with a button click (the middle one by default)
> when in
> + overview mode.")
The synopsis should be shorter, the description could be a bit longer
and better structured.
> +    (home-page "https://github.com/p91paul/middleclickclose")
> +    (license license:gpl2)))
Should be gpl2+.

Cheers

[bug#74024] [PATCH v3dee2d6] gnu: Add gnome-shell-extension-quick-close-in-overview

[Qwel via Guix-patches via]

* gnu/packages/gnome-xyz (gnome-shell-extension-quick-close-in-overview): New variable.
---
 gnu/packages/gnome-xyz.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 63eaa85ff9..24c5d38f9b 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -1304,13 +1304,13 @@ (define-public gnome-shell-extension-quick-close-in-overview
                "middleclickclose@paolo.tranquilli.gmail.com/schemas"
                (invoke "glib-compile-schemas" ".")))))))
     (native-inputs (list `(,glib "bin")))
-    (synopsis
-     "Gnome shell extension for closing apps in overview with a middle click")
+    (synopsis "Extension for closing apps in overview with a mouse click")
     (description
-     "Close windows with a button click (the middle one by default) when in
- overview mode.")
+     "Close windows by clicking them in overview, by default with the middle button.
+The button can be configured to any mouse button, including the 4 to 9 buttons for
+non-standard mices.")
     (home-page "https://github.com/p91paul/middleclickclose")
-    (license license:gpl2)))
+    (license license:gpl2+)))
 
 (define-public arc-theme
   (package

base-commit: 2394a7f5fbf60dd6adc0a870366adb57166b6d8b
prerequisite-patch-id: f7c033ee710d4061cf1580d039076032da034c07
-- 
2.46.0

[bug#74024] [PATCH] gnu: Add gnome-shell-extension-quick-close-in-overview

[Qwel via Guix-patches via]

Hi there

The last patch I sent fixes the issues you mentioned. At least tries to. 
It's a very simple extension and I can't really reach three lines of 
description without going philosophical.

Is there something else I need to do for the patch to be reviewed ?