From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id SMGHCu3RRWZiRwEAe85BDQ:P1 (envelope-from ) for ; Thu, 16 May 2024 11:29:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id SMGHCu3RRWZiRwEAe85BDQ (envelope-from ) for ; Thu, 16 May 2024 11:29:17 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=bwTnq6pi; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1715851757; a=rsa-sha256; cv=none; b=H+2ESuy2cRPB0kQXfmkFoGSNMhlTwFvk0FPASvdu+LCXRObJ9huRwE/hmpY5D8GDK/NwlO niMZLEdfDzhX36mmjVNxvK0HOYTtaC9U/YqcGsd1T0PAntcjOYiMCjshkGpALnKyLU+mxd p8lGvTQrEuZA5ArRl14RAJvd1GPENF6hpmRm0vi7BhozdzBUQb1VgmjuhI5mW45rs29AcO QyTWx9/NNuHzkPbYekG21hh0yAxvfRJaLRPQqz8mpnCoi6KT7lFR8PqZ7XEq0CI4p8S9ru BjyMoIbITOhD3vYpBmQQyDl0SVIeKho6lD1fIg28WOpZELc2UmNwH15845PPvw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=bwTnq6pi; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1715851757; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=uKcphVikyNow4yZGuNO/3pOoHw3mzlzI8xGGxNmfpXY=; b=lkX7pOemB3wCBmO1V2Fo9mHbgeCcBmDuMSWsAXSRzARwba6HLJI5yt8JdNRp3EQJPZiBz+ g5Nmhqj+2pmilNHBEpvjO1eiF/D4enyFd3Rnyl1Z14yRU35T5W8bIlvzpVDO7yrs1DWiqc hfh16qkO2ey3cx2DBAiFY+UexHASGWf7eCkLL3pqplPDER3Lc4btmLdDaC39daV04Nbe+z Bz75DUQhUuqaVq/GjSwc0oYH36mIpzwu7mOxEYjfKS55Lq40sDoGqgXMTIqJGYKBgNcH3x cEDWMIpC0EkQCJcCfiaQrBec7q5Uu0aK/wlTzIaayuvSxfNMXHKBTCB3ejm1Ow== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ACF1B1DEC8 for ; Thu, 16 May 2024 11:29:16 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s7XQB-0003Bl-MT; Thu, 16 May 2024 05:29:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7XQ6-00037s-3C for guix-patches@gnu.org; Thu, 16 May 2024 05:29:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s7XQ4-00032E-5C for guix-patches@gnu.org; Thu, 16 May 2024 05:29:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s7XQ6-0000hu-8b for guix-patches@gnu.org; Thu, 16 May 2024 05:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70845] [PATCH v2] services: Add fancontrol-service-type. Resent-From: Adrien 'neox' Bourmault Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 May 2024 09:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70845@debbugs.gnu.org Cc: Juliana Sims Received: via spool by 70845-submit@debbugs.gnu.org id=B70845.17158517002675 (code B ref 70845); Thu, 16 May 2024 09:29:02 +0000 Received: (at 70845) by debbugs.gnu.org; 16 May 2024 09:28:20 +0000 Received: from localhost ([127.0.0.1]:47690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7XPQ-0000h5-0w for submit@debbugs.gnu.org; Thu, 16 May 2024 05:28:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7XPO-0000go-Gl for 70845@debbugs.gnu.org; Thu, 16 May 2024 05:28:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s7XPF-0002v0-4r; Thu, 16 May 2024 05:28:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:To:From: Subject; bh=uKcphVikyNow4yZGuNO/3pOoHw3mzlzI8xGGxNmfpXY=; b=bwTnq6pi9dpPMevuB DqZsts9tYfx1x40uF+89z/aWTMyAecDcPtbUsRNnzQ4sl80Zi4Qd79T/EayoRa3uCUyvn7fN8nhVp bvVd2u9PrXiwoG/dd1QUG99NZF0eh6nHqW7f2UYO589uWSrD2q1juPW5Q726h84cjEi7tpcBTutgB +z48osv/X0nl3ANh9iqOMPGCIUkg2EKhsGrplqrebHoBgrUVsi13W9sySjcYVRJgg1pYUIT13j9J7 SftuFKbcqk+EWz+kXigjn37HwCh9oLhjmEll9wORCANrMY24mA6aB5qNI01Kioy+f++zvjpHV8kHZ ObxH2+QZ77JZCwq1Q==; Message-ID: <3c931f339af9e0fbe0ea2110cb253e95a70d972e.camel@gnu.org> From: Adrien 'neox' Bourmault In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-fcv8QdUWSLhJJUEY758t" Date: Thu, 16 May 2024 11:27:42 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.48.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: ACF1B1DEC8 X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -9.37 X-Spam-Score: -9.37 X-TUID: DdmOR5qEuXbl --=-fcv8QdUWSLhJJUEY758t Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mercredi 15 mai 2024 =C3=A0 18:16 -0400, Juliana Sims a =C3=A9crit=C2=A0= : > Hi Adrien, Hi Juliana and thanks a lot for your review. I'm now working on a v3 ;) > First and foremost, this service needs documentation. Could you add=20 > that as well? Speaking of documentation, the 'documentation' field of=20 > your Shepherd service has an extraneous bit of whitespace. Ok, seems sensible to do, I'm working on it and fixing the whitespace issue= . >=20 > Is it absolutely vital to use root for this service? Could you instead= =20 > create a user and usergroup with only the privileges required to run=20 > fancontrol? You may need to do something with udev so that works. I'm=20 > not sure exactly what privileges are required, but avoiding root seems= =20 > like a good idea. I don't actually know if this is vital, but it was the only way to make it = work properly. I did not think about udev though, so I'll try to test things. I = agree that avoiding root is a good idea. > I don't know this package or how it works, but would it be possible for= =20 > this service to generate that config automatically when it's first=20 > started? If the config is customizable about generation, you could then= =20 > expose various settings through the Guix service interface for users to= =20 > modify and rewrite the file for them. That would make using=20 > define-configuration worthwhile for more than simply the ability to=20 > change the package. Okay, perhaps more details are needed then. The fancontrol software is made= to control the speed of the fans (CPU heatsinks for example) based on a configuration that is proper to the fans and that depends on many physical parameters that might include, sometimes, the environment where the compute= r is used. This configuration has to be generated with the pmwconfig software, w= hich will ask questions to the users (for example "Should we check I2C bus?" or = "Did you hear a fan stopping?"). Since the configuration process is both critica= l and interactive, it appears difficult to me to do that automatically. One more = thing is that users should recreate a configuration when the use environment has changed. >=20 > All that aside, you should be able to expose the package setting to=20 > users without using define-configuration. Ok, thanks for the information. I'll work on that. Have a nice day everyone and happy hacking! --=20 Adrien Bourmault Maintainer, GNU Boot project Associate member, Free Software Foundation GPG : 393D4CC68136F39799DA75F295F65F55F682A17A --=-fcv8QdUWSLhJJUEY758t Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQQ5PUzGgTbzl5nadfKV9l9V9oKhegUCZkXRjQAKCRCV9l9V9oKh ekNgAP9B9cPpTGsFdWDdto6YMMZBjH+rHtr+YgGLs5qBurUciwD7B20iSTpIvojB on2hHvjkngazIGKvMcvt4Hy783LzigE= =SMTk -----END PGP SIGNATURE----- --=-fcv8QdUWSLhJJUEY758t--