From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e30AB-0005Y1-7l for guix-patches@gnu.org; Fri, 13 Oct 2017 09:38:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e30A6-000232-BM for guix-patches@gnu.org; Fri, 13 Oct 2017 09:38:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56570) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e30A6-00020l-8z for guix-patches@gnu.org; Fri, 13 Oct 2017 09:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e30A5-00012J-RK for guix-patches@gnu.org; Fri, 13 Oct 2017 09:38:01 -0400 Subject: bug#28719: [PATCH 5/6] gnu: qscintilla: Adjust installation directory layout. Resent-To: guix-patches@gnu.org Resent-Message-ID: References: <20171006120214.29511-1-h.goebel@crazy-compilers.com> <20171006120214.29511-5-h.goebel@crazy-compilers.com> <87efqb1cwn.fsf@member.fsf.org> <41f1882d-41a5-4992-bb7d-d0b5481c6ca5@crazy-compilers.com> <87y3ogip2d.fsf@member.fsf.org> From: Hartmut Goebel Message-ID: <3c7fe2dc-dedc-e927-6ac2-522e840207e7@crazy-compilers.com> Date: Fri, 13 Oct 2017 15:37:41 +0200 MIME-Version: 1.0 In-Reply-To: <87y3ogip2d.fsf@member.fsf.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: 28719-close@debbugs.gnu.org I pushed the changes as 5430732b22dcee5ae162826ee1dfefb9510eaeca, including the fixed commit-message for "qt: Fix install paths in submodules". Thanks for the review. Am 12.10.2017 um 13:27 schrieb 宋文武: > Oh, my bad. I forget that those variables will only be correct when > qmake is using the customized qt.conf (like qtsvg), you can make > qscintilla inherit from qtsvg to use its 'configure-qmake' phase. I did not implement this for two reasons: - qtsvg is unrelated to QScintilla, so I would find it confusing to inherit it. - Creating a qt.conf file is much more code than just chaining some variable in an existing file. - I want to get it finished :-) So I somebody wants to implement a 'configure-qmake' phase I will not object. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |