From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: 宋文武 <iyzsong@member.fsf.org>
Cc: 28719-close@debbugs.gnu.org
Subject: bug#28719: [PATCH 5/6] gnu: qscintilla: Adjust installation directory layout.
Date: Fri, 13 Oct 2017 15:37:41 +0200 [thread overview]
Message-ID: <3c7fe2dc-dedc-e927-6ac2-522e840207e7@crazy-compilers.com> (raw)
In-Reply-To: <87y3ogip2d.fsf@member.fsf.org>
I pushed the changes as 5430732b22dcee5ae162826ee1dfefb9510eaeca,
including the fixed commit-message for "qt: Fix install paths in
submodules".
Thanks for the review.
Am 12.10.2017 um 13:27 schrieb 宋文武:
> Oh, my bad. I forget that those variables will only be correct when
> qmake is using the customized qt.conf (like qtsvg), you can make
> qscintilla inherit from qtsvg to use its 'configure-qmake' phase.
I did not implement this for two reasons:
- qtsvg is unrelated to QScintilla, so I would find it confusing to
inherit it.
- Creating a qt.conf file is much more code than just chaining some
variable in an existing file.
- I want to get it finished :-) So I somebody wants to implement a
'configure-qmake' phase I will not object.
--
Regards
Hartmut Goebel
| Hartmut Goebel | h.goebel@crazy-compilers.com |
| www.crazy-compilers.com | compilers which you thought are impossible |
next prev parent reply other threads:[~2017-10-13 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 11:59 [bug#28719] [PATCH 0/6] Qt: Use a more standard directory layout Hartmut Goebel
2017-10-06 12:02 ` [bug#28719] [PATCH 1/6] gnu: qtbase: " Hartmut Goebel
2017-10-06 12:02 ` [bug#28719] [PATCH 2/6] gnu: qt: Fix install paths in submodules Hartmut Goebel
2017-10-10 11:01 ` 宋文武
2017-10-06 12:02 ` [bug#28719] [PATCH 3/6] gnu: qwt: Adjust installation directory layout Hartmut Goebel
2017-10-06 12:02 ` [bug#28719] [PATCH 4/6] gnu: qtwebkit: Fix rpath for the qmlwebkit plugins Hartmut Goebel
2017-10-06 12:02 ` [bug#28719] [PATCH 5/6] gnu: qscintilla: Adjust installation directory layout Hartmut Goebel
2017-10-10 11:05 ` 宋文武
2017-10-10 14:43 ` Hartmut Goebel
2017-10-10 15:39 ` Hartmut Goebel
2017-10-12 11:27 ` 宋文武
2017-10-13 13:37 ` Hartmut Goebel [this message]
2017-10-14 6:30 ` 宋文武
2017-10-06 12:02 ` [bug#28719] [PATCH 6/6] gnu: kde-framworks: Fix installation directories Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c7fe2dc-dedc-e927-6ac2-522e840207e7@crazy-compilers.com \
--to=h.goebel@crazy-compilers.com \
--cc=28719-close@debbugs.gnu.org \
--cc=iyzsong@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.