* bug#21888: guix-publish gets ERROR when serve gtk+.
@ 2015-11-12 4:41 宋文武
2015-11-12 20:28 ` Ludovic Courtès
0 siblings, 1 reply; 8+ messages in thread
From: 宋文武 @ 2015-11-12 4:41 UTC (permalink / raw)
To: 21888
can't substitute gtk+ from a guix-publish server, it fails with:
GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2
In web/server/http.scm:
117:27 1 (http-read #<<http-server> socket: #<input-output: so...>)
In unknown file:
0 (peek-char #<input-output: socket 13>)
ERROR: In procedure fport_fill_input: Connection reset by peer
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#21888: guix-publish gets ERROR when serve gtk+.
2015-11-12 4:41 bug#21888: guix-publish gets ERROR when serve gtk+ 宋文武
@ 2015-11-12 20:28 ` Ludovic Courtès
2015-11-13 5:21 ` 宋文武
0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2015-11-12 20:28 UTC (permalink / raw)
To: 宋文武; +Cc: 21888, iyzsong
宋文武 <iyzsong@openmailbox.org> skribis:
> can't substitute gtk+ from a guix-publish server, it fails with:
>
> GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2
> In web/server/http.scm:
> 117:27 1 (http-read #<<http-server> socket: #<input-output: so...>)
> In unknown file:
> 0 (peek-char #<input-output: socket 13>)
> ERROR: In procedure fport_fill_input: Connection reset by peer
This means that the *client* closed the connection. Could you check
what happened on the client side?
It may be more convenient to use wget on the client-side to reproduce
the problem.
TIA,
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#21888: guix-publish gets ERROR when serve gtk+.
2015-11-12 20:28 ` Ludovic Courtès
@ 2015-11-13 5:21 ` 宋文武
2015-11-13 8:07 ` Ludovic Courtès
0 siblings, 1 reply; 8+ messages in thread
From: 宋文武 @ 2015-11-13 5:21 UTC (permalink / raw)
To: ludo; +Cc: 21888, iyzsong
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On 2015-11-13 04:28, ludo@gnu.org wrote:
> 宋文武 <iyzsong@openmailbox.org> skribis:
>
>> can't substitute gtk+ from a guix-publish server, it fails with:
>>
>> GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2
>> In web/server/http.scm:
>> 117:27 1 (http-read #<<http-server> socket: #<input-output:
>> so...>)
>> In unknown file:
>> 0 (peek-char #<input-output: socket 13>)
>> ERROR: In procedure fport_fill_input: Connection reset by peer
>
> This means that the *client* closed the connection. Could you check
> what happened on the client side?
>
> It may be more convenient to use wget on the client-side to reproduce
> the problem.
OK, I attach logs of:
wget -qd
'http://localhost:8080/nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2'
wget -qd
'http://localhost:8080/nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk%2B-3.18.2'
[-- Attachment #2: guix-publish-wget-gtk%2B --]
[-- Type: text/plain, Size: 1422 bytes --]
DEBUG output created by Wget 1.16.3 on linux-gnu.
URI encoding = 'ANSI_X3.4-1968'
converted 'http://localhost:8080/nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk%2B-3.18.2' (ANSI_X3.4-1968) -> 'http://localhost:8080/nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2' (UTF-8)
Caching localhost => ::1 127.0.0.1
Closed fd 3
Created socket 3.
Releasing 0x0000000001448300 (new refcount 1).
---request begin---
GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 HTTP/1.1
User-Agent: Wget/1.16.3 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: localhost:8080
Connection: Keep-Alive
---request end---
---response begin---
HTTP/1.1 404 Not Found
Content-Length: 69
Content-Type: text/plain;charset=utf-8
---response end---
Registered socket 3 for persistent reuse.
URI content encoding = 'utf-8'
Skipping 69 bytes of body: [Resource not found: /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2] done.
[IRI fallbacking to non-utf8 for 'http://localhost:8080/nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk%2B-3.18.2'
Reusing fd 3.
---request begin---
GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk%2B-3.18.2 HTTP/1.1
User-Agent: Wget/1.16.3 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: localhost:8080
Connection: Keep-Alive
---request end---
---response begin---
HTTP/1.1 200 OK
Content-Type: application/x-nix-archive;charset=ISO-8859-1
---response end---
URI content encoding = 'ISO-8859-1'
[-- Attachment #3: guix-publish-wget-gtk+ --]
[-- Type: text/plain, Size: 912 bytes --]
DEBUG output created by Wget 1.16.3 on linux-gnu.
URI encoding = 'ANSI_X3.4-1968'
converted 'http://localhost:8080/nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2' (ANSI_X3.4-1968) -> 'http://localhost:8080/nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2' (UTF-8)
Caching localhost => ::1 127.0.0.1
Closed fd 3
Created socket 3.
Releasing 0x000000000218f260 (new refcount 1).
---request begin---
GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 HTTP/1.1
User-Agent: Wget/1.16.3 (linux-gnu)
Accept: */*
Accept-Encoding: identity
Host: localhost:8080
Connection: Keep-Alive
---request end---
---response begin---
HTTP/1.1 404 Not Found
Content-Length: 69
Content-Type: text/plain;charset=utf-8
---response end---
Registered socket 3 for persistent reuse.
URI content encoding = 'utf-8'
Skipping 69 bytes of body: [Resource not found: /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2] done.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#21888: guix-publish gets ERROR when serve gtk+.
2015-11-13 5:21 ` 宋文武
@ 2015-11-13 8:07 ` Ludovic Courtès
2015-11-13 12:05 ` 宋文武
0 siblings, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2015-11-13 8:07 UTC (permalink / raw)
To: 宋文武; +Cc: iyzsong, 21888
宋文武 <iyzsong@openmailbox.org> skribis:
> ---request begin---
> GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 HTTP/1.1
> User-Agent: Wget/1.16.3 (linux-gnu)
> Accept: */*
> Accept-Encoding: identity
> Host: localhost:8080
> Connection: Keep-Alive
>
> ---request end---
>
> ---response begin---
> HTTP/1.1 404 Not Found
> Content-Length: 69
> Content-Type: text/plain;charset=utf-8
>
> ---response end---
> Registered socket 3 for persistent reuse.
> URI content encoding = 'utf-8'
> Skipping 69 bytes of body: [Resource not found: /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2] done.
Here ‘guix publish’ returns 404, presumably because
/gnu/store/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 is not on disk
or not valid.
Is this correct?
Now, does http://localhost/1dlz1am0qmj1579f5p6j5cvfx9l2aw50.narinfo
return? It should also return 404, otherwise there’s an inconsistency.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#21888: guix-publish gets ERROR when serve gtk+.
2015-11-13 8:07 ` Ludovic Courtès
@ 2015-11-13 12:05 ` 宋文武
2015-11-13 13:29 ` Ludovic Courtès
2016-06-08 17:09 ` Ludovic Courtès
0 siblings, 2 replies; 8+ messages in thread
From: 宋文武 @ 2015-11-13 12:05 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 21888
ludo@gnu.org (Ludovic Courtès) writes:
> 宋文武 <iyzsong@openmailbox.org> skribis:
>
>> ---request begin---
>> GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 HTTP/1.1
>> User-Agent: Wget/1.16.3 (linux-gnu)
>> Accept: */*
>> Accept-Encoding: identity
>> Host: localhost:8080
>> Connection: Keep-Alive
>>
>> ---request end---
>>
>> ---response begin---
>> HTTP/1.1 404 Not Found
>> Content-Length: 69
>> Content-Type: text/plain;charset=utf-8
>>
>> ---response end---
>> Registered socket 3 for persistent reuse.
>> URI content encoding = 'utf-8'
>> Skipping 69 bytes of body: [Resource not found: /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2] done.
>
> Here ‘guix publish’ returns 404, presumably because
> /gnu/store/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 is not on disk
> or not valid.
>
> Is this correct?
No, the gtk+ item is valid, and replace 'gtk+' with 'gtk%2B' in the url
will make wget download it happily.
>
> Now, does http://localhost/1dlz1am0qmj1579f5p6j5cvfx9l2aw50.narinfo
> return? It should also return 404, otherwise there’s an
> inconsistency.
for the narinfo, It does return 200.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#21888: guix-publish gets ERROR when serve gtk+.
2015-11-13 12:05 ` 宋文武
@ 2015-11-13 13:29 ` Ludovic Courtès
2015-11-13 14:17 ` Thompson, David
2016-06-08 17:09 ` Ludovic Courtès
1 sibling, 1 reply; 8+ messages in thread
From: Ludovic Courtès @ 2015-11-13 13:29 UTC (permalink / raw)
To: 宋文武; +Cc: 21888, David Thompson
iyzsong@member.fsf.org (宋文武) skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> 宋文武 <iyzsong@openmailbox.org> skribis:
>>
>>> ---request begin---
>>> GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 HTTP/1.1
>>> User-Agent: Wget/1.16.3 (linux-gnu)
>>> Accept: */*
>>> Accept-Encoding: identity
>>> Host: localhost:8080
>>> Connection: Keep-Alive
>>>
>>> ---request end---
>>>
>>> ---response begin---
>>> HTTP/1.1 404 Not Found
>>> Content-Length: 69
>>> Content-Type: text/plain;charset=utf-8
>>>
>>> ---response end---
>>> Registered socket 3 for persistent reuse.
>>> URI content encoding = 'utf-8'
>>> Skipping 69 bytes of body: [Resource not found: /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2] done.
>>
>> Here ‘guix publish’ returns 404, presumably because
>> /gnu/store/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 is not on disk
>> or not valid.
>>
>> Is this correct?
> No, the gtk+ item is valid, and replace 'gtk+' with 'gtk%2B' in the url
> will make wget download it happily.
Oooh, I see. We’re missing a decoding phase here. David? :-)
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#21888: guix-publish gets ERROR when serve gtk+.
2015-11-13 13:29 ` Ludovic Courtès
@ 2015-11-13 14:17 ` Thompson, David
0 siblings, 0 replies; 8+ messages in thread
From: Thompson, David @ 2015-11-13 14:17 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 宋文武, 21888, David Thompson
On Fri, Nov 13, 2015 at 8:29 AM, Ludovic Courtès <ludo@gnu.org> wrote:
> iyzsong@member.fsf.org (宋文武) skribis:
>
>> ludo@gnu.org (Ludovic Courtès) writes:
>>
>>> 宋文武 <iyzsong@openmailbox.org> skribis:
>>>
>>>> ---request begin---
>>>> GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 HTTP/1.1
>>>> User-Agent: Wget/1.16.3 (linux-gnu)
>>>> Accept: */*
>>>> Accept-Encoding: identity
>>>> Host: localhost:8080
>>>> Connection: Keep-Alive
>>>>
>>>> ---request end---
>>>>
>>>> ---response begin---
>>>> HTTP/1.1 404 Not Found
>>>> Content-Length: 69
>>>> Content-Type: text/plain;charset=utf-8
>>>>
>>>> ---response end---
>>>> Registered socket 3 for persistent reuse.
>>>> URI content encoding = 'utf-8'
>>>> Skipping 69 bytes of body: [Resource not found: /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2] done.
>>>
>>> Here ‘guix publish’ returns 404, presumably because
>>> /gnu/store/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 is not on disk
>>> or not valid.
>>>
>>> Is this correct?
>> No, the gtk+ item is valid, and replace 'gtk+' with 'gtk%2B' in the url
>> will make wget download it happily.
>
> Oooh, I see. We’re missing a decoding phase here. David? :-)
I don't know when I'll be able to fix it, but it sounds easy. I'll
post a patch when I have time.
Thanks,
- Dave
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#21888: guix-publish gets ERROR when serve gtk+.
2015-11-13 12:05 ` 宋文武
2015-11-13 13:29 ` Ludovic Courtès
@ 2016-06-08 17:09 ` Ludovic Courtès
1 sibling, 0 replies; 8+ messages in thread
From: Ludovic Courtès @ 2016-06-08 17:09 UTC (permalink / raw)
To: 宋文武; +Cc: 21888-done
iyzsong@member.fsf.org (宋文武) skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> 宋文武 <iyzsong@openmailbox.org> skribis:
>>
>>> ---request begin---
>>> GET /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 HTTP/1.1
>>> User-Agent: Wget/1.16.3 (linux-gnu)
>>> Accept: */*
>>> Accept-Encoding: identity
>>> Host: localhost:8080
>>> Connection: Keep-Alive
>>>
>>> ---request end---
>>>
>>> ---response begin---
>>> HTTP/1.1 404 Not Found
>>> Content-Length: 69
>>> Content-Type: text/plain;charset=utf-8
>>>
>>> ---response end---
>>> Registered socket 3 for persistent reuse.
>>> URI content encoding = 'utf-8'
>>> Skipping 69 bytes of body: [Resource not found: /nar/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2] done.
>>
>> Here ‘guix publish’ returns 404, presumably because
>> /gnu/store/1dlz1am0qmj1579f5p6j5cvfx9l2aw50-gtk+-3.18.2 is not on disk
>> or not valid.
>>
>> Is this correct?
> No, the gtk+ item is valid, and replace 'gtk+' with 'gtk%2B' in the url
> will make wget download it happily.
‘guix publish’ correctly decodes URIs in ‘request-path-components’, but
‘uri-decode’ does this:
--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(web uri)
scheme@(guile-user)> (uri-decode "/gtk+")
$12 = "/gtk "
scheme@(guile-user)> (string-ref $12 4)
$13 = #\space
--8<---------------cut here---------------end--------------->8---
I think that ‘uri-decode’ is right, and that Wget is wrong when it fails
to replace ‘+’ with ‘%2B’.
Regardless, the problem is that the faulty /nar/…-gtk+ URI comes from a
.narinfo generated by ‘guix publish’ itself. The fix is for ‘guix
publish’ to properly percent-encode it in the narinfo.
Done in 93961f02987cf738d116cc85cc32d97c2a488222.
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-06-08 17:10 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-12 4:41 bug#21888: guix-publish gets ERROR when serve gtk+ 宋文武
2015-11-12 20:28 ` Ludovic Courtès
2015-11-13 5:21 ` 宋文武
2015-11-13 8:07 ` Ludovic Courtès
2015-11-13 12:05 ` 宋文武
2015-11-13 13:29 ` Ludovic Courtès
2015-11-13 14:17 ` Thompson, David
2016-06-08 17:09 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.