From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0rwf-0008Cq-Kb for guix-patches@gnu.org; Wed, 19 Apr 2017 11:55:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0rwc-0006iE-Ie for guix-patches@gnu.org; Wed, 19 Apr 2017 11:55:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58946) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d0rwc-0006hk-7b for guix-patches@gnu.org; Wed, 19 Apr 2017 11:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d0rwb-0003uI-P4 for guix-patches@gnu.org; Wed, 19 Apr 2017 11:55:01 -0400 Subject: bug#26500: [PATCH] gnu: Add mcomix. Resent-Message-ID: Message-Id: <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Wed, 19 Apr 2017 21:23:49 +0530 In-reply-to: <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> References: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26500@debbugs.gnu.org nee writes: >> If mupdf is a heavy dependency and it is not commonly needed, you can >> drop it and just package with 7z and rar as dependencies. > > I have successfully patched in the path for 7zip. > I init the variable that stores it with a unicode string. I make the > assumption that the store path will never contain a ' character. > I read a little bit about unrar and it's issues with mcomix. > Unrar is very old and only supports RAR2, as someone says in the mcomix > issues it is unable to unpack most rar archives created after 2002¹. On > other distro mcomix currently relies on an unfree rar package², and > there is an open ticket³ about switching to a free library like > libarchiver (which supports RAR5 and is also used by file-roller, which > works fine on GuixSD). > > I tried unrar on the commandline and it would list file names, but > always fail on unpacking. When called by mcomix, it would always try to > read a password from stdin and freeze the gui. > I will omit rar support for now, since unrar is mostly useless. Ok, that's fine. > @@ -28,6 +29,7 @@ > #:use-module (guix packages) > #:use-module (guix build-system gnu) > #:use-module (guix build-system cmake) > + #:use-module (guix build-system python) > #:use-module (gnu packages autotools) > #:use-module (gnu packages algebra) > #:use-module (gnu packages base) > @@ -46,6 +48,7 @@ > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages qt) > #:use-module (gnu packages xorg) > + #:use-module (gnu packages python) > #:use-module (gnu packages)) Since these modules are already in alphabetical order, it would be good to keep them that way. Insert (gnu packages python) at an appropriate position. > + (inputs `(("python2-pillow" ,python2-pillow) > + ("python2-pygtk" ,python2-pygtk) > + ("p7zip" ,p7zip))) Please put these in alphabetical order too. That means p7zip will go on the top. > + (description "MComix is a customizable image viewer that specializes as > +a comic and manga reader. It supports a variety of container formats > +including CBZ, CB7, CBT, LHA. > +CBR and rar are currently unsupported, due to unfree dependencies. > +For optional pdf support, you can install the mupdf package.") Can we move the information about RAR and PDF support to a comment above the package definition, as done for the octave package?