From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id kIm+CdIwzWXOFQAAe85BDQ:P1 (envelope-from ) for ; Wed, 14 Feb 2024 22:29:54 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id kIm+CdIwzWXOFQAAe85BDQ (envelope-from ) for ; Wed, 14 Feb 2024 22:29:54 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=jph0fGGI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707946194; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=sKlq2lyyyivDJwieL+dSDBO4bwt2yBcA95oKy5PmzXc=; b=moBIlBwSajqNmezR+0uvQ26at/y/v99Joi0sYG4CGHNvXvfYlYqd6M45Z5Rm6Nwe/pvnkw XdOUT3aDIU/0Oy+TAXiQmRNMLwNAuOecPbMQdlzZDs5dAlaZ/HpNQ/rkexefFaueTiWY8X 9ddRG9p/PHQc/UBU4Tu8Z4CfR2UJcYhGoZPiMl3d2lAidKsBY8vvAkdNb7GMO5Fi9tV9DG pPnmPsnCzrAIM4lTpOj1P+6W96RqyqgpJeKBy3CS4Om9MDnl1I/evchiAM8jIAUM+ZzayS FGxbVwdsq9aBIbtx6yanShstUJe9Rk2UM2BkovCpmnCSYvQDNTs+0xK45EFUpA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=jph0fGGI; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707946194; a=rsa-sha256; cv=none; b=Ic6fFdnvXbucd0WOYYuMaJdJULnYgPNj3SeZgklnsuWlI8WMxOnv865mDu33MxekPjQ8Uj KHu8AVChC8HFFNcOLTmGydB8OOdrJ6sSArIT8pXJfrPll3sEPbovsmRZ5t4JMjz7iwNEDn sRsR/vXbi81pie8ATHRqYlfqHPAx79ePHSlQHSYzbkTsl2LrehB/9eLRcvIunhY1cKkwfc 7ARcGG7UoKgM5ZffoaA8wEFAd/Bc0+BGBwUtY4nVYe0ctU1K2/ycWq86nx4h6Hp4nHQWcX RXExs91LvEzzr+YTKnrhIJcq51H1Tq4jab8gEZqTFvZVCaoHY/8yrwyoUv/ctg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED7EB145C3 for ; Wed, 14 Feb 2024 22:29:53 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raMp8-0005jh-Bg; Wed, 14 Feb 2024 16:29:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raMp6-0005jI-EX for guix-patches@gnu.org; Wed, 14 Feb 2024 16:29:44 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1raMp6-0003HN-5a for guix-patches@gnu.org; Wed, 14 Feb 2024 16:29:44 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1raMpO-0004ac-CP for guix-patches@gnu.org; Wed, 14 Feb 2024 16:30:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69126] [PATCH 1/2] gnu: Add debug-assert. Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Feb 2024 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69126 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Paul A. Patience" , 69126@debbugs.gnu.org Received: via spool by 69126-submit@debbugs.gnu.org id=B69126.170794619617598 (code B ref 69126); Wed, 14 Feb 2024 21:30:02 +0000 Received: (at 69126) by debbugs.gnu.org; 14 Feb 2024 21:29:56 +0000 Received: from localhost ([127.0.0.1]:53448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raMpI-0004Zm-1W for submit@debbugs.gnu.org; Wed, 14 Feb 2024 16:29:56 -0500 Received: from mail-40134.protonmail.ch ([185.70.40.134]:44729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raMpF-0004ZY-O1 for 69126@debbugs.gnu.org; Wed, 14 Feb 2024 16:29:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1707946169; x=1708205369; bh=sKlq2lyyyivDJwieL+dSDBO4bwt2yBcA95oKy5PmzXc=; h=Date:To:From:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=jph0fGGI4z3aKpoJVHT2UcnC/ZEetk0Uvq2wyugMJUlgCgzJk7sRQaYe0WbzEHR4T jtn5v8ladcahI08Dd0Sov21NcLJ1fsM9I2nF0BfhRNah/COk+C+JqYjvK4z4EMuSHf E7cobI1mfs2n8o/59bt2n/WPadHuYBPLOpxP1HWDd/SQK//Q644W7+fNEHfGHOOy8o MdfcdVd0U+MPV6dorGZk3hIE3oZDh9tN4liVFTVBkm5HuKTyQzPKFqRY9VpkNanoCF pmTgcymrEXMbcX6D7y0ClC95Z/qT5awFQ9FVOVfLrZPMaRJEZ3XXnKbGRVuUrDbCyW iJG4JORC5qFRw== Date: Wed, 14 Feb 2024 21:29:05 +0000 Message-ID: <3bee2280-c098-4c23-9161-6d3c5a487768@protonmail.com> In-Reply-To: <0191a95edf076b5cd24326d49e54ce13f2bdb0d4.1707924715.git.paul@apatience.com> References: <0191a95edf076b5cd24326d49e54ce13f2bdb0d4.1707924715.git.paul@apatience.com> Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.97 X-Spam-Score: -6.97 X-Migadu-Queue-Id: ED7EB145C3 X-Migadu-Scanner: mx13.migadu.com X-TUID: +hD3+3O2oTch Things needing attention: `guix lint` issues a warning that the beginning of the description=20 starts with a lowercase letter. IMO this is reasonable because the first=20 word is the name of the project, and it is a common convention for=20 project names to remain lowercased (the README in the project follows=20 this convention). However I am not sure how the Guix maintainers=20 consider this. The arguments form is attached to a comment saying that there are no=20 tests, but it looks like the repository does contain a test in the=20 `test_package` directory with a separate CMakelists.txt file. I haven't=20 spent much time with the cmake build system in Guix, would it be=20 reasonable to replace the check phase with a procedure that uses the=20 file in this directory? If not then it might be helpful to replace the=20 comment with one explaining that, while tests exist, it is not feasible=20 to run them for some specific reason. More details: This diff applies cleanly to commit=20 ac470c516e19f194228edf9e348bdbc7fc10f97a. The following paragraph contains notes about the confidence level of=20 source integrity. These notes are provided to indicate that due=20 attention has been given to this matter and to provide transparency into=20 the level of confidence in the source as well as the entities trusted=20 with maintaining integrity. The "optimal" level of confidence is=20 use-case dependent, as is the trustability of any given entity. These=20 notes are provided for transparency to the committer and any other=20 interested parties and should not be interpreted as criticism of the commit= . The commit used in the source form is signed by PGP key=20 5DE3E0509C47EA3CF04A42D34AEE18F83AFDEB23. The key is expired but NOT=20 revoked. It is available on the Ubuntu keyserver=20 (http://keyserver.ubuntu.com/pks/lookup?op=3Dget&search=3D0x5de3e0509c47ea3= cf04a42d34aee18f83afdeb23)=20 with several other signatures, though none that are trusted by my=20 keyring. It is also available on the OpenPGP keyserver=20 (https://keys.openpgp.org/vks/v1/by-fingerprint/5DE3E0509C47EA3CF04A42D34AE= E18F83AFDEB23)=20 but without a UID, meaning the email address was not verified. Note that=20 one of the UIDs listed in the Ubuntu server is "GitHub (web-flow=20 commit)", implying that the GitHub server is ultimately responsible for=20 maintaining integrity. `./pre-inst-env guix build debug-assert` succeeded on my machine, an=20 x86_64 Xen guest. Additionally, the following program (based on the=20 example in the README) successfully compiled and produced the expected=20 output. main.cpp ``` #include struct mymodule : debug_assert::default_handler,=20 debug_assert::set_level(-1)> {}; int main(void) { =C2=A0=C2=A0 =C2=A0DEBUG_ASSERT(1 +1 =3D=3D 3, my_module{}, debug_assert::= level<2>{}); } ``` ``` $ ./pre-inst-env guix shell gcc-toolchain debug-assert -C -- g++=20 -std=3Dc++11 main.cpp $ ./a.out [debug assert] main.cpp:6: Assertion '1 +1 =3D=3D 3' failed. Aborted ``` The LICENSE file provided in the source repository matches the contents=20 I see at https://directory.fsf.org/wiki/License:Zlib.