all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter.
@ 2024-08-15  3:05 Spencer King
  2024-08-15  3:17 ` [bug#72632] (no subject) Spencer King
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Spencer King @ 2024-08-15  3:05 UTC (permalink / raw)
  To: 72632
  Cc: Spencer King, Andrew Tropin, Katherine Cox-Buday,
	Liliana Marie Prikler

* gnu/packages/emacs-xyz.scm (emacs-tinysegmenter): New variable.

Change-Id: Ibad46e4db2a1d49b4f40c8ea6d2f6f19d271aa29
---
 gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index df66aea507..0c6af181fa 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -143,6 +143,7 @@
 ;;; Copyright © 2024 Noé Lopez <noelopez@free.fr>
 ;;; Copyright © 2024 gemmaro <gemmaro.dev@gmail.com>
 ;;; Copyright © 2024 Daniel Szmulewicz <daniel.szmulewicz@gmail.com>
+;;; Copyright © 2024 Spencer King <spencer.king@nursiapress.com>
 
 ;;;
 ;;; This file is part of GNU Guix.
@@ -6301,6 +6302,27 @@ (define-public emacs-kanji
 and limited version of the images provided by the KanjiVG project.")
       (license license:gpl3+))))
 
+(define-public emacs-tinysegmenter
+  (package
+    (name "emacs-tinysegmenter")
+    (version "20141124.1013")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/myuhe/tinysegmenter.el")
+             (commit "872134704bd25c13a4c59552433da4c6881b5230")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1n8cn6mr26hgmsm2mkbj5gs6dv61d0pap8ija4g0n1vsibfhzd8j"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/myuhe/tinysegmenter.el")
+    (synopsis "Super compact Japanese tokenizer in Emacs Lisp")
+    (description
+     "This package provides functions for tokenizing Japanese text in
+Emacs buffers.")
+    (license license:bsd-3)))
+
 (define-public emacs-kbd
   ;; Package has no release.  Version is extracted from "Version:" keyword in
   ;; main file.

base-commit: ca5ff8aa8b50ac317003d76cc4ea2a621d5a3819
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#72632] (no subject)
  2024-08-15  3:05 [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter Spencer King
@ 2024-08-15  3:17 ` Spencer King
  2024-08-15  5:50 ` [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter Liliana Marie Prikler
  2024-08-20  8:26 ` bug#72632: " Nicolas Goaziou via Guix-patches via
  2 siblings, 0 replies; 4+ messages in thread
From: Spencer King @ 2024-08-15  3:17 UTC (permalink / raw)
  To: 72632

If you are looking to confirm the license it is linked in a source code comment 
in the file tinysegmenter.el.






^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter.
  2024-08-15  3:05 [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter Spencer King
  2024-08-15  3:17 ` [bug#72632] (no subject) Spencer King
@ 2024-08-15  5:50 ` Liliana Marie Prikler
  2024-08-20  8:26 ` bug#72632: " Nicolas Goaziou via Guix-patches via
  2 siblings, 0 replies; 4+ messages in thread
From: Liliana Marie Prikler @ 2024-08-15  5:50 UTC (permalink / raw)
  To: Spencer King, 72632; +Cc: Katherine Cox-Buday, Andrew Tropin

Am Mittwoch, dem 14.08.2024 um 22:05 -0500 schrieb Spencer King:
> * gnu/packages/emacs-xyz.scm (emacs-tinysegmenter): New variable.
> 
> Change-Id: Ibad46e4db2a1d49b4f40c8ea6d2f6f19d271aa29
> ---
>  gnu/packages/emacs-xyz.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index df66aea507..0c6af181fa 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -143,6 +143,7 @@
>  ;;; Copyright © 2024 Noé Lopez <noelopez@free.fr>
>  ;;; Copyright © 2024 gemmaro <gemmaro.dev@gmail.com>
>  ;;; Copyright © 2024 Daniel Szmulewicz <daniel.szmulewicz@gmail.com>
> +;;; Copyright © 2024 Spencer King <spencer.king@nursiapress.com>
>  
>  ;;;
>  ;;; This file is part of GNU Guix.
> @@ -6301,6 +6302,27 @@ (define-public emacs-kanji
>  and limited version of the images provided by the KanjiVG project.")
>        (license license:gpl3+))))
>  
> +(define-public emacs-tinysegmenter
> +  (package
> +    (name "emacs-tinysegmenter")
> +    (version "20141124.1013")
Note: we don't do MELPA versioning.  Use git-version instead.
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/myuhe/tinysegmenter.el")
> +             (commit "872134704bd25c13a4c59552433da4c6881b5230")))
IMHO, commit tags should always be let-bound.  There are a few odd
cases in which they aren't, but these are exceptions, not the rule.
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> "1n8cn6mr26hgmsm2mkbj5gs6dv61d0pap8ija4g0n1vsibfhzd8j"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/myuhe/tinysegmenter.el")
> +    (synopsis "Super compact Japanese tokenizer in Emacs Lisp")
Avoid marketing terms like "super compact".  "Compact" ought to suffice
if there's a distinction to make.
> +    (description
> +     "This package provides functions for tokenizing Japanese text
> in
> +Emacs buffers.")
> +    (license license:bsd-3)))

Cheers




^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#72632: [PATCH] gnu: Add emacs-tinysegmenter.
  2024-08-15  3:05 [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter Spencer King
  2024-08-15  3:17 ` [bug#72632] (no subject) Spencer King
  2024-08-15  5:50 ` [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter Liliana Marie Prikler
@ 2024-08-20  8:26 ` Nicolas Goaziou via Guix-patches via
  2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-08-20  8:26 UTC (permalink / raw)
  To: Spencer King; +Cc: 72632-done

Hello,

Spencer King <spencer@nursiapress.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-tinysegmenter): New variable.

I applied the patch with the changes suggested by Liliana. Thank you.

Regards,
-- 
Nicolas Goaziou






^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-08-20  8:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-15  3:05 [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter Spencer King
2024-08-15  3:17 ` [bug#72632] (no subject) Spencer King
2024-08-15  5:50 ` [bug#72632] [PATCH] gnu: Add emacs-tinysegmenter Liliana Marie Prikler
2024-08-20  8:26 ` bug#72632: " Nicolas Goaziou via Guix-patches via

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.