From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WJwnKhmN3GG1RAEAgWs5BA (envelope-from ) for ; Mon, 10 Jan 2022 20:46:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GJrkIhmN3GEceAAAG6o9tA (envelope-from ) for ; Mon, 10 Jan 2022 20:46:33 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 20B492ABE5 for ; Mon, 10 Jan 2022 20:46:33 +0100 (CET) Received: from localhost ([::1]:54854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n70ci-00089B-99 for larch@yhetil.org; Mon, 10 Jan 2022 14:46:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n70aH-0004yL-TA for guix-patches@gnu.org; Mon, 10 Jan 2022 14:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n70aH-0000mq-KZ for guix-patches@gnu.org; Mon, 10 Jan 2022 14:44:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n70aH-0007m5-IZ for guix-patches@gnu.org; Mon, 10 Jan 2022 14:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53163] [PATCH] doc: Document some reasons for/against git tags/commits. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 10 Jan 2022 19:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53163 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 53163@debbugs.gnu.org Received: via spool by 53163-submit@debbugs.gnu.org id=B53163.164184381229837 (code B ref 53163); Mon, 10 Jan 2022 19:44:01 +0000 Received: (at 53163) by debbugs.gnu.org; 10 Jan 2022 19:43:32 +0000 Received: from localhost ([127.0.0.1]:53343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n70Zo-0007lB-0e for submit@debbugs.gnu.org; Mon, 10 Jan 2022 14:43:32 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n70Zm-0007kx-3L for 53163@debbugs.gnu.org; Mon, 10 Jan 2022 14:43:30 -0500 Received: by mail-wm1-f67.google.com with SMTP id w26so3652291wmi.0 for <53163@debbugs.gnu.org>; Mon, 10 Jan 2022 11:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=qAJRJYIvK3lDmHxq3MitBqB/9VvGocC1oVjLNhV4Lv0=; b=QCr6TZCTTHY73HFk1ll5HazdZ2tWY1Z82rHYtsS/SICuIKS71DUXARD1Hp/hGlWJPA WyzYdmgoiFdiB6i4TEcxkcquIgYRItBSLYPkEz5tDf6bthrla+L5Ig0jqE4ugfcknjO5 gVQazjz66AbYbuVrU7oftEf9XXiqu/wNwusS9xf32fEoxR7E58e6qUYp6KEK6KLvf3Xd 7lBWZ3Aa3YlxWGxnxdliPW5ZImZuJGk7MvuCCt/emIlVoLaUndB0uGbEhgiJl3TI9sAQ /jXTKI3crUF680PdBxnkdtNXEwXnpqZ3CuFMygyi/1YRUXq/dch7ph1fBec6Bw57S+LC eewg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=qAJRJYIvK3lDmHxq3MitBqB/9VvGocC1oVjLNhV4Lv0=; b=Wa4R2A+SXmLm2fxvYnUvGvu64fAikxnXqvl+rUrbcXBqOHG1DFWm+JiDevRUiBkzAl RKal4xP4cI7ZsCXI9K9zwMeKbjUQ7UOMelAAxLOScIiMBY0Mbdha+hHdOZFxqjwGiMTg RFvWMOdqZtsbJkF+59VQaHqFEsgMG6vkn6m9a9/psaQEkGzJpWZay2WRsn6aAPZFpwiJ ts/yLdnvsRUCCdLkO4LB4T2GEv68TmPdZ6DM8rpXx8mvPZFMNLnsWj8V78jFMr/W2DHN /ED/FaJjcGuucwELFiWInOdc9krssQoFw5uyuIxOuDS7if1I0MtN/zNSsnUdiFUEGVLq MR5A== X-Gm-Message-State: AOAM533BXlt6W0Sk/i8ulxgSHb2GkTZmlTQ5YnXQbMmk7aN2Nn4nfugL 70YxaagWe/D+vL/UyGUBJ04= X-Google-Smtp-Source: ABdhPJzUmEjkD9wAtPyhOhtQn/owBX68k1W2zLQWxvJ9tKSPazfnT+YYSzPNaMjFoXEGdFmUI8ZOFg== X-Received: by 2002:a7b:cf2b:: with SMTP id m11mr5360918wmg.153.1641843804142; Mon, 10 Jan 2022 11:43:24 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id e13sm2588585wrw.3.2022.01.10.11.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 11:43:23 -0800 (PST) Message-ID: <3aeda438471930ca3b958a35681a8191cc51fe92.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 10 Jan 2022 20:43:22 +0100 In-Reply-To: <5623ec2b15bf60a51587b0592ad178b2bec3ef37.camel@telenet.be> References: <5623ec2b15bf60a51587b0592ad178b2bec3ef37.camel@telenet.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641843993; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qAJRJYIvK3lDmHxq3MitBqB/9VvGocC1oVjLNhV4Lv0=; b=Wh0UY/5RDNfX6mVQKBmvAjH6/7AZu+14nUTYiiyGzyZpJERUEV2eVWCwB4WV4b7wcFWMr4 adpuveJU9I3FCBLSIVFW75vWWSoWmZJSK2hTby1krxVXVvAvyCoaIWRTVmFMiOSpa+9pFD g4b5jxSq5c2HJkCoCRIkngQNGD/qSa7RwkPSomqk3zgo2Dc2dImRs8jziMf5IyaKhMkS3g EZy1SJW/wwRffyBnej1jGrCfbokUOc7shJhnzDXbD1kRmh9XFyhGOqGFSFVDGgCdxh2BaB mgi4PIVoHukPB77WXc8UKySTtCa/fjxiHGOIidiLIfebP+ZGFx5lKr8QAlBlmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641843993; a=rsa-sha256; cv=none; b=XkZ60tVsEeN4uWgTnomRonwT5lO7QvYSixxZR+VeEcc8iWEl5ftnfqxagR4d/IW2caWnfa lGf6cq+RnNwrARKNKrNnLSV83qienSMSH0lA8On8UMmXkrTBnbgEyGtgGYMxl5io2z3qSg Bxc5FNKKfJ1g36VlPqPBPkzNIcxnMKrx7TFhcW7tcE+yhmCajAwhk0ZgZ4NxTXxtFpvs8H O338S6J36aP7Hpd0qZ7l5mdEOvGHWe2FFgzgVkzPKrnT7CWNmuof/Iq1xhf2UadRegHU8E xK7Z0l357ijHmLXduRb9RtRi4Kz8C0HRMMu7FYppnrX2KgsXrjAxpIadio7caw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QCr6TZCT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.31 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=QCr6TZCT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 20B492ABE5 X-Spam-Score: -3.31 X-Migadu-Scanner: scn0.migadu.com X-TUID: vG5rEKR7FIgF Hi, Am Montag, dem 10.01.2022 um 15:27 +0000 schrieb Maxime Devos: > For , > I'd like to be able to reference some section (not specialised > for Minetest packages, instead more general) explaining when > and when not to use git tags/commits. Generally LGTM. > +not tag releases at all, in this case commits are unavoidable. In a > +very few cases (@pxref{Version Numbers}), Guix intentionally uses a "In a very few cases" looks like a typo. "In few cases" or "In some exceptional cases" would work well. > +Commits make reviewing somewhat trickier, because the reviewer has > to > +verify that that the commit actually corresponds to the package > version. I'd also add a line regarding the difficulty to verify that a commit did once belong to a tag as a future reader, but I'm not sure what exactly to advise here and how. In the particular case of minetest, we have an external map of "tags" to commits that can be queried, but for most repos I fear the tags would simply be lost to time. > I'm not familiar with "git describe", so the documentation > doesn't tell when to use "git describe"-style > tag-number of commits-commit strings. That's a general question that has not reached a conclusion yet. IIRC the goal was to make tags more robust by replacing them with git- describe like tags. This would also make it easier to port between revisioned commit and tagged one, since one would have to let-bind commit either way. Cheers