From: "Raghav Gururajan" <raghavgururajan@disroot.org>
To: guix-devel@gnu.org
Cc: "Mark H Weaver" <mhw@netris.org>,
"Tobias Geerinckx-Rice" <me@tobias.gr>,
"Léo Le Bouter" <lle-bout@zaclys.net>,
leo.prikler@student.tugraz.at, leo@famulari.name
Subject: Re: A "cosmetic changes" commit that removes security fixes
Date: Wed, 21 Apr 2021 23:45:10 +0000 [thread overview]
Message-ID: <3a6e8b4f8a73fefbcd853f11c2340d86@disroot.org> (raw)
In-Reply-To: <878s5b5lc5.fsf@nckx>
Hi All!
Sorry, I just saw this email and noticed its thread via web. I wasn't subscribed.
> Raghav, can you explain why you created that commit? What's the
> context & the goal? Why is it on current wip-gnome? What do you
> expect to happen to it?
The commit is not new. I cherry-picked from core-updates (993de472ed3dfe90e1c4110b6b910c1f74d243ff), which was pushed as a part of #42958.
>> "Signed-off-by: Léo Le Bouter <lle-bout@zaclys.net>"
>
> What does this line mean? Please explain in some detail.
The cherry-pick preserves the commit message.
P.S.
Please note that I stopped making cosmetic changes long ago. I explicitly mentioned in #42958, during review, that there are two *old* 'cosmetic changes' (glib and cairo) which I had to preserve so that I don't have to rework the succeeding patches. Please refer this message (https://issues.guix.gnu.org/42958#63).
Regards,
RG.
next prev parent reply other threads:[~2021-04-21 23:45 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 21:11 A "cosmetic changes" commit that removes security fixes Mark H Weaver
2021-04-21 21:24 ` Mark H Weaver
2021-04-21 22:22 ` Tobias Geerinckx-Rice
2021-04-21 23:45 ` Raghav Gururajan [this message]
2021-04-21 22:16 ` Leo Prikler
2021-04-21 22:52 ` Leo Famulari
-- strict thread matches above, loose matches on Subject: below --
2021-04-22 0:58 Raghav Gururajan
2021-04-22 2:41 ` Mark H Weaver
2021-04-22 3:17 ` Raghav Gururajan
2021-04-22 4:05 ` Raghav Gururajan
2021-04-22 4:33 ` Mark H Weaver
2021-04-22 5:02 ` Raghav Gururajan
2021-04-22 17:21 ` Mark H Weaver
2021-04-22 21:49 ` Raghav Gururajan
2021-04-24 8:09 ` Mark H Weaver
2021-04-30 0:58 ` aviva
2021-04-22 18:37 ` Leo Famulari
2021-04-22 18:48 ` Mark H Weaver
2021-04-22 21:50 ` Raghav Gururajan
2021-04-22 4:08 ` Mark H Weaver
2021-04-22 11:39 ` 宋文武
2021-04-22 13:28 ` Mark H Weaver
2021-04-22 20:01 ` Léo Le Bouter
2021-04-22 21:08 ` Christopher Baines
2021-04-22 21:09 ` Leo Prikler
2021-04-22 21:21 ` Mark H Weaver
2021-04-23 17:52 ` Maxim Cournoyer
2021-04-23 18:00 ` Raghav Gururajan
2021-04-23 18:38 ` Maxim Cournoyer
2021-04-23 22:06 ` Raghav Gururajan
2021-04-23 18:50 ` Léo Le Bouter
2021-04-23 19:15 ` Leo Prikler
2021-04-23 19:18 ` Leo Famulari
2021-04-23 19:33 ` Léo Le Bouter
2021-04-23 20:12 ` Leo Famulari
2021-04-26 17:06 ` Giovanni Biscuolo
2021-04-26 17:32 ` Leo Famulari
2021-04-26 21:56 ` Giovanni Biscuolo
2021-04-26 23:01 ` Leo Famulari
2021-04-24 7:46 ` Mark H Weaver
2021-04-26 14:59 ` Léo Le Bouter
2021-04-26 15:23 ` Tobias Geerinckx-Rice
2021-04-26 17:21 ` Ludovic Courtès
2021-04-26 20:07 ` Pjotr Prins
2021-04-26 17:46 ` Léo Le Bouter
2021-04-28 15:52 ` Marius Bakke
2021-04-29 9:13 ` Léo Le Bouter
2021-04-29 11:46 ` Leo Prikler
2021-04-29 11:57 ` Léo Le Bouter
2021-04-29 11:41 ` Arun Isaac
2021-04-29 12:44 ` Pierre Neidhardt
2021-04-29 14:14 ` Pjotr Prins
2021-04-30 17:40 ` Pierre Neidhardt
2021-04-30 19:56 ` Pjotr Prins
2021-05-01 7:23 ` Arun Isaac
2021-05-01 12:40 ` Pjotr Prins
2021-05-01 9:15 ` Pierre Neidhardt
2021-05-01 10:18 ` Yasuaki Kudo
2021-05-03 7:18 ` Pierre Neidhardt
2021-05-01 14:50 ` Giovanni Biscuolo
2021-05-03 7:25 ` Pierre Neidhardt
2021-05-04 2:18 ` Bengt Richter
2021-05-04 6:55 ` Pierre Neidhardt
2021-05-04 15:43 ` Ludovic Courtès
2021-05-06 17:18 ` Pierre Neidhardt
2021-04-29 16:21 ` Arun Isaac
2021-04-26 19:31 ` Léo Le Bouter
2021-04-27 18:10 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a6e8b4f8a73fefbcd853f11c2340d86@disroot.org \
--to=raghavgururajan@disroot.org \
--cc=guix-devel@gnu.org \
--cc=leo.prikler@student.tugraz.at \
--cc=leo@famulari.name \
--cc=lle-bout@zaclys.net \
--cc=me@tobias.gr \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.