From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id SEkLIuhsmWXGkgAAkFu2QA (envelope-from ) for ; Sat, 06 Jan 2024 16:08:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SFUhHuhsmWUNtQAAqHPOHw (envelope-from ) for ; Sat, 06 Jan 2024 16:08:24 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=bLlGW3fj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704553704; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=8n2Mi/o5/4BGcdBmVZjjjCdkB7YRrRMfJc/E4oPAeYY=; b=G+Jse8IqMldXpJI/5kUqgK70aItgjCUGvWELQKxvqu1xuBJS11rTATMd0gd5CsZ9N6E42g aUlGySzwTcHonZs/bi0XdR1XrgpuLI16Q+1dgOh/xpzgll2/gT7baaJ9rTpx78F9zov4B3 Mxw7BB84ksvqe5KWVN0vKaGUc+Ieqj4ewgeoQspZBm1IS185mhV0EoiI5yNoJsaFGTrtez Dz/7sh1r/6LYG0/2fz7dcZWZ+gtfxYcdI00Dd3Wem2YkcEO+8Jn4drVjud/N0drlO3xlsW CFNKfncbN/HDwHdjAejIrexNqZQgIDRfYWd4tthhIhkgnbNLcDdBT669gf4KNQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704553704; a=rsa-sha256; cv=none; b=SkcGyatPrtDcGc2kCOWmpVF0w31HoE2ah1oBoE5shD/86099wGAGOh+IFmuRKdJKdxsgK5 cPCOK/RY0UJsOfjc535LwhbJjx4SvUwmJWXSysLVX2RVPJR3AAjUfCw3AylGHnFBCATuiG 7AS2PrLm8R8pf1U0ytznF2m7aNj8OSewBoXinAdSHgtpOmocFkQYRaqeq4voi3bR2Ynz43 W5bIzWriq2fVL9rpJvd3PUxbhLwoGeu4OsNFB3G4ZqPs1ZOtDzxSmlp3GltQq2D9Cz7Ne3 Qo9fp9xv0jpBFCSuTxalRcg1kmv+YlV90cOog6XYXx2RMILfSLXpVV4R84iZ/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=soeren-tempel.net header.s=opensmtpd header.b=bLlGW3fj; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=soeren-tempel.net (policy=none) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5F74E24A00 for ; Sat, 6 Jan 2024 16:08:24 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rM8HW-000419-8t; Sat, 06 Jan 2024 10:08:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rM8HH-0003yX-Au for guix-patches@gnu.org; Sat, 06 Jan 2024 10:07:59 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rM8HF-0005vX-Qp for guix-patches@gnu.org; Sat, 06 Jan 2024 10:07:58 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rM8HK-00046y-Q5 for guix-patches@gnu.org; Sat, 06 Jan 2024 10:08:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67896] [PATCH] gnu: ghc-9.2: Make Cabal respect GHC_PACKAGE_PATH Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 06 Jan 2024 15:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67896 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Lars-Dominik Braun Cc: 67896@debbugs.gnu.org Received: via spool by 67896-submit@debbugs.gnu.org id=B67896.170455364215723 (code B ref 67896); Sat, 06 Jan 2024 15:08:02 +0000 Received: (at 67896) by debbugs.gnu.org; 6 Jan 2024 15:07:22 +0000 Received: from localhost ([127.0.0.1]:60129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rM8Gf-00045W-Uw for submit@debbugs.gnu.org; Sat, 06 Jan 2024 10:07:22 -0500 Received: from magnesium.8pit.net ([45.76.88.171]:21759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rM8Gc-00045K-LU for 67896@debbugs.gnu.org; Sat, 06 Jan 2024 10:07:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=opensmtpd; bh=8n2Mi/o5/4 BGcdBmVZjjjCdkB7YRrRMfJc/E4oPAeYY=; h=in-reply-to:references:from: subject:cc:to:date; d=soeren-tempel.net; b=bLlGW3fjOfp6LUydIGIZlhM8Ex3 iGKCrwjK+fjCioRJ01vq2Vn7mcnALQ8yFhkKWtCMtFN89XGdlH/jMrnMbQPfnnWIOg2G6H WWr9OvvwJR/rxOb5JdmiYaNB1UPK37MeZYPIG3/mgaopjLuuf8FO/5+4bv8Dt5Svn8tkQN bgFA= Received: from localhost (dynamic-2a02-3102-49da-001b-3b7d-d1ac-1e16-7275.310.pool.telefonica.de [2a02:3102:49da:1b:3b7d:d1ac:1e16:7275]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id e911015a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES); Sat, 6 Jan 2024 16:07:10 +0100 (CET) Date: Sat, 06 Jan 2024 16:07:05 +0100 From: =?UTF-8?Q?S=C3=B6ren?= Tempel References: <3K6E1L1WLK573.223FCVRGQCGWL@8pit.net> In-Reply-To: Message-Id: <3ELNY2F2SV7KX.2JFO7970OJNKU@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.19 X-Spam-Score: -5.19 X-Migadu-Queue-Id: 5F74E24A00 X-Migadu-Scanner: mx12.migadu.com X-TUID: IgzH2whs94do Hi, Lars-Dominik Braun wrote: > sorry for the delay, I just tried your patch and it works well combining > a local cabal project and libraries/GHC from Guix. I=E2=80=99d say this i= s a > massive improvement, so I=E2=80=99d like to ship it with Guix. However th= is > is a world rebuilding change, so I=E2=80=99ll push it to the haskell-team= > branch and probably wait for #67921 to be ready before it can hit master.= Yea, glad to hear that. Waiting for #67921 is fine by me. Should I also prepare a patch for the GHC 9.4 package then? Currently this is only GHC 9.2. > One minor issue: If you add a patch file, also add it to gnu/local.mk. Oh, I wasn't aware. Thanks for pointing that out, will keep it in mind for future patches! > > However, given that Setup.hs also uses > > Distribution.Simple and that there are several places in Guix itself > > where we need to unset GHC_PACKAGE_PATH atm, I personally believe it > > to be preferable to fix the vendored version. >=20 > Which locations are you referring to? I just grep'ed for GHC_PACKAGE_PATH, e.g.: * https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/virtualizati= on.scm#n784 * https://git.savannah.gnu.org/cgit/guix.git/tree/guix/build/haskell-build-= system.scm#n111 * https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/haskell.scm#= n963 Greetings S=C3=B6ren