From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2JcIK4oUvmEJcgAAgWs5BA (envelope-from ) for ; Sat, 18 Dec 2021 18:04:10 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2FvsJYoUvmG7EwAAbx9fmQ (envelope-from ) for ; Sat, 18 Dec 2021 17:04:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 68A9127BDB for ; Sat, 18 Dec 2021 18:04:10 +0100 (CET) Received: from localhost ([::1]:45324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1myd7x-0007dG-JW for larch@yhetil.org; Sat, 18 Dec 2021 12:04:09 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1myd5u-0005lr-Tr for guix-patches@gnu.org; Sat, 18 Dec 2021 12:02:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60373) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1myd5u-0007X8-Kd for guix-patches@gnu.org; Sat, 18 Dec 2021 12:02:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1myd5u-0004wx-H1 for guix-patches@gnu.org; Sat, 18 Dec 2021 12:02:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 20/45] guix: node-build-system: Add implicit libuv input. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Dec 2021 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 51838@debbugs.gnu.org Cc: Timothy Sample , Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.163984687418967 (code B ref 51838); Sat, 18 Dec 2021 17:02:02 +0000 Received: (at 51838) by debbugs.gnu.org; 18 Dec 2021 17:01:14 +0000 Received: from localhost ([127.0.0.1]:43684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd58-0004vr-6f for submit@debbugs.gnu.org; Sat, 18 Dec 2021 12:01:14 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1myd56-0004vP-Sa for 51838@debbugs.gnu.org; Sat, 18 Dec 2021 12:01:13 -0500 Received: by mail-wr1-f65.google.com with SMTP id r17so10009975wrc.3 for <51838@debbugs.gnu.org>; Sat, 18 Dec 2021 09:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=gykgJNfUFopVnMk7CnfulvVGn7ZHciaiQSrEVXeks18=; b=Cw5VccFEBHE4SNjtow9BD1H2Ow76n1cyHThZp6T8/lz+qXTBxxAWwofoM9wdHqkoAI kLjjE03HVNBE+WcSFk0gRAEFm5zsnyt0lpngXEtJxSupmX+cXAiL4iUM0vbybbXhBrRN Mp9vZ8kQ4RimPVPLMZ3a07X5wWzhUI2B1fn6/2qVjUaNIn96UhtrrL2e2Pw+DBzmypo/ U40YjwIxNHrAvLukCr+1w+3ulB0ncWrzVAClwbUnNlN7Wb9QE4u+1UBqC5mgIhSsI6vk lbaWZTZgYFtR3KAFJ3r2tg25Fa/1V+ip+WFLR6Ehu2V2/DNJ4i64TfQqEETgqm00CQpI vfSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=gykgJNfUFopVnMk7CnfulvVGn7ZHciaiQSrEVXeks18=; b=S8XeCGX6tMrEPkMPfpwcdUvpENV9xI81jh1lFKJfbHiNC293U0t7oK1uFt3N5xrxTp rrpeVDLvv6BnBcddNyynxwlrRHMGqZahpJXdS+eOeelTrEFTzyjCH3REc3CA3cb0VtV6 9lR1tGCV+0vAB+y5eTTWLD8fduX70jZsl5pS1PlMZ1svWpY2a4hSW0/NiFjE+ofFdXxB 6bXZoQ+CXpFPsV5KTjxLfN2s9OlGg1rjk7v41e0kln7JhelXNoeUB7qzpDXMpLVDMzAX OfWbEasHWU7suTGDWohx3gYvBGkimxQYf5EigjCTrOycUMI/z9mjQ2kAXQbcVFUBPYze Z90w== X-Gm-Message-State: AOAM530bGfE0ySyZ7APOlgOMW5xoB666IYh3B2Zlxl0MNNoIC1upJz9Z X52U34soNCxgGQQwjenBVME= X-Google-Smtp-Source: ABdhPJyGrmp4IcwO2+01bP/WWW7Bm5pDTPr/Z/q6FsuSr74t1OiY61JJm59LxPcfHbJAiiNlk6aEtA== X-Received: by 2002:adf:9d8c:: with SMTP id p12mr6715278wre.622.1639846866881; Sat, 18 Dec 2021 09:01:06 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id u10sm14435952wrs.99.2021.12.18.09.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Dec 2021 09:01:06 -0800 (PST) Message-ID: <39f8ce0c54d60adb54c1bb9035ff1b31d40cb5be.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 18 Dec 2021 18:01:04 +0100 In-Reply-To: References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-21-philip@philipmcgrath.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639847050; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gykgJNfUFopVnMk7CnfulvVGn7ZHciaiQSrEVXeks18=; b=TvvW1f28ZVP8sa7ZGPxSubqluK8FL+TigWlXu/L1rkjCIYdnG0F+OZj4e5Aq0Z2i+YMabz 7ZYpLmg66i5drwtJw/7pTzd5vuQYEZGj8UCllWW4RFz5yg2PagF5BVyHXAYKNwW3GKZpG4 48priCNjuCFMUA6RHAtHn78X0efcH3fQCKRZgwAi2UFtO23UKXCEt+G0LUcCISyMQ88RGZ gdz6qHaui1PPiQ41Vkn00iwuqZdkpLTAkkifrX8Pr32qqzxaw5nisA/+AFn0CLKAvxwfQ+ 7E5I2YctRXy8cenws+Mjm1BZNozmnxNtnClsuA+kB7fVDmQe9E/8SGXBY2Eb0w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639847050; a=rsa-sha256; cv=none; b=MtWKd//0AKpOV54nqSB6+ILj+LcArMKHzi2a3HgagJ8omNbMqIgOQcXE1Ydz8mba5T2YLT xEswW5bm6QJmTmoJFJjTs8+cKTxRgBxtqM1t1WSCt+MbMw/S2ql/K9UDliZH2ex15PRUHw YQAh2okk+kVokvXWoysJBVyV5NkaBdQKp3XfHHSRaT/kX01Zq5rKSH04amE/vmZUyKAE+T 6UzqHrKrSaiM3uzbLxB6QTvrgaplYZ3wpoFdc3uLJhHqfvCIbjMR2kugRffwohaUZmRSMC Ymq7++RADMGfPToCUR9STVggQOXQ16Dfn1kuthMRQt8sd6BGcpaT6MU0SW7z+A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Cw5VccFE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=Cw5VccFE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 68A9127BDB X-Spam-Score: -2.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: hEw32eN8tibd Hi, Am Samstag, dem 18.12.2021 um 11:16 -0500 schrieb Philip McGrath: > > > > Do this and #21 have to be separated so far from the rest?  If not, > > I'd do build system first, then new packages.  Otherwise fair > > enough. > > I tried to follow Tim's suggestion in > to put the changes related to > #:absent-dependencies before the changes to support native addons, so > that the earlier changes could potentially be applied even if there > was more discussion needed for the later ones (if #:absent- > dependencies were less controversial. Fair enough, that does make sense. However, I do think that "add package X" is not too big of a review burden, so I personally think the fact we're deleting 'configure everywhere is holding back the change to support native addons rather than the other way around. > But note that the patches before this one aren't adding new packages; > they are changing existing packages to use #:absent-dependencies > rather than deleting the configure phase. So the series is ordered > overall as: > >   1. Changes to the `node` package itself >   2. Build system changes for #:absent-dependencies >      (including the delete-lockfiles phase, because un-deleting the >      configure phase exposes those problems) >   3. Packages changes to use #:absent-dependencies >   4. Build system changes to support native addons >   5. New packages to exercise the support for native addons There is an unspoken bit here in #5 in that those packages still need to get rid of unwanted dependencies, which makes this set still unsplittable in a sense. If everyone else here agrees, I think we could at least upstream the changes to node itself while we still discuss 2-5. Timothy, Pierre, Jelle, WDYT?