From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH] gnu: Add ghc-hscolour. Date: Thu, 22 Oct 2015 11:48:46 -0500 Message-ID: <39f20f93e013ed811a2a4aa41f9fada6@openmailbox.org> References: <1445483479-19104-1-git-send-email-ericbavier@openmailbox.org> <1445503671-30014-1-git-send-email-ericbavier@openmailbox.org> <1445503671-30014-5-git-send-email-ericbavier@openmailbox.org> <87twpjorus.fsf@denknerd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpJ33-00005s-7O for guix-devel@gnu.org; Thu, 22 Oct 2015 12:49:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpJ30-0004Mq-0K for guix-devel@gnu.org; Thu, 22 Oct 2015 12:49:05 -0400 Received: from smtp3.openmailbox.org ([62.4.1.37]:46443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpJ2z-0004Ln-QJ for guix-devel@gnu.org; Thu, 22 Oct 2015 12:49:01 -0400 In-Reply-To: <87twpjorus.fsf@denknerd.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Paul van der Walt Cc: guix-devel@gnu.org On 2015-10-22 10:17, Paul van der Walt wrote: > On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org: >>> +(define-public ghc-hscolour >>> + (package >>> + (name "ghc-hscolour") >> >> I would suggest we name this package "hscolour" because it is >> primarily >> program or tool. > > Indeed, i have renamed it. > >> It also has libraries; perhaps those could be put in a "lib" >> output? WDYT? > > Maybe i should be less lazy (surely we can forgive that in the context > of Haskell), but to be perfectly frank, i'd just love to get these > patches off my plate. Given that the Guix behaviour mirrors the Cabal > behaviour for this package (that is, it's installed, or not) i think > it's fine. But indeed i am not the most pedantic person here. > > I will defer to your better judgement, but for now i've only changed > the > package name. Seems fair. We can revisit later if need be. Thanks for sticking out the review. -- `~Eric