From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Subject: Re: [PATCH 2/3] gnu: Add python-pyxb.
Date: Tue, 20 Sep 2016 16:34:15 +1000
Message-ID: <39d81c47-a96d-1f1c-ad1d-a80e7b7f109d@uq.edu.au>
References: <20160917101047.4597-1-mbakke@fastmail.com>
	<20160917101047.4597-3-mbakke@fastmail.com>
	<3bd16b58-b3d1-d47c-2433-c3a721681463@uq.edu.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59721)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bmEdT-0005JB-50
	for guix-devel@gnu.org; Tue, 20 Sep 2016 02:34:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bmEdQ-0007ly-2h
	for guix-devel@gnu.org; Tue, 20 Sep 2016 02:34:31 -0400
Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:35475
	helo=newmailhub.uq.edu.au) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <b.woodcroft@uq.edu.au>) id 1bmEdP-0007ky-FR
	for guix-devel@gnu.org; Tue, 20 Sep 2016 02:34:28 -0400
In-Reply-To: <3bd16b58-b3d1-d47c-2433-c3a721681463@uq.edu.au>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>, "guix-devel@gnu.org" <guix-devel@gnu.org>

Oops, forgot to cc the list.


On 20/09/16 16:02, Ben Woodcroft wrote:
> Hi Marius,
>
> Thanks for the patches.
>
> On 17/09/16 20:10, Marius Bakke wrote:
>> [..]
>> +         (add-after 'unpack 'fix-tests
>> +           (lambda _
>> +             ;; See https://github.com/pabigot/pyxb/issues/26 ...
>> +             (delete-file "tests/trac/test-trac-0091.py")
>
> The fix for that test failing seems straightforward enough, might be 
> better to include as a patch so those tests are run.
> https://github.com/pabigot/pyxb/commit/d4bdd5a1c712cd70f96264ae13b55d015cbf3335 
>
>
>> +             ;; ...and https://github.com/pabigot/pyxb/pull/58 .
>> +             (substitute* "tests/utils/test-utility.py"
>> +               (("__NoExt_re = re.compile.*$")
>> +                "__NoExt_re = re.compile('(^|\\%s)[^\\.]+$' % 
>> os.sep)\n"))
>
> Good catch there. It would be preferable to add this change as a patch 
> as well, because it is more likely to apply correctly (not that it 
> won't here), and also because when it is no longer needed after this 
> package gets updated the patch will fail to apply alerting the updater 
> to the fact it should be removed. As a bonus, my experience is that 
> working with patches easier than using substitute* so require less 
> builds before getting to a happy package.
>
> I have not actually built these packages, but they look fine 
> otherwise. Would you mind sending an updated patch for pyxb, and then 
> I'll probably apply all three (assuming I find nothing else, which I 
> don't anticipate).
>
> Thanks,
> ben