all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / Atom feed
* [bug#48953] [PATCH v1 00/03]: Improve Dino
@ 2021-06-11  1:00 Raghav Gururajan via Guix-patches via
  2021-06-11  1:01 ` [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
                   ` (4 more replies)
  0 siblings, 5 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-11  1:00 UTC (permalink / raw)
  To: 48953


[-- Attachment #1.1: Type: text/plain, Size: 2 bytes --]



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs.
  2021-06-11  1:00 [bug#48953] [PATCH v1 00/03]: Improve Dino Raghav Gururajan via Guix-patches via
@ 2021-06-11  1:01 ` Raghav Gururajan via Guix-patches via
  2021-06-11  1:01   ` [bug#48953] [PATCH v1 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
  2021-06-11  1:01   ` [bug#48953] [PATCH v1 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  2021-06-11  1:15 ` [bug#48953] [PATCH v2 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
                   ` (3 subsequent siblings)
  4 siblings, 2 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-11  1:01 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Remove duplicate gpgme,
gtk+, glib-networking and gsettings-desktop-schemas.
---
 gnu/packages/messaging.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 7b91284b10..d85577e76c 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1260,11 +1260,7 @@ Encryption to Gajim.")
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)
-       ("gpgme" ,gpgme)
-       ("gtk+" ,gtk+)
-       ("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+       ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.31.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v1 2/3] gnu: dino: Add missing inputs.
  2021-06-11  1:01 ` [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-11  1:01   ` Raghav Gururajan via Guix-patches via
  2021-06-11  1:01   ` [bug#48953] [PATCH v1 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-11  1:01 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

These new inputs are referenced by the package but was missing in
the package definition. Some of these inputs might have been used
by the package indirectly via propagation from other inputs.

* gnu/packages/messaging.scm (dino)[native-inputs]: Add gobject-introspection.
[inputs]: Add atk, cairo, gdk-pixbug+svg, libcanberra, libnice and pango.
---
 gnu/packages/messaging.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index d85577e76c..5be733f3a2 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1246,19 +1246,26 @@ Encryption to Gajim.")
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
        ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
-     `(("glib" ,glib)
+     `(("atk" ,atk)
+       ("cairo" ,cairo)
+       ("gdk-pixbuf" ,gdk-pixbuf+svg)
+       ("glib" ,glib)
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
+       ("libcanberra" ,libcanberra)
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
+       ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
-- 
2.31.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v1 3/3] gnu: dino: Enable missing features.
  2021-06-11  1:01 ` [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  2021-06-11  1:01   ` [bug#48953] [PATCH v1 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
@ 2021-06-11  1:01   ` Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-11  1:01 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Add gspell, gstreamer,
gst-plugins-base, gst-plugins-good, icu4c, libsrtp and
webrtc-audio-processing.
---
 gnu/packages/messaging.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 5be733f3a2..e9d2c26902 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -114,6 +114,7 @@
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages tcl)
+  #:use-module (gnu packages telephony)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils)
   #:use-module (gnu packages tls)
@@ -1258,16 +1259,23 @@ Encryption to Gajim.")
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gspell" ,gspell)               ; for spell-check support
+       ("gstreamer" ,gstreamer)         ; for A/V support
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gst-plugins-good" ,gst-plugins-good)
        ("gtk+" ,gtk+)
+       ("icu4c" ,icu4c)                 ; for emoji support
        ("libcanberra" ,libcanberra)
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
        ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ("libsrtp" ,libsrtp)             ; for calls support
        ("pango" ,pango)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)))
+       ("sqlite" ,sqlite)
+       ("webrtc-audio-processing" ,webrtc-audio-processing))) ; for A/V support
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.31.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 1/3] gnu: dino: Remove duplicate inputs.
  2021-06-11  1:00 [bug#48953] [PATCH v1 00/03]: Improve Dino Raghav Gururajan via Guix-patches via
  2021-06-11  1:01 ` [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-11  1:15 ` Raghav Gururajan via Guix-patches via
  2021-06-11  1:15   ` [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
  2021-06-11  1:15   ` [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  2021-06-16  7:17 ` [bug#48953] [PATCH v3 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
                   ` (2 subsequent siblings)
  4 siblings, 2 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-11  1:15 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Remove duplicate gpgme,
gtk+, glib-networking and gsettings-desktop-schemas.
---
 gnu/packages/messaging.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 7b91284b10..d85577e76c 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1260,11 +1260,7 @@ Encryption to Gajim.")
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)
-       ("gpgme" ,gpgme)
-       ("gtk+" ,gtk+)
-       ("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+       ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.31.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs.
  2021-06-11  1:15 ` [bug#48953] [PATCH v2 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-11  1:15   ` Raghav Gururajan via Guix-patches via
  2021-06-11  3:31     ` Jack Hill
  2021-06-11  1:15   ` [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  1 sibling, 1 reply; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-11  1:15 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

These new inputs are referenced by the package but was missing in
the package definition. Some of these inputs might have been used
by the package indirectly via propagation from other inputs.

* gnu/packages/messaging.scm (dino)[native-inputs]: Add gobject-introspection.
[inputs]: Add atk, cairo, gdk-pixbug+svg, libcanberra, libnice and pango.
---
 gnu/packages/messaging.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index d85577e76c..5be733f3a2 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1246,19 +1246,26 @@ Encryption to Gajim.")
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
        ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
-     `(("glib" ,glib)
+     `(("atk" ,atk)
+       ("cairo" ,cairo)
+       ("gdk-pixbuf" ,gdk-pixbuf+svg)
+       ("glib" ,glib)
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
+       ("libcanberra" ,libcanberra)
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
+       ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
-- 
2.31.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features.
  2021-06-11  1:15 ` [bug#48953] [PATCH v2 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  2021-06-11  1:15   ` [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
@ 2021-06-11  1:15   ` Raghav Gururajan via Guix-patches via
  2021-06-11  3:35     ` Jack Hill
  1 sibling, 1 reply; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-11  1:15 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[phases](wrap-env): New phase.
[inputs]: Add gspell, gstreamer, gst-plugins-base, gst-plugins-good,
icu4c, libsrtp and webrtc-audio-processing.
---
 gnu/packages/messaging.scm | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 5be733f3a2..41f26ba8e0 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -114,6 +114,7 @@
   #:use-module (gnu packages sphinx)
   #:use-module (gnu packages sqlite)
   #:use-module (gnu packages tcl)
+  #:use-module (gnu packages telephony)
   #:use-module (gnu packages texinfo)
   #:use-module (gnu packages textutils)
   #:use-module (gnu packages tls)
@@ -1241,6 +1242,17 @@ Encryption to Gajim.")
                            (guix build glib-or-gtk-build-system))
        #:phases
        (modify-phases %standard-phases
+         (add-after 'install 'wrap-env
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((out (assoc-ref outputs "out")))
+               (for-each
+                (lambda (name)
+                  (let ((file (string-append out "/bin/" name))
+                        (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+                    (wrap-program file
+                      `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))
+                '("dino")))
+             #t))
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (native-inputs
@@ -1258,16 +1270,23 @@ Encryption to Gajim.")
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gspell" ,gspell)               ; for spell-check support
+       ("gstreamer" ,gstreamer)         ; for A/V support
+       ("gst-plugins-base" ,gst-plugins-base)
+       ("gst-plugins-good" ,gst-plugins-good)
        ("gtk+" ,gtk+)
+       ("icu4c" ,icu4c)                 ; for emoji support
        ("libcanberra" ,libcanberra)
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
        ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ("libsrtp" ,libsrtp)             ; for calls support
        ("pango" ,pango)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)))
+       ("sqlite" ,sqlite)
+       ("webrtc-audio-processing" ,webrtc-audio-processing))) ; for A/V support
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.31.1





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs.
  2021-06-11  1:15   ` [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
@ 2021-06-11  3:31     ` Jack Hill
  2021-06-11 15:06       ` Jack Hill
  2021-06-17  0:17       ` Raghav Gururajan via Guix-patches via
  0 siblings, 2 replies; 21+ messages in thread
From: Jack Hill @ 2021-06-11  3:31 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 48953

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Thu, 10 Jun 2021, Raghav Gururajan via Guix-patches via wrote:

> These new inputs are referenced by the package but was missing in
> the package definition. Some of these inputs might have been used
> by the package indirectly via propagation from other inputs.

Cool, thanks for working on improving Dino.

> * gnu/packages/messaging.scm (dino)[native-inputs]: Add gobject-introspection.
> [inputs]: Add atk, cairo, gdk-pixbug+svg, libcanberra, libnice and pango.
> ---
> gnu/packages/messaging.scm | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index d85577e76c..5be733f3a2 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm

[…]

> +       ("libcanberra" ,libcanberra)

I think canberra support is disabled by default even if the dependency is 
present. I found the following configure-flags enable it:

#:configure-flags (list "-DDINO_PLUGIN_ENABLED_notification-sound=yes")

Now I'm curious to find out from upstream why it's not enabled by default 
and if that should affect whether we enable it in Guix.

Best,
Jack

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features.
  2021-06-11  1:15   ` [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
@ 2021-06-11  3:35     ` Jack Hill
  2021-06-17  0:19       ` Raghav Gururajan via Guix-patches via
  0 siblings, 1 reply; 21+ messages in thread
From: Jack Hill @ 2021-06-11  3:35 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 48953

[-- Attachment #1: Type: text/plain, Size: 2083 bytes --]

On Thu, 10 Jun 2021, Raghav Gururajan via Guix-patches via wrote:

> * gnu/packages/messaging.scm (dino)[phases](wrap-env): New phase.
> [inputs]: Add gspell, gstreamer, gst-plugins-base, gst-plugins-good,
> icu4c, libsrtp and webrtc-audio-processing.
> ---
> gnu/packages/messaging.scm | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
> index 5be733f3a2..41f26ba8e0 100644
> --- a/gnu/packages/messaging.scm
> +++ b/gnu/packages/messaging.scm
> @@ -114,6 +114,7 @@
>   #:use-module (gnu packages sphinx)
>   #:use-module (gnu packages sqlite)
>   #:use-module (gnu packages tcl)
> +  #:use-module (gnu packages telephony)
>   #:use-module (gnu packages texinfo)
>   #:use-module (gnu packages textutils)
>   #:use-module (gnu packages tls)
> @@ -1241,6 +1242,17 @@ Encryption to Gajim.")
>                            (guix build glib-or-gtk-build-system))
>        #:phases
>        (modify-phases %standard-phases
> +         (add-after 'install 'wrap-env
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (for-each
> +                (lambda (name)
> +                  (let ((file (string-append out "/bin/" name))
> +                        (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
> +                    (wrap-program file
> +                      `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))))
> +                '("dino")))
> +             #t))

Nitpick of a sort: Can we forgo the #t with the (hopefully soon) 
upcoming core-updates merge?

[…]

> +       ("gspell" ,gspell)               ; for spell-check support
> +       ("gstreamer" ,gstreamer)         ; for A/V support
> +       ("gst-plugins-base" ,gst-plugins-base)
> +       ("gst-plugins-good" ,gst-plugins-good)

[…]

> +       ("webrtc-audio-processing" ,webrtc-audio-processing))) ; for A/V support

Is there actual A/V support in this version of Dino, or is that only 
coming in 0.3.0?

Best,
Jack

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs.
  2021-06-11  3:31     ` Jack Hill
@ 2021-06-11 15:06       ` Jack Hill
  2021-06-17  0:17       ` Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Jack Hill @ 2021-06-11 15:06 UTC (permalink / raw)
  To: Raghav Gururajan; +Cc: 48953

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On Thu, 10 Jun 2021, Jack Hill wrote:

> On Thu, 10 Jun 2021, Raghav Gururajan via Guix-patches via wrote:
>
>> +       ("libcanberra" ,libcanberra)
>
> I think canberra support is disabled by default even if the dependency is 
> present. I found the following configure-flags enable it:
>
> #:configure-flags (list "-DDINO_PLUGIN_ENABLED_notification-sound=yes")
>
> Now I'm curious to find out from upstream why it's not enabled by default and 
> if that should affect whether we enable it in Guix.

I asked about this in Dino's chat room⁰ and they said that the 
notification-sound plugin is not ready to be enabled by distros¹.

⁰ <xmpp:chat@dino.im?join>
¹ https://github.com/dino/dino/issues/578#issuecomment-581863288

Best,
Jack

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v3 1/3] gnu: dino: Remove duplicate inputs.
  2021-06-11  1:00 [bug#48953] [PATCH v1 00/03]: Improve Dino Raghav Gururajan via Guix-patches via
  2021-06-11  1:01 ` [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  2021-06-11  1:15 ` [bug#48953] [PATCH v2 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-16  7:17 ` Raghav Gururajan via Guix-patches via
  2021-06-16  7:17   ` [bug#48953] [PATCH v3 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
  2021-06-16  7:17   ` [bug#48953] [PATCH v3 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  2021-06-16  7:19 ` [bug#48953] [PATCH v4 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  2021-06-17  0:20 ` [bug#48953] [PATCH v5 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  4 siblings, 2 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-16  7:17 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Remove duplicate gpgme,
gtk+, glib-networking and gsettings-desktop-schemas.
---
 gnu/packages/messaging.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 499b7a8f3a..0f9fe31772 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1260,11 +1260,7 @@ Encryption to Gajim.")
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)
-       ("gpgme" ,gpgme)
-       ("gtk+" ,gtk+)
-       ("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+       ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v3 2/3] gnu: dino: Add missing inputs.
  2021-06-16  7:17 ` [bug#48953] [PATCH v3 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-16  7:17   ` Raghav Gururajan via Guix-patches via
  2021-06-16  7:17   ` [bug#48953] [PATCH v3 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-16  7:17 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

These new inputs are referenced by the package but was missing in
the package definition. Some of these inputs might have been used
by the package indirectly via propagation from other inputs.

* gnu/packages/messaging.scm (dino)[native-inputs]: Add gobject-introspection.
[inputs]: Add atk, cairo, gdk-pixbug+svg, libnice and pango.
---
 gnu/packages/messaging.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 0f9fe31772..54d09c4815 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1246,19 +1246,25 @@ Encryption to Gajim.")
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
        ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
-     `(("glib" ,glib)
+     `(("atk" ,atk)
+       ("cairo" ,cairo)
+       ("gdk-pixbuf" ,gdk-pixbuf+svg)
+       ("glib" ,glib)
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
+       ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v3 3/3] gnu: dino: Enable missing features.
  2021-06-16  7:17 ` [bug#48953] [PATCH v3 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  2021-06-16  7:17   ` [bug#48953] [PATCH v3 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
@ 2021-06-16  7:17   ` Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-16  7:17 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Add gspell and icu4c.
---
 gnu/packages/messaging.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 54d09c4815..c526b7a91a 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1241,6 +1241,14 @@ Encryption to Gajim.")
                            (guix build glib-or-gtk-build-system))
        #:phases
        (modify-phases %standard-phases
+         ;; To be enabled in v0.3.0, for A/V support.
+         ;;(add-after 'install 'wrap
+           ;;(lambda* (#:key outputs #:allow-other-keys)
+             ;;(let* ((out (assoc-ref outputs "out"))
+                    ;;(dino (string-append out "/bin/dino"))
+                    ;;(gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+               ;;(wrap-program dino
+                 ;;`("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))))))
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (native-inputs
@@ -1251,6 +1259,7 @@ Encryption to Gajim.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
+     ;; NOTE: Commented-out lines are to be enabled in v0.3.0.
      `(("atk" ,atk)
        ("cairo" ,cairo)
        ("gdk-pixbuf" ,gdk-pixbuf+svg)
@@ -1258,15 +1267,23 @@ Encryption to Gajim.")
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gspell" ,gspell)               ;for spell-check support
+       ;;("gstreamer" ,gstreamer)         ;for A/V support
+       ;;("gst-plugins-base" ,gst-plugins-base)
+       ;;("gst-plugins-good" ,gst-plugins-good)
        ("gtk+" ,gtk+)
+       ("icu4c" ,icu4c)                 ;for emoji support
+       ("libcanberra" ,libcanberra)    ;for sound-notification support
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
        ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ;;("libsrtp" ,libsrtp)             ;for calls support
        ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
+       ;;("webrtc-audio-processing" ,webrtc-audio-processing))) ;for A/V support
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v4 1/3] gnu: dino: Remove duplicate inputs.
  2021-06-11  1:00 [bug#48953] [PATCH v1 00/03]: Improve Dino Raghav Gururajan via Guix-patches via
                   ` (2 preceding siblings ...)
  2021-06-16  7:17 ` [bug#48953] [PATCH v3 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-16  7:19 ` Raghav Gururajan via Guix-patches via
  2021-06-16  7:19   ` [bug#48953] [PATCH v4 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
  2021-06-16  7:19   ` [bug#48953] [PATCH v4 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  2021-06-17  0:20 ` [bug#48953] [PATCH v5 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  4 siblings, 2 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-16  7:19 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Remove duplicate gpgme,
gtk+, glib-networking and gsettings-desktop-schemas.
---
 gnu/packages/messaging.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 499b7a8f3a..0f9fe31772 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1260,11 +1260,7 @@ Encryption to Gajim.")
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)
-       ("gpgme" ,gpgme)
-       ("gtk+" ,gtk+)
-       ("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+       ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v4 2/3] gnu: dino: Add missing inputs.
  2021-06-16  7:19 ` [bug#48953] [PATCH v4 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-16  7:19   ` Raghav Gururajan via Guix-patches via
  2021-06-16  7:19   ` [bug#48953] [PATCH v4 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-16  7:19 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

These new inputs are referenced by the package but was missing in
the package definition. Some of these inputs might have been used
by the package indirectly via propagation from other inputs.

* gnu/packages/messaging.scm (dino)[native-inputs]: Add gobject-introspection.
[inputs]: Add atk, cairo, gdk-pixbug+svg, libnice and pango.
---
 gnu/packages/messaging.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 0f9fe31772..54d09c4815 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1246,19 +1246,25 @@ Encryption to Gajim.")
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
        ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
-     `(("glib" ,glib)
+     `(("atk" ,atk)
+       ("cairo" ,cairo)
+       ("gdk-pixbuf" ,gdk-pixbuf+svg)
+       ("glib" ,glib)
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
+       ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v4 3/3] gnu: dino: Enable missing features.
  2021-06-16  7:19 ` [bug#48953] [PATCH v4 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  2021-06-16  7:19   ` [bug#48953] [PATCH v4 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
@ 2021-06-16  7:19   ` Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-16  7:19 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Add gspell and icu4c.
---
 gnu/packages/messaging.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 54d09c4815..eb4fc5436c 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1241,6 +1241,14 @@ Encryption to Gajim.")
                            (guix build glib-or-gtk-build-system))
        #:phases
        (modify-phases %standard-phases
+         ;; To be enabled in v0.3.0, for A/V support.
+         ;;(add-after 'install 'wrap
+           ;;(lambda* (#:key outputs #:allow-other-keys)
+             ;;(let* ((out (assoc-ref outputs "out"))
+                    ;;(dino (string-append out "/bin/dino"))
+                    ;;(gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+               ;;(wrap-program dino
+                 ;;`("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))))))
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (native-inputs
@@ -1251,6 +1259,7 @@ Encryption to Gajim.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
+     ;; NOTE: Commented-out lines are to be enabled in v0.3.0.
      `(("atk" ,atk)
        ("cairo" ,cairo)
        ("gdk-pixbuf" ,gdk-pixbuf+svg)
@@ -1258,15 +1267,23 @@ Encryption to Gajim.")
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gspell" ,gspell)               ;for spell-check support
+       ;;("gstreamer" ,gstreamer)         ;for A/V support
+       ;;("gst-plugins-base" ,gst-plugins-base)
+       ;;("gst-plugins-good" ,gst-plugins-good)
        ("gtk+" ,gtk+)
+       ("icu4c" ,icu4c)                 ;for emoji support
+       ;;("libcanberra" ,libcanberra)    ;for sound-notification support
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
        ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ;;("libsrtp" ,libsrtp)             ;for calls support
        ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
+       ;;("webrtc-audio-processing" ,webrtc-audio-processing))) ;for A/V support
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs.
  2021-06-11  3:31     ` Jack Hill
  2021-06-11 15:06       ` Jack Hill
@ 2021-06-17  0:17       ` Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-17  0:17 UTC (permalink / raw)
  To: Jack Hill; +Cc: 48953


[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]

Hi Jackhill!

> I think canberra support is disabled by default even if the dependency 
> is present. I found the following configure-flags enable it:
> 
> #:configure-flags (list "-DDINO_PLUGIN_ENABLED_notification-sound=yes")
> 
> Now I'm curious to find out from upstream why it's not enabled by 
> default and if that should affect whether we enable it in Guix.

Ah thanks! I have moved this to 3rd patch, for enabling it in v0.3.0 update.

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features.
  2021-06-11  3:35     ` Jack Hill
@ 2021-06-17  0:19       ` Raghav Gururajan via Guix-patches via
  0 siblings, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-17  0:19 UTC (permalink / raw)
  To: Jack Hill; +Cc: 48953


[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]

Hi Jackhill!

> Nitpick of a sort: Can we forgo the #t with the (hopefully soon) 
> upcoming core-updates merge?

I just kept that around for testing. Will be removing it in final patch.

> Is there actual A/V support in this version of Dino, or is that only 
> coming in 0.3.0?

Oh no no. It is meant to be commented, for enabling it in v0.3.0 
release. I sent the wrong patch. The correct one is in v4.

Regards,
RG.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v5 1/3] gnu: dino: Remove duplicate inputs.
  2021-06-11  1:00 [bug#48953] [PATCH v1 00/03]: Improve Dino Raghav Gururajan via Guix-patches via
                   ` (3 preceding siblings ...)
  2021-06-16  7:19 ` [bug#48953] [PATCH v4 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-17  0:20 ` Raghav Gururajan via Guix-patches via
  2021-06-17  0:20   ` [bug#48953] [PATCH v5 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
  2021-06-17  0:20   ` [bug#48953] [PATCH v5 3/3] gnu: dino: Enable some features Raghav Gururajan via Guix-patches via
  4 siblings, 2 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-17  0:20 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino)[inputs]: Remove duplicate gpgme,
gtk+, glib-networking and gsettings-desktop-schemas.
---
 gnu/packages/messaging.scm | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 499b7a8f3a..0f9fe31772 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1260,11 +1260,7 @@ Encryption to Gajim.")
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
        ("qrencode" ,qrencode)
-       ("sqlite" ,sqlite)
-       ("gpgme" ,gpgme)
-       ("gtk+" ,gtk+)
-       ("glib-networking" ,glib-networking)
-       ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
+       ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v5 2/3] gnu: dino: Add missing inputs.
  2021-06-17  0:20 ` [bug#48953] [PATCH v5 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
@ 2021-06-17  0:20   ` Raghav Gururajan via Guix-patches via
  2021-06-17  0:20   ` [bug#48953] [PATCH v5 3/3] gnu: dino: Enable some features Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-17  0:20 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

These new inputs are referenced by the package but was missing in
the package definition. Some of these inputs might have been used
by the package indirectly via propagation from other inputs.

* gnu/packages/messaging.scm (dino)[native-inputs]: Add gobject-introspection.
[inputs]: Add atk, cairo, gdk-pixbug+svg, libnice and pango.
---
 gnu/packages/messaging.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 0f9fe31772..54d09c4815 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1246,19 +1246,25 @@ Encryption to Gajim.")
     (native-inputs
      `(("gettext" ,gettext-minimal)
        ("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
        ("gtk+:bin" ,gtk+ "bin")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
-     `(("glib" ,glib)
+     `(("atk" ,atk)
+       ("cairo" ,cairo)
+       ("gdk-pixbuf" ,gdk-pixbuf+svg)
+       ("glib" ,glib)
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
        ("gtk+" ,gtk+)
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
+       ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

* [bug#48953] [PATCH v5 3/3] gnu: dino: Enable some features.
  2021-06-17  0:20 ` [bug#48953] [PATCH v5 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
  2021-06-17  0:20   ` [bug#48953] [PATCH v5 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
@ 2021-06-17  0:20   ` Raghav Gururajan via Guix-patches via
  1 sibling, 0 replies; 21+ messages in thread
From: Raghav Gururajan via Guix-patches via @ 2021-06-17  0:20 UTC (permalink / raw)
  To: 48953; +Cc: Raghav Gururajan

* gnu/packages/messaging.scm (dino): Add comments for v0.3.0 release.
[inputs]: Add gspell and icu4c.
---
 gnu/packages/messaging.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 54d09c4815..eb4fc5436c 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1241,6 +1241,14 @@ Encryption to Gajim.")
                            (guix build glib-or-gtk-build-system))
        #:phases
        (modify-phases %standard-phases
+         ;; To be enabled in v0.3.0, for A/V support.
+         ;;(add-after 'install 'wrap
+           ;;(lambda* (#:key outputs #:allow-other-keys)
+             ;;(let* ((out (assoc-ref outputs "out"))
+                    ;;(dino (string-append out "/bin/dino"))
+                    ;;(gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
+               ;;(wrap-program dino
+                 ;;`("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path))))))
          (add-after 'install 'glib-or-gtk-wrap
            (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap)))))
     (native-inputs
@@ -1251,6 +1259,7 @@ Encryption to Gajim.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (inputs
+     ;; NOTE: Commented-out lines are to be enabled in v0.3.0.
      `(("atk" ,atk)
        ("cairo" ,cairo)
        ("gdk-pixbuf" ,gdk-pixbuf+svg)
@@ -1258,15 +1267,23 @@ Encryption to Gajim.")
        ("glib-networking" ,glib-networking)
        ("gpgme" ,gpgme)
        ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+       ("gspell" ,gspell)               ;for spell-check support
+       ;;("gstreamer" ,gstreamer)         ;for A/V support
+       ;;("gst-plugins-base" ,gst-plugins-base)
+       ;;("gst-plugins-good" ,gst-plugins-good)
        ("gtk+" ,gtk+)
+       ("icu4c" ,icu4c)                 ;for emoji support
+       ;;("libcanberra" ,libcanberra)    ;for sound-notification support
        ("libgcrypt" ,libgcrypt)
        ("libgee" ,libgee)
        ("libnice" ,libnice)
        ("libsignal-protocol-c" ,libsignal-protocol-c)
        ("libsoup" ,libsoup)
+       ;;("libsrtp" ,libsrtp)             ;for calls support
        ("pango" ,pango)
        ("qrencode" ,qrencode)
        ("sqlite" ,sqlite)))
+       ;;("webrtc-audio-processing" ,webrtc-audio-processing))) ;for A/V support
     (synopsis "Graphical Jabber/XMPP Client using GTK+/Vala")
     (description "Dino is a chat client for the desktop.  It focuses on providing
 a minimal yet reliable Jabber/XMPP experience and having encryption enabled by
-- 
2.32.0





^ permalink raw reply	[flat|nested] 21+ messages in thread

end of thread, other threads:[~2021-06-17  0:23 UTC | newest]

Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-11  1:00 [bug#48953] [PATCH v1 00/03]: Improve Dino Raghav Gururajan via Guix-patches via
2021-06-11  1:01 ` [bug#48953] [PATCH v1 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-11  1:01   ` [bug#48953] [PATCH v1 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-11  1:01   ` [bug#48953] [PATCH v1 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-11  1:15 ` [bug#48953] [PATCH v2 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-11  1:15   ` [bug#48953] [PATCH v2 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-11  3:31     ` Jack Hill
2021-06-11 15:06       ` Jack Hill
2021-06-17  0:17       ` Raghav Gururajan via Guix-patches via
2021-06-11  1:15   ` [bug#48953] [PATCH v2 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-11  3:35     ` Jack Hill
2021-06-17  0:19       ` Raghav Gururajan via Guix-patches via
2021-06-16  7:17 ` [bug#48953] [PATCH v3 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:17   ` [bug#48953] [PATCH v3 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:17   ` [bug#48953] [PATCH v3 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-16  7:19 ` [bug#48953] [PATCH v4 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:19   ` [bug#48953] [PATCH v4 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-16  7:19   ` [bug#48953] [PATCH v4 3/3] gnu: dino: Enable missing features Raghav Gururajan via Guix-patches via
2021-06-17  0:20 ` [bug#48953] [PATCH v5 1/3] gnu: dino: Remove duplicate inputs Raghav Gururajan via Guix-patches via
2021-06-17  0:20   ` [bug#48953] [PATCH v5 2/3] gnu: dino: Add missing inputs Raghav Gururajan via Guix-patches via
2021-06-17  0:20   ` [bug#48953] [PATCH v5 3/3] gnu: dino: Enable some features Raghav Gururajan via Guix-patches via

all messages for Guix-related lists mirrored at yhetil.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/guix

Example config snippet for mirrors.


AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git