From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Alexandru-Sergiu Marton <brown121407@posteo.ro>, 47447@debbugs.gnu.org
Subject: [bug#47447] [PATCH] gnu: Add entt.
Date: Sun, 28 Mar 2021 12:44:35 +0200 [thread overview]
Message-ID: <37142ad6f109e441c543540408997a2353812565.camel@student.tugraz.at> (raw)
In-Reply-To: <20210328100322.31991-1-brown121407@posteo.ro>
Am Sonntag, den 28.03.2021, 13:03 +0300 schrieb Alexandru-Sergiu
Marton:
> * gnu/packages/cpp.scm (entt): New variable.
> (entt-fixed-tests): New variable.
> ---
> gnu/packages/cpp.scm | 51
> +++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 50 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
> index 2a00d3838a..449b4c1c06 100644
> --- a/gnu/packages/cpp.scm
> +++ b/gnu/packages/cpp.scm
> @@ -18,7 +18,7 @@
> ;;; Copyright © 2020 Brett Gilio <brettg@gnu.org>
> ;;; Copyright © 2020 Milkey Mouse <milkeymouse@meme.institute>
> ;;; Copyright © 2021 Raghav Gururajan <rg@raghavgururajan.name>
> -
> +;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407@posteo.ro>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -57,6 +57,7 @@
> #:use-module (gnu packages curl)
> #:use-module (gnu packages documentation)
> #:use-module (gnu packages gcc)
> + #:use-module (gnu packages graphviz)
> #:use-module (gnu packages libevent)
> #:use-module (gnu packages libunwind)
> #:use-module (gnu packages linux)
> @@ -1211,3 +1212,51 @@ of reading and writing XML.")
> ;; incompatible with the GPL v2. Refer to the file named FLOSSE
> for the
> ;; details.
> (license license:gpl2+)))
> +
> +;; TODO: Make public and remove the fix below when the next release
> comes and
> +;; fixes the failing tests.
> +(define entt
> + (package
> + (name "entt")
> + (version "3.6.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/skypjack/entt")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "17w0gx6xah8j2d1kc6ly7a8jvkp4jspmn505w724hynlvlx1192
> x"))))
> + (build-system cmake-build-system)
> + (arguments
> + `(#:configure-flags (list "-DENTT_BUILD_TESTING=ON"
> + "-DENTT_FIND_GTEST_PACKAGE=ON"
> + "-DENTT_BUILD_DOCS=ON")))
> + (native-inputs
> + `(("googletest" ,googletest)
> + ("doxygen" ,doxygen) ; These two packages are needed for
> + ("graphviz" ,graphviz))) ; generating the documentation.
> + (synopsis "Fast and reliable entity component system (ECS)")
> + (description "EnTT is a header-only, tiny and easy to use
> library for game
> +programming and much more written in modern C++.")
Please cut down on the marketing buzzwords :)
> + (home-page "https://github.com/skypjack/entt")
> + (license (list license:expat ; for the code
> + license:cc-by4.0)))) ; for the docs
> +
> +(define-public entt-fixed-tests
> + ;; This commit fixes two tests that are failing on the 3.6.0
> version.
> + (let ((commit "14915368c7d4fa87e944cb55ffae1bb88cc6ef4c")
> + (revision "1"))
> + (package
> + (inherit entt)
> + (name "entt")
> + (version (git-version "v3.6.0" revision commit))
> + (source (origin
> + (inherit (package-source entt))
> + (uri (git-reference
> + (url "https://github.com/skypjack/entt")
> + (commit commit)))
> + (sha256
> + (base32
> + "1amlr4amj94xnmbdz94292vfkxbl92azsr5s41vcqqjmarwkk
> hfh")))))))
Would it be possible to cherry-pick this commit and add it to the
patches field of entt's origin?
Regards,
Leo
next prev parent reply other threads:[~2021-03-28 10:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-28 10:03 [bug#47447] [PATCH] gnu: Add entt Alexandru-Sergiu Marton
2021-03-28 10:44 ` Leo Prikler [this message]
2021-03-31 18:18 ` Alexandru-Sergiu Marton
2021-04-07 11:15 ` [bug#47447] [PATCH v2] " Alexandru-Sergiu Marton
2021-04-07 11:46 ` bug#47447: " Leo Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37142ad6f109e441c543540408997a2353812565.camel@student.tugraz.at \
--to=leo.prikler@student.tugraz.at \
--cc=47447@debbugs.gnu.org \
--cc=brown121407@posteo.ro \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.