From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Vollmert Subject: Re: 01/01: guix: node-build-system: Use guile-json instead of a custom parser. Date: Sun, 14 Jul 2019 20:27:32 +0200 Message-ID: <371096AF-FCE7-4A1B-935B-12BEA303BF59@vllmrt.net> References: <20190714125820.15568.58684@vcs0.savannah.gnu.org> <20190714125821.1CA192088F@vcs0.savannah.gnu.org> <87blxw68f8.fsf@gnu.org> <20190714201918.6794a007@sybil.lepiller.eu> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:50132) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmjDt-0006Vb-O9 for guix-devel@gnu.org; Sun, 14 Jul 2019 14:27:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmjDs-0001Zo-QW for guix-devel@gnu.org; Sun, 14 Jul 2019 14:27:45 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:39514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hmjDs-0001Xa-Ih for guix-devel@gnu.org; Sun, 14 Jul 2019 14:27:44 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2.mailbox.org (Postfix) with ESMTPS id C9FE1A016C for ; Sun, 14 Jul 2019 20:27:40 +0200 (CEST) Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id 7mhA0Pa8GSFI for ; Sun, 14 Jul 2019 20:27:32 +0200 (CEST) In-Reply-To: <20190714201918.6794a007@sybil.lepiller.eu> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org On 14. Jul 2019, at 20:19, Julien Lepiller wrote: >=20 > Le Sun, 14 Jul 2019 15:40:43 +0200, > Ludovic Court=C3=A8s a =C3=A9crit : >> The effect of this change is to import the (json parser) from the = host >> side into the build side. >>=20 >> As a result, if I have installed Guile-JSON 1.2 and you have >> Guile-JSON 3.1, we=E2=80=99ll end up building different derivations = (and one >> of them won=E2=80=99t build :-)). >>=20 >> The solution here would be to do the equivalent of = =E2=80=98with-extensions=E2=80=99 >> for gexps. >>=20 >> However, given that that=E2=80=99s annoying to do without gexps, and = given >> that the plan is to move build systems to gexps Real Soon, I=E2=80=99d = be in >> favor of simply reverting this commit and using the custom JSON >> parser. We can add a TODO/FIXME explaining that we=E2=80=99ll = replace it >> with Guile-JSON as soon as build systems are rewritten to use gexps. >>=20 >> How does that sound? >>=20 >> Apologies if I overlooked it in your initial patch submission! >>=20 >> Thank you, >> Ludo=E2=80=99. >=20 > OK, sorry for pushing this patch then... I've reverted it in > a4bb18921099b2ec8c1699e08a73ca0fa78d0486. Thanks for the explanation! It=E2=80=99s a bit my fault, for remarking on the fact that the cargo = build system does use guile-json. I suppose that=E2=80=99s not worth fixing = either at this point? Cheers Robert