From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-patches-bounces+larch=yhetil.org@gnu.org>
Received: from mp0.migadu.com ([2001:41d0:303:e224::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms13.migadu.com with LMTPS
	id kIdlCgvnQmdw8AAAqHPOHw:P1
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 24 Nov 2024 08:42:51 +0000
Received: from aspmx1.migadu.com ([2001:41d0:303:e224::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0.migadu.com with LMTPS
	id kIdlCgvnQmdw8AAAqHPOHw
	(envelope-from <guix-patches-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Sun, 24 Nov 2024 09:42:51 +0100
X-Envelope-To: larch@yhetil.org
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TfjSlcUD;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MHNVkA6R;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1732437771; a=rsa-sha256; cv=none;
	b=SxbiHVUWkCbVzI3sWwMsBu/zw9wtj8Bv5EsFTqcuvTzlcwj30RX3yvAUBK+Y9tBhKWr0lG
	+RlYG74I/qoOsKIPFfbTmmsLptZpuGPzmZm2uxOysXNQPIQe7JeMh3/cZR84G5IgtTb8go
	2VfYzsQ/sT0kcSdjbCVyfUvci4O9pukBdy0dJI0aqQ+bWJuk+oFu1g+H0yk1/kVgtv7blo
	3UxD+F8YK1+NTw3a0ILIk+dIGAlbHOj1H4D4f1z++qJiNVmLe/AqDdlQxJhMcaApnlQM65
	2DzUJkpONzhQ3DBs1+AhebdgErs+xbUmyD1LKNdvp+IgDkzcVYE3p+KkPrTgFg==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=TfjSlcUD;
	dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=MHNVkA6R;
	dmarc=pass (policy=none) header.from=gnu.org;
	spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1732437771;
	h=from:from:sender:sender:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:resent-cc:
	 resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to:
	 references:references:list-id:list-help:list-unsubscribe:
	 list-subscribe:list-post:dkim-signature;
	bh=Qt95m4uKHM+54AY3ttIyfuvxneu8yjJgxxbpcdIZ4Bs=;
	b=OWRTVtosME2hOrGdqGBQNXUUEwGocfxj1wA3kdXhR0elBlCOYVY84fOWHfLgzlgvGkpXEr
	wuXpzQdjiAmuk4V2+JO2fXBkUbHSLFVI7e1TPqm5hkx+hy+YQyHF5D/JtYCr6o4ECTxnh5
	pYpprDJcPEnhMoe+fljoaC6d28h2AlKj/y4uUKIoOx5CdCFkE9gAyZglLfHL0dSuLDNXm+
	iuoGQ4bvHmUwjD6cU9ggud7uiPQbOd8LKfEQYZazrgwY0xVHgqz30bgiJ45NgFznx3psub
	wlXeQJ9t/j3iXxT72Kwrxg5ROoqAeSpc77wBHMScyRafBhRFHct5UYGBj4QmBg==
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id E959F4F6A
	for <larch@yhetil.org>; Sun, 24 Nov 2024 09:42:50 +0100 (CET)
Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-patches-bounces@gnu.org>)
	id 1tF7UP-0000Af-89; Sun, 24 Nov 2024 02:57:05 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1tF7UN-00009z-JV
 for guix-patches@gnu.org; Sun, 24 Nov 2024 02:57:03 -0500
Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1tF7UN-0002Jy-BB
 for guix-patches@gnu.org; Sun, 24 Nov 2024 02:57:03 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=debbugs.gnu.org; s=debbugs-gnu-org; 
 h=MIME-Version:References:In-Reply-To:Date:From:To:Subject;
 bh=Qt95m4uKHM+54AY3ttIyfuvxneu8yjJgxxbpcdIZ4Bs=; 
 b=TfjSlcUDAUlSxc4y8x36rBGwj/w/wn91/WfAkrXw5nC7slZ97Hc20U/obY1qHFZspmMI9yG5qBFS9hQNXOp+zGzVc9K2r6mC0isUSrBAQX/9QdTBEsQ8A2qRUxk6oA3AH1n+kZd34P+Y2O9TEEsNzBJTmnh//z/pbWWZajEp9H0ZV4DJn+l09zkU4JGGVKF/R2lSFibjrGLS18WIUcPuyLd6bXAV0isN9N6lihDH7zNDB/gxo9GdEfOfPScN9YdwU7B+OT0c20dWhO6qWk7MDdvoyKNBOGAqmQXZkfpJJBUj1puWh25LpUOXSS7rTll95CCoXWJB1F/Lg0Fwtqd2+A==;
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tF7UN-0004ex-5l
 for guix-patches@gnu.org; Sun, 24 Nov 2024 02:57:03 -0500
X-Loop: help-debbugs@gnu.org
Subject: [bug#74290] [PATCH v4 06/58] gnu: bash-minimal: Support [cross-]build
 with gcc-14.
Resent-From: Janneke Nieuwenhuizen <janneke@gnu.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: guix-patches@gnu.org
Resent-Date: Sun, 24 Nov 2024 07:57:03 +0000
Resent-Message-ID: <handler.74290.B74290.173243497117429@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 74290
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 74290@debbugs.gnu.org
Received: via spool by 74290-submit@debbugs.gnu.org id=B74290.173243497117429
 (code B ref 74290); Sun, 24 Nov 2024 07:57:03 +0000
Received: (at 74290) by debbugs.gnu.org; 24 Nov 2024 07:56:11 +0000
Received: from localhost ([127.0.0.1]:60667 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1tF7TW-0004Wy-Ur
 for submit@debbugs.gnu.org; Sun, 24 Nov 2024 02:56:11 -0500
Received: from eggs.gnu.org ([209.51.188.92]:37484)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <janneke@gnu.org>) id 1tF7TM-0004U1-85
 for 74290@debbugs.gnu.org; Sun, 24 Nov 2024 02:56:00 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <janneke@gnu.org>)
 id 1tF7TH-0001tn-27; Sun, 24 Nov 2024 02:55:55 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To:
 From; bh=Qt95m4uKHM+54AY3ttIyfuvxneu8yjJgxxbpcdIZ4Bs=; b=MHNVkA6Rb518Kpvbs8yz
 lIHWnJNxXiBx+lDTfNQ0StYEA9a9o234PQl4uItNIPg+oKOlUx2SAIL1v5ER18Em/kjfra4uEwG3M
 3X6/gxHJqP/QPoyOInrm19teUrSmDu+o2tS69BiInqNVyb+2xwc+DsWM91yWHjjEe2PCJPhlr/2HM
 gETHFK4SJmq1HphZ/S1z2Mf1sf0xrMarKzGArGAwSKaSZl/fTDisIE5W+LkVVuiAtv0aTg8s7Zp0L
 R2IdUzb0WAg3BnARNsD2XA1qs2X/pa9zC7Kvchl0G+XtPmaWSdYwqKawVEyilyqxzhQhrFSkXtchl
 qgplOqi1DZh3NA==;
From: Janneke Nieuwenhuizen <janneke@gnu.org>
Date: Sun, 24 Nov 2024 08:54:29 +0100
Message-ID: <36e7173c950cda9f0e4e2c2e207cb2cc92abc8c0.1732434271.git.janneke@gnu.org>
X-Mailer: git-send-email 2.46.0
In-Reply-To: <cover.1732434270.git.janneke@gnu.org>
References: <cover.1732434270.git.janneke@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: guix-patches@gnu.org
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org
Sender: guix-patches-bounces+larch=yhetil.org@gnu.org
X-Migadu-Flow: FLOW_IN
X-Migadu-Country: US
X-Migadu-Spam-Score: -3.53
X-Spam-Score: -3.53
X-Migadu-Queue-Id: E959F4F6A
X-Migadu-Scanner: mx12.migadu.com
X-TUID: AXU/mcW68B2L

* gnu/packages/bash-minimal.scm (bash)[arguments]: When building for the 64bit
hurd, or cross-building, use "CFLAGS=-g -O2 -Wno-implicit-function-declaration".

Change-Id: I1356c0aeac303bdf0254c28815716c83884008a0
---
 gnu/packages/bash.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm
index 93641a78d5..56918d79bd 100644
--- a/gnu/packages/bash.scm
+++ b/gnu/packages/bash.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2020 Zhu Zihao <all_but_last@163.com>
 ;;; Copyright © 2021 Marius Bakke <marius@gnu.org>
 ;;; Copyright © 2024 Oleg Pykhalov <go.wigust@gmail.com>
+;;; Copyright © 2024 Janneke Nieuwenhuizen <janneke@gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -251,6 +252,13 @@ (define-public bash-minimal
                ;; modules and related code.
                "ac_cv_func_dlopen=no"
 
+               ,@(if (or (target-hurd64?) (%current-target-system))
+                     ;; gcc-14 implictly uses -Wimplicit-function-declaration
+                     ;; which together with -Werror causes:
+                     ;; ./enable.def:492:11: error: implicit declaration of function ‘dlclose’;
+                     '("CFLAGS=-g -O2 -Wno-implicit-function-declaration")
+                     '())
+
                ,@(if (%current-target-system)
                      '("bash_cv_job_control_missing=no"
                        "bash_cv_getcwd_malloc=yes")
-- 
2.46.0