From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id CQoeFIj+5mGQBAAAgWs5BA (envelope-from ) for ; Tue, 18 Jan 2022 18:53:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EMv8CYj+5mHmWAAAG6o9tA (envelope-from ) for ; Tue, 18 Jan 2022 18:53:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D05C33EF93 for ; Tue, 18 Jan 2022 18:53:11 +0100 (CET) Received: from localhost ([::1]:45228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9sfO-0003Ip-Ud for larch@yhetil.org; Tue, 18 Jan 2022 12:53:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34670) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9sfH-0003CL-D6 for guix-patches@gnu.org; Tue, 18 Jan 2022 12:53:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:58689) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9sfH-0002Xh-1e for guix-patches@gnu.org; Tue, 18 Jan 2022 12:53:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9sfH-0008T3-0w for guix-patches@gnu.org; Tue, 18 Jan 2022 12:53:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53318] [PATCH] gnu: Add go-github-com-go-chi-chi-v5. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jan 2022 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53318 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?=E8=B7=AF=E8=BE=89?= Cc: 53318@debbugs.gnu.org Received: via spool by 53318-submit@debbugs.gnu.org id=B53318.164252832432429 (code B ref 53318); Tue, 18 Jan 2022 17:53:02 +0000 Received: (at 53318) by debbugs.gnu.org; 18 Jan 2022 17:52:04 +0000 Received: from localhost ([127.0.0.1]:51583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9seK-0008Qz-5A for submit@debbugs.gnu.org; Tue, 18 Jan 2022 12:52:04 -0500 Received: from michel.telenet-ops.be ([195.130.137.88]:46432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9seF-0008QM-8s for 53318@debbugs.gnu.org; Tue, 18 Jan 2022 12:52:02 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by michel.telenet-ops.be with bizsmtp id kHrw2600W4UW6Th06Hrx0m; Tue, 18 Jan 2022 18:51:57 +0100 Message-ID: <36129597cc215850f16001832244b76558e3f67c.camel@telenet.be> From: Maxime Devos Date: Tue, 18 Jan 2022 18:51:29 +0100 In-Reply-To: References: <60e7034e0b9170a2d36e4adafa5a9a3e9835cc17.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-wtH8ZezL4ohnQTlWgjwz" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1642528317; bh=SYu1HyH1BVZDVBA/tSjq14PcHmo1DeeLpW88qU0FuVo=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=kRlP0g+3oAC6WRQJ0UOAMOWc7NFYopSlFmgTPz5jErDL/Hi8las9e8yCfF1f8HUta +Tl3zUjvjXma3oosmSJgXT4XsO9TkegpXrgGuljCSXNBEg+5uklOYc0kJ8dN3AmEnQ tF5K4JHaB9nqb+rdNPkFy0YzyDuus13zmrRPfKMuIJLOyU5m2zt9Vkkt6VKU98qQYf 4QryShFjwCzG6l6KqTQa2EaCsDm0cKLCKVAqTBaEyfUQcxqR+4m/RdfjEgVQDMxiV8 dHwCRFnw4LPH3FNF8XDBeBbK15/3TM8me5hSKe7r9K4Dkhg1kCtC0/CAXaqTxHkldz PdmQlgy42oRtQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642528391; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=SYu1HyH1BVZDVBA/tSjq14PcHmo1DeeLpW88qU0FuVo=; b=IY7cgpkP31FAHjieOO/lH/dEXxK4kufh89LyjV0hsw5LKsqfrgSD9iKmE/eL3IFbeuKXIM O7p1sVjIb73JHYim3JDyYRDbTjdVj/qYMZjcpEwMD3ora6CgEsfSrzhue4mSFUfLouYmoK S54MG9RAMLvwndvhJucUdbwvB45dz5qEmFGzeqzwjo6GzcE4quOeRhT2NodDtWyWMbEAVb goog+pRe0RmOa1AUz6Uho+me4r0YZXTtFZY+pgsdFREb9pDUvi+4qeVhfr0NWp8eNplLsU z36AW9R92BXe6snrPuj4wRPMqSyfe7NVxVs0PvfGHrp+BULS1Y+g2wjvICuT8g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642528391; a=rsa-sha256; cv=none; b=TZo98q3sfaZtXMTT5xCjhVLQNAp2VknOu0a2JOeh8vbEbmYVancjYeW6mJeCyjapO/QaW3 Z0U7V3p5el09NPMz//45J4OOG+HkQSzXo7hy7voyDkJQKPBNSEIiqI6Slt5w+FeU1Eb3xr YMH4OFI39mdWcDf2HS/v6vnjQJ/8+XFn9mhOmBi0+eECjtNzvUsytaXT/AdSL+oxSaDH1R RJYwEpxk8/r1WlOmAjmzt6s5AlicuVjU4C7TywRf12zBI+OCt2+wF4fzYa2eLxUCSopR9H kHmdQaXqJUKzywtwUjv8P3U+567qEWq3cSz+LCqmnLuGgaf4B2UDLHY3084ycg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=kRlP0g+3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=kRlP0g+3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D05C33EF93 X-Spam-Score: -3.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: DxhswcGW5RJC --=-wtH8ZezL4ohnQTlWgjwz Content-Type: multipart/mixed; boundary="=-mnxm/nO9yEbHg/HHtIWh" --=-mnxm/nO9yEbHg/HHtIWh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Please keep debbugs in CC: or To: so other people know how the patch is progressing. =E8=B7=AF=E8=BE=89 schreef op di 18-01-2022 om 15:26 [+0000]: > OK, new patch: [...] I did the following checks: 1. [x] it builds 2. [x] "guix lint" shows no problems 3. [x] there doesn't appear to be any malware in the source code While doing (3), I noticed that the test code has a certificate =E2=80=98certs.pem=E2=80=99 and =E2=80=98key.pem=E2=80=99, which will expir= e eventually, which isn't good for long-term reproducibility (cf.=C2=A0https://issues.guix.gnu.org/44559). So in the adjusted package definition, I deleted the affected test =E2=80=98middleware/middleware_test.go=E2=80=99, 'testdata/cert.pem' and 'testdata/key.pem', see attachement. I also capitalised 'http' to 'HTTP' in the description. The description is a bit short but I don't have much of an idea how to improve it. Aside from that, it LGTM. Greetings, Maxime. --=-mnxm/nO9yEbHg/HHtIWh Content-Disposition: attachment; filename="chi.scm" Content-Transfer-Encoding: base64 Content-Type: text/x-scheme; name="chi.scm"; charset="UTF-8" KHVzZS1tb2R1bGVzIChndWl4IHBhY2thZ2VzKQoJICAgICAoZ3VpeCBnaXQtZG93bmxvYWQpCgkg ICAgIChndWl4IGJ1aWxkLXN5c3RlbSBnbykKCSAgICAgKChndWl4IGxpY2Vuc2VzKSAjOnByZWZp eCBsaWNlbnNlOikKCSAgICAgKGd1aXggZ2V4cCkpCgooZGVmaW5lLXB1YmxpYyBnby1naXRodWIt Y29tLWdvLWNoaS1jaGktdjUKICAocGFja2FnZQogICAobmFtZSAiZ28tZ2l0aHViLWNvbS1nby1j aGktY2hpLXY1IikKICAgKHZlcnNpb24gIjUuMC43IikKICAgKHNvdXJjZSAob3JpZ2luCiAgICAg ICAgICAgIChtZXRob2QgZ2l0LWZldGNoKQogICAgICAgICAgICAodXJpIChnaXQtcmVmZXJlbmNl CiAgICAgICAgICAgICAgICAgICh1cmwgImh0dHBzOi8vZ2l0aHViLmNvbS9nby1jaGkvY2hpIikK ICAgICAgICAgICAgICAgICAgKGNvbW1pdCAoc3RyaW5nLWFwcGVuZCAidiIgdmVyc2lvbikpKSkK ICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZpbGUtbmFtZSBuYW1lIHZlcnNpb24pKQogICAg ICAgICAgICAoc2hhMjU2CiAgICAgICAgICAgICAoYmFzZTMyCiAgICAgICAgICAgICAgIjByenJz eHo0eGowOTczYzZueGtsdnEydm1nMm03OTVzbmhrMjU4MzZpMGduZDFqbng3OWsiKSkKICAgICAg ICAgICAgOzsgVGhpcyBjZXJ0aWZpY2F0ZSB1c2VkIGJ5IHRlc3RzIHdpbGwgZXZlbnR1YWxseSBl eHBpcmUsCiAgICAgICAgICAgIDs7IHNvIHJlbW92ZSBpdCBhbmQgdGhlIHRlc3QgdGhhdCB1c2Vz IHRoaXMgY2VydGlmaWNhdGUKICAgICAgICAgICAgOzsgdG8gYXZvaWQgZnV0dXJlIGJ1aWxkIGZh aWx1cmVzLgogICAgICAgICAgICAoc25pcHBldAogICAgICAgICAgICAgI34oYmVnaW4KICAgICAg ICAgICAgICAgICAoZm9yLWVhY2ggZGVsZXRlLWZpbGUgJygidGVzdGRhdGEvY2VydC5wZW0iICJ0 ZXN0ZGF0YS9rZXkucGVtIiAibWlkZGxld2FyZS9taWRkbGV3YXJlX3Rlc3QuZ28iKSkpKSkpCiAg IChidWlsZC1zeXN0ZW0gZ28tYnVpbGQtc3lzdGVtKQogICAoYXJndW1lbnRzCiAgICAnKCM6aW1w b3J0LXBhdGggImdpdGh1Yi5jb20vZ28tY2hpL2NoaS92NSIpKQogICAoaG9tZS1wYWdlICJodHRw czovL2dpdGh1Yi5jb20vZ28tY2hpL2NoaSIpCiAgIChzeW5vcHNpcyAiQ29tcG9zYWJsZSByb3V0 ZXIgZm9yIEhUVFAgc2VydmljZXMgd3JpdHRlbiBpbiBHbyIpCiAgIChkZXNjcmlwdGlvbgogICAg IkBjb2Rle2dvLWdpdGh1Yi1jb20tZ28tY2hpLWNoaS12NX0gaXMgYSBIVFRQIHJvdXRlciB0aGF0 CmxldHMgeW91IGRlY29tcG9zZSByZXF1ZXN0IGhhbmRsaW5nIGludG8gbWFueSBzbWFsbGVyIGxh eWVycy4iKQogICAobGljZW5zZSBsaWNlbnNlOmV4cGF0KSkpCmdvLWdpdGh1Yi1jb20tZ28tY2hp LWNoaS12NQo= --=-mnxm/nO9yEbHg/HHtIWh-- --=-wtH8ZezL4ohnQTlWgjwz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYeb+IRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7gFtAP4tP2wBQjC8fW5lyCLjBDGd2UxH 4JIM+2h5L3X+fidqKwD9HJau+Bk15pxjbrZgJItJbLyMjnlkjYxiUTfQGWgZPgA= =XKkb -----END PGP SIGNATURE----- --=-wtH8ZezL4ohnQTlWgjwz--