From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OGHnBlMLmmKxMgAAbAwnHQ (envelope-from ) for ; Fri, 03 Jun 2022 15:23:31 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2AXkBlMLmmInfQAAauVa8A (envelope-from ) for ; Fri, 03 Jun 2022 15:23:31 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C9A673ABA9 for ; Fri, 3 Jun 2022 15:23:28 +0200 (CEST) Received: from localhost ([::1]:46936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nx7Gx-0004d0-IL for larch@yhetil.org; Fri, 03 Jun 2022 09:23:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41360) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx7GZ-0004J1-0T for guix-patches@gnu.org; Fri, 03 Jun 2022 09:23:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33412) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nx7GY-0006JH-O7 for guix-patches@gnu.org; Fri, 03 Jun 2022 09:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nx7GY-0004oF-G6 for guix-patches@gnu.org; Fri, 03 Jun 2022 09:23:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55774] [PATCH] gnu: quodlibet: Add dependencies for plugins to work. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Jun 2022 13:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55774 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Wamm K. D." Cc: 55774@debbugs.gnu.org Received: via spool by 55774-submit@debbugs.gnu.org id=B55774.165426254218422 (code B ref 55774); Fri, 03 Jun 2022 13:23:02 +0000 Received: (at 55774) by debbugs.gnu.org; 3 Jun 2022 13:22:22 +0000 Received: from localhost ([127.0.0.1]:55542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx7Fu-0004n4-Fk for submit@debbugs.gnu.org; Fri, 03 Jun 2022 09:22:22 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:54634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx7Fq-0004ms-Ob for 55774@debbugs.gnu.org; Fri, 03 Jun 2022 09:22:21 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LF3T35g6kz1LZ3N; Fri, 3 Jun 2022 15:22:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4LF3T35g6kz1LZ3N DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1654262535; bh=uQJoXFPaIj9B0B0uM0djtqFforSiWJ5Xg7j+6nUKKb0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=X2Vi2OWCamPnuGJgTN+EiOYlcgYV/dZ4koXLbePmHN9a4F8b8gkJSrojf2rQASWTQ SYEKe/39nZd11mv6SGZHpA/ehd7oQKbTHA+5gG+vBVjHnr6VkCrDb/CRq1y2rvHfRv Oij/443AG5pejb2Pxbi9vstnwZN7e2rXWHE/s/oc= Message-ID: <35c268b3ff822a5a6d5d6a81d46e3a9d15bfc1c9.camel@ist.tugraz.at> From: Liliana Marie Prikler Date: Fri, 03 Jun 2022 15:22:14 +0200 In-Reply-To: References: <5d389f5061f937d238b758b23c61c3621a519b9c.camel@ist.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Scanned-By: MIMEDefang 2.74 on 129.27.10.116 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654262609; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=uQJoXFPaIj9B0B0uM0djtqFforSiWJ5Xg7j+6nUKKb0=; b=imVRVtIeopnlNLhtdm6htXK3uUWULVlBdud63b3AQyHSONfNG5ay5R7VqOw+oEUJGJ9JHZ SsErG3h7TYbDLrAX1RlNAdp488f/C1WUckL+WWDzQESkz4HErcJgCDtSf3mEYRYpgFMtUF WL8SGznP+B1XzjV26zMBfMc+D43Olur08cDEKi9gPFh/KbXAfPBRuOthL7rAL7N+LLRs6s suIJkHINq5BCocZhDzkA3mTBZVyshzXiF0xr0Ut/T6vxj/mgt3qDA+bHEuuwPBAxrsGvPV RX0ApWgHHjqDYbYRmeshzrvRBEQvnswtmKxlVGp2fj1BrxcBej3yVboZ6lFOOQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654262609; a=rsa-sha256; cv=none; b=pNA2de5kbLU50TcTmxDjsqi+pbwMgtAP+K8MR2v+fl4sej4fpal8BcKfNKwUHEPJt0C9Ck lSP8/8IXMyAB262bo/wmm0P1INeR9U7ic6zypkroymOwAoh6FwN9Vjd43usoj52boztwxI M5RETQArRh73tbkTId+eA/CR0o2l4XZ3CPWEDGFdMfUyuKHAtk075SAp0+StbRHq8xG7sO I5oDlcLJvlmo2eK/E0f27psUV+tsHZI7ORpw6jfxGlDamSA9cfxLDcjcTUPx41Oy9XmGnz e7KbQUvyS2I2LqbTou3PIjjAXa1AIGdI3ARtAsSTVO4ko6cP6yd1QNRCMXuMwg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=X2Vi2OWC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.98 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=X2Vi2OWC; dmarc=fail reason="SPF not aligned (relaxed)" header.from=tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C9A673ABA9 X-Spam-Score: 6.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: qk7zpLGzMLna Am Freitag, dem 03.06.2022 um 08:13 -0500 schrieb Wamm K. D.: > > > YMMV, but it's better for inputs to be sorted alphabetically.  Use > > line > > comments to demarcate specific features, e.g.  > >   keybinder-3.0 ; keybindings outside of GNOME > >   gtksourceview ; undo, redo, multiline text fields > >   ... > > Don't forget the 79 character limit; when in doubt claim less > > features. > > If possible, try to line up the comments. > > Fair; I'll get those updated, as well. Yeah, I was trying to weigh > what to include vs. not but, due to the installation structure of > Guix, you wouldn't be able to use these features by just installing > the dependencies (leastwise, with just a naïve straightforward > install, when I tried) so I figured they were worth including, from > that perspective. Oh, you understood me wrongly. Do add all the inputs, but per input you might not have enough space to describe *all* that it enables, so if you run out of horizontal space, stick to the most useful features. > > Also, comments like "musicbrainz plugin needs python-musicbrainz" > > are not as informative as you'd think and can probably be dropped > > :) > > Haha; fair. While I could see repeating "musicbrainz" as being > repetitive, I was figuring it's easy to lose track that the > dependency was present specifically due to a plugin, for future > developers who might work on the package, and was mostly trying to > capture it was plugin-related. Thanks for pointing it out and I'll > that adjusted. IIUC much of quodlibet is actually just plugins, so future packagers looking into it shouldn't be too confused. Plus we aim for complete feature sets in pretty much everything except -minimal package variants :) Cheers