From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YP91IB2GGmLOWgAAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 20:57:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MNniHR2GGmKzugAA9RJhRA (envelope-from ) for ; Sat, 26 Feb 2022 20:57:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A17BEF20A for ; Sat, 26 Feb 2022 20:57:16 +0100 (CET) Received: from localhost ([::1]:40222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nO3Br-0002al-9P for larch@yhetil.org; Sat, 26 Feb 2022 14:57:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33680) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nO3Be-0002aE-Cr for guix-patches@gnu.org; Sat, 26 Feb 2022 14:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34231) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nO3Be-0003he-3r for guix-patches@gnu.org; Sat, 26 Feb 2022 14:57:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nO3Be-0007Dm-1C for guix-patches@gnu.org; Sat, 26 Feb 2022 14:57:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Feb 2022 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler , Liliana Marie Prikler Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Attila Lendvai , Malte Gerdes , raingloom Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.164590537527687 (code B ref 53878); Sat, 26 Feb 2022 19:57:01 +0000 Received: (at 53878) by debbugs.gnu.org; 26 Feb 2022 19:56:15 +0000 Received: from localhost ([127.0.0.1]:56361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO3At-0007CV-6S for submit@debbugs.gnu.org; Sat, 26 Feb 2022 14:56:15 -0500 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:50283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO3Ar-0007CH-BU for 53878@debbugs.gnu.org; Sat, 26 Feb 2022 14:56:13 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id E2A262B001FF; Sat, 26 Feb 2022 14:56:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 26 Feb 2022 14:56:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=/WrC8PomR8thek FJA8o1pM0qQZihzP2DUNTsgNTTV0A=; b=FuvLFzAxBcxROt0P0/hyEEoW+1ItG8 NbEglo3KrCPB1JlIftMtVhUlhQJB3fQ/hHf3omxXm2xlXglUAXlHGMHvj73nCJB+ 5oEOF27F9S8QyiQskswgb2oVuw+9uDxIZUBdqo/Cf2pqbb4WgSuxq2q3WiQcMOQj gEC9tY4Bf5GmRqkTZ34l688VmSEL6Fs7kEiTikmW/RMwBch0yIUZHnjc1fh/gGIc +LTrLk5FTizjJ3TZt2LlRT9b8RXVYVZKkOty4PiGekz9CNFcFa34r1y/dJ+7A6iC cMQplMPZPgIjlFtKeTY9vZOlN9faRr9Nk2HG7wrTA9bwdFARXH7w78uw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/WrC8PomR8thekFJA 8o1pM0qQZihzP2DUNTsgNTTV0A=; b=gKDe/hHJGQEcb5MChNZWLmaLuX+wxvvcE KTR7Md/YxEJq/1S36AOmTro4baKFRXWNdqyCtEIkj3C07ZQsABdlLRgMgArJbqzY M4NJJXOl6lztv2qvIW2VQsF7WqUmeS1Njs8TkD0PZDG5HiEi8gSHPfU7EQKJLCCo ewOk7HKqtPF8XdJ2VeOJ7JDme11ns6+fYxUnFgfRBXcqNMr6IBrbGhYMs3A+jCWt 9X3kHo++QxljbwbWTfDbNnrMY/bGD84Mzx84VvN7GVkVl+PThLMy3Um/I09XaPaz PJl8/dQnORVw3CgbcmC/SPUhgLfokPnFYNFZpZgxKW8HKyb2b350w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrleeigdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhggtgesghdtreertddtvdenucfhrhhomheprfhhihhlihhp ucfotgfirhgrthhhuceophhhihhlihhpsehphhhilhhiphhmtghgrhgrthhhrdgtohhmqe enucggtffrrghtthgvrhhnpeeiieefheeutedutdfgffdtheehtedtudevtedtgfeludel leekgfduteejkefggfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehphhhilhhiphesphhhihhlihhpmhgtghhrrghthhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 26 Feb 2022 14:56:04 -0500 (EST) From: Philip McGrath Date: Sat, 26 Feb 2022 14:55:59 -0500 Message-ID: <3566149.rYT2d9vS2d@bastet> In-Reply-To: <6a35fdea04cdf461a662830efc5bfd84fee60ec1.camel@gmail.com> References: <20220220060610.178131-1-philip@philipmcgrath.com> <19823080.dSP1spjjOr@bastet> <6a35fdea04cdf461a662830efc5bfd84fee60ec1.camel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3472970.ViWdsapti3"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645905437; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/WrC8PomR8thekFJA8o1pM0qQZihzP2DUNTsgNTTV0A=; b=I4CfPgzPG9HBEbpDUwkQ6nnknORU8My60OunMLLGNvBGMDAnHUCoZ31VBxPh53Ng3AGeFf lV4hVmwvsuWWIFgxGLRwi+3ofA4cpr0Vdks1RRb0yFMEgIgzoicrrJxxbdbC2gPyozesri CNrQn4wA7/DDcGPtybTKO+82JmArx8fPtDHHajrgDazVfbQdeUPTAJUvtENWlA/NAaoVRr oDUdgOs86l3nPFO187VXzYEHh6oq/Tks6H79u1E3gfLFKj5cefIQIfbhDdwHDJRnVVKsj4 gFcKFXEq+8qZpGpV3wEUSxmmJGqOhbs6vXY3resepKacBAZbLxMfV/anmkBnmQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645905437; a=rsa-sha256; cv=none; b=GmT9RwlfUej25ke8wTfgKSxy1MN7gERslhj+f5/87XmyUuiD4XqWvTWw8bbEwD3upqAvGH D522P+dKF0z8+2T/BOTHnM8H9pEn2GztVCahJADOq5yIt10dTxFaLovGLoDCAY5pgmwFUg 1P86B+DLF3kYb2/pC3RTYR4xWSmfMcMMHHNoase3MxOfeph+Px3Te+bVwemlHUa3QmzLRW 70jiCG7ClsD4UaiKawCFq1aLBKn+1eLJUmvu4VTueR1ks+GMWXWUO8+3VepqTQqjad2CtT aQ+aZjBqt1bB/2twPmacU4ZieAUFtGdyqwhbafBMrzFOVuIWkn2wbmMgWHeO/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=FuvLFzAx; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="gKDe/hHJ"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -0.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm1 header.b=FuvLFzAx; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b="gKDe/hHJ"; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A17BEF20A X-Spam-Score: -0.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: 58MwPW5m/0Cy --nextPart3472970.ViWdsapti3 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Philip McGrath To: 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler , Liliana Marie Prikler Cc: Ludovic =?ISO-8859-1?Q?Court=E8s?= , Attila Lendvai , Malte Gerdes , raingloom , Maxime Devos Subject: Re: [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Date: Sat, 26 Feb 2022 14:55:59 -0500 Message-ID: <3566149.rYT2d9vS2d@bastet> In-Reply-To: <6a35fdea04cdf461a662830efc5bfd84fee60ec1.camel@gmail.com> References: <20220220060610.178131-1-philip@philipmcgrath.com> <19823080.dSP1spjjOr@bastet> <6a35fdea04cdf461a662830efc5bfd84fee60ec1.camel@gmail.com> On Saturday, February 26, 2022 1:30:08 PM EST Liliana Marie Prikler wrote: > Hi, > > Am Samstag, dem 26.02.2022 um 12:23 -0500 schrieb Philip McGrath: > > Hi, > > > > On Saturday, February 26, 2022 9:26:29 AM EST Liliana Marie Prikler > > > > wrote: > > > I'm not talking about the generated file, but the procedure that > > > generates it. Special characters like dots and slash are still > > > pretty special in Scheme, even if they're allowed as identifiers. > > > > Do you mean A, B, C, and/or D of these: > > a > > > > > (replace 'configure > > > (lambda* (#:key inputs configure-flags #:allow-other- > > > keys) > > > (let* ((racket (search-input-file inputs > > > "bin/racket"))) > > > (apply invoke > > > racket > > > #$make-installation-layer.rkt ;; <--- A > > > `(,@configure-flags > > > ,(dirname (dirname racket)) > > > ,#$output)) > > > (invoke racket > > > "--config" (string-append #$output > > > "/etc/racket") > > > "-l" "raco" "setup" > > > "--no-user")))) > > > > > > [...] > > > > > > (define make-installation-layer.rkt ;; <--- B > > > (scheme-file > > > "make-installation-layer.rkt" ;; <--- C > > > `(module > > > make-installation-layer racket/base ;; <--- D > > > (require racket/cmdline > > > > or something else? > > The name in B is confusing imo, because it implies a procedure when it > is in fact a file. Of course, that'd affect A as well. The file name > in C does not matter too much, but should probably be matched with B to > some extent (but importantly keeping the .rkt extension even if we drop > it from B). I'm not sure if D is a function call or not, but if it's a > module name perhaps we should make it match B. > > Given that we pass configure-flags to this thing, how about "configure- > racket-layer", "configure-layer.rkt" or something along those lines? > "configure-layer.rkt" seems fine. I do see the potential for confusion about whether this was "making" an "installation-layer.rkt". (D is a module name and should for clarity match C without the suffix. Ultimately, for a module that is not a submodule, it is ignored and the name comes from context. This is an older way of writing modules that predates "#lang" (which would be inconvenient with `scheme-file`). Calling `read` with the appropriate parameters on the input "#lang racket/base 42" would produce the datum `(module anonymous-module racket/base (#%module-begin 42))`.) > > In particular, not to be dense, but B is not a function. > > Yeah, that's my bad for only skimming these and not paying too close > attention to brackets. The name itself implies a function, hence my > confusion. Looking at things closely would make me see more typos like > ";; workaroung Guile reader/printer:" > workaround. > Thanks. > > > > > I think some way to shorten those origins would do wonders in > > > > > terms > > > > > of the number of lines this patch adds. > > > > > > > > At one point, I had abbreviated the origins as something like: > > > > > > > > (REPO-SPEC SHA256 [COMMIT]) > > > > > > > > [...] > > > > > > I wouldn't do this inside of extract-package-source, but define a > > > one or two liner for adding specifically packages hosted on > > > racket's github. WDYT? > > > > > > > I wasn't sure about the trade-off between being slightly more > > > > cryptic > > > > than explicit origins, but a lot shorter. > > > > > > Note that the goal is not to code golf, but to be understandable. > > > When adding a bunch of origins as inputs, understandability suffers > > > by induced scrolling. > > > > I've done this, and it was a very good idea. In particular, it helped > > find some places where I hadn't switched to using `%racket-commit` > > once the release was tagged. > > That is better, but can still be improved. As hinted at in my comment > to your tree, origin snippets might be a better solution here unless > I'm missing something in the heat of the moment. Could you give an example of what you imagine the result might look like in use? E.g. (but I'm not sure this would really be an improvement): > (cons* > ... > libedit > racket-minimal > (append > (racket-package-sources > "2d" (base32 "1zzcz5qyjv7syi41vb8jkxjp1rqgj61zbsdrg0nlc4qy9qsafzgr") > "2d" "2d-doc" "2d-lib") > (racket-package-sources > "algol60" (base32 "09kj6asypmc24n29w0izc9p0q8hpga2hpkchsypfwn5c8zpvihlx") > '("algol60" ".")) > ...)) -Philip --nextPart3472970.ViWdsapti3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE9GWrrNY3rqwUFVXPygNjjfo/HHoFAmIahc8ACgkQygNjjfo/ HHrIfxAApQt8KeuiaXltoyLKUkwtufzJgzRmu0EYtKjKglt+g8RQfl7FoRWwmQq8 Ib2p+c4mCwiiwwfEmuSi+UfMf2ZjR76u+uAQbvPXEyCLOkMrD/JuUZd9LMuDuBbD 7aTGJbLKWgGaZQ1+ly22cvJ1vTR0uDKCiJlgGZBS2GjrXmRdoHjoeeCJCeT4Qb47 5dw8hjaNEKcPZuqP2A0/6ETqoIuUg4BdhUn4tYnFTfX8SLx2jLiXYTmDUrbpVh2k h0yeypVA0dU53RmZQ54ATGCHSyCpiZvm7kgvOffB2zVB4N+IB7TYlxIvjUdGeCIk 7C+U1RbdRvWAG4kUuOQ0hWCHhPOzPwfd3yNEubszMV6YZ2Vbrx7LdfMEfHXWfJ9S IaMJ8jCjZ3X0Ym98JsV9hLriZUvz/2OblyqaZZR0bpBXtaSANg8Plcme+hIz87Fd umnuoAC6oL9G+ZMXCkfh5r1CG8q2fWvHBUyRmw4BYVJpls7BWruf2GJQ87JtwIL2 ajsGuGcc/hwAZdT9iwTioFt5T9dslLGIhRsTt2fwxxXccz3Y+6DsFy58jJfbxUw5 J+BxJ+MkP3UFedIEnDk9BODApHpoE//OaXsyiddToe77o19cJHLwfSGMySCUk7sW +BoXmDzqcVPDLoBidR8b1B+DZGV+AAhw1zRWBwk0c5f1UHxLq/Q= =BixL -----END PGP SIGNATURE----- --nextPart3472970.ViWdsapti3--