From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KKEUDnq8bWDjCAEAgWs5BA (envelope-from ) for ; Wed, 07 Apr 2021 16:06:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id OIMFCHq8bWDQVwAAB5/wlQ (envelope-from ) for ; Wed, 07 Apr 2021 14:06:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B757157AA for ; Wed, 7 Apr 2021 16:06:49 +0200 (CEST) Received: from localhost ([::1]:38210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lU8pU-00046M-5c for larch@yhetil.org; Wed, 07 Apr 2021 10:06:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lU8lq-0001Kt-Ll for guix-patches@gnu.org; Wed, 07 Apr 2021 10:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33428) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lU8lq-0004Yi-9P for guix-patches@gnu.org; Wed, 07 Apr 2021 10:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lU8lq-00040o-2U for guix-patches@gnu.org; Wed, 07 Apr 2021 10:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47613] =?UTF-8?Q?[PATCH]=C2=A0add?= parmetis Resent-From: Franck =?UTF-8?Q?P=C3=A9rignon?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 07 Apr 2021 14:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47613 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Famulari Cc: 47613@debbugs.gnu.org Received: via spool by 47613-submit@debbugs.gnu.org id=B47613.161780413315366 (code B ref 47613); Wed, 07 Apr 2021 14:03:01 +0000 Received: (at 47613) by debbugs.gnu.org; 7 Apr 2021 14:02:13 +0000 Received: from localhost ([127.0.0.1]:44974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lU8l2-0003zm-On for submit@debbugs.gnu.org; Wed, 07 Apr 2021 10:02:13 -0400 Received: from zm-mta-out-3.u-ga.fr ([152.77.200.56]:50198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lU8l0-0003zT-7X for 47613@debbugs.gnu.org; Wed, 07 Apr 2021 10:02:11 -0400 Received: from zm-mta-out.u-ga.fr (zm-mta-out.u-ga.fr [152.77.200.53]) by zm-mta-out-3.u-ga.fr (Postfix) with ESMTP id EB32F41495; Wed, 7 Apr 2021 16:02:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=univ-grenoble-alpes.fr; s=2020; t=1617804123; bh=j7NJNqFx085Ica8zFQOBtBCdpYXUWtfetM0dqGu+qiA=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=xgZXdPuEh/2UCFmfDLl71iqz6DQZmdTTEa7nBSulrOgeeAXGISmuce8Kc1lmqIn3T 5pc0B3FWEWIZWlDGH48OyPMqjJuBXchrp2ANnrajwcf1IBFuPf5rGP+UzHPPVvGwz1 Rg6ajdc/5iOCWl9m+WwT9r1V+c5GtHNwRpN6aVrnogXEOz93QWKM3u+B2Kj2Xfcfex ikaJpyY+BuTRSkfq6Sp2Znb2tELJ8DYIsSohHAM5W6X/RIP0B+frr8Il7+mq7AEyDP r+N9QkmDdRf2N8G3vn13WatGbWNPrfzDYqT7hiP9nG2goQ8bl8Rw2TcLKexzRk1ssw izDRlqxCaRbRA== Received: from smtps.univ-grenoble-alpes.fr (smtps1.u-ga.fr [152.77.1.30]) by zm-mta-out.u-ga.fr (Postfix) with ESMTP id E40D880316; Wed, 7 Apr 2021 16:02:03 +0200 (CEST) Received: from [192.168.0.44] (91-170-36-193.subs.proxad.net [91.170.36.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: perignfr@univ-grenoble-alpes.fr) by smtps.univ-grenoble-alpes.fr (Postfix) with ESMTPSA id C8CF4187E0F; Wed, 7 Apr 2021 16:02:03 +0200 (CEST) From: Franck =?UTF-8?Q?P=C3=A9rignon?= Message-Id: <345E7B86-C347-4EC5-83AB-7D0C6D800489@univ-grenoble-alpes.fr> Content-Type: multipart/mixed; boundary="Apple-Mail=_90C5B577-3474-4852-8B28-2477E473CEC9" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Wed, 7 Apr 2021 16:02:03 +0200 In-Reply-To: References: X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Greylist: Whitelist-UGA SMTP Authentifie (perignfr@univ-grenoble-alpes.fr) via smtps-465 ACL (110) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617804409; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8KNlyaa0Bhrel7/K5Y3LFLR5HntCt1VRCksdF0Eu25c=; b=BgLREH2Tc45+XQgw4txmQoQi3PONax+iW0zX7Sk9DYQsLIBZYIGUt8DE3f46lFOVJI2+zD JT4ftmLxQTI50LLZXzKPjyO9zcKDMBDpefZL97hzeIoLF7j0pVl3FMz40+MXcMNSmpowHO ZR6MiT21qTryzYg5cvYQmt6/azWIyZem2tYrL2NUIVCBtOZmMbK3XfI3t1C9HE5S4K2mHx uLx8yisR9RFq7xAeWg4hhvHIbgUFnPHaBTqPy6p3c+Hp2Vc93Ws26N98PCyXLBws407XLu Q9wpEoDXVDe6GhtYNCIA+d0S8Ndfje7LjBQtAd4MpxvsOjc8vc+o64B315pDxw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617804409; a=rsa-sha256; cv=none; b=V7a5FFjlTp/AOLElhGOYB8pfFyukrR5U2KIgYRgQ4uTzJ7f8g+SMN1O3lL1xrccFbpojBR hXnFhooieHuAHOl6Epo9Tugn7PxzqgF7Fq+K5O+ZlW4HJ019nA+RF/OEfaU8fuZU3P3vlz JozFIViquWEpr6Dw+DEM4Kcxq51t+AkYqtprCZdNYr514yEx+h4qDSD8SLBvGYPeFjbL7D 644VI5Wrv6iPMUQsPuvvzRBctYk1i98WEvrMTYr1wWEzcoJPg3IJl7tQBPGP9r68kfbZsK ujvzV9y1dsCio9TXSe68iEj8VTthEiVLxb9b+frJuPqCzVE6/sacMNEUk+7Ykg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=univ-grenoble-alpes.fr header.s=2020 header.b=xgZXdPuE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=univ-grenoble-alpes.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.84 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=univ-grenoble-alpes.fr header.s=2020 header.b=xgZXdPuE; dmarc=fail reason="SPF not aligned (relaxed)" header.from=univ-grenoble-alpes.fr (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 5B757157AA X-Spam-Score: -0.84 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ftif93sUH2a9 --Apple-Mail=_90C5B577-3474-4852-8B28-2477E473CEC9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Thanks for the review (of this and of scotch-shared) Yes, you=E2=80=99re right, gcc native-inputs can be removed and yes, = it=E2=80=99s probably better to avoid hard-coding version string A new patch is attached that works for me. Regarding the license, I missed this. Is it possible to directly = attached the LICENSE.txt in the guix recipe ? If so, what=E2=80=99s the = proper syntax ? Thanks --Apple-Mail=_90C5B577-3474-4852-8B28-2477E473CEC9 Content-Disposition: attachment; filename=0002-fix-parmetis.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0002-fix-parmetis.patch" Content-Transfer-Encoding: quoted-printable =46rom=20f056bb21841032d769bf075be9da1a49f61c2d0f=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Franck=3D20P=3DC3=3DA9rignon?=3D=0A= =20=0ADate:=20Wed,=207=20Apr=20= 2021=2013:52:52=20+0000=0ASubject:=20[PATCH=202/2]=20fix=20parmetis=0A=0A= ---=0A=20gnu/packages/maths.scm=20|=209=20+++++----=0A=201=20file=20= changed,=205=20insertions(+),=204=20deletions(-)=0A=0Adiff=20--git=20= a/gnu/packages/maths.scm=20b/gnu/packages/maths.scm=0Aindex=20= 1a177e0389..564e2789f9=20100644=0A---=20a/gnu/packages/maths.scm=0A+++=20= b/gnu/packages/maths.scm=0A@@=20-3419,16=20+3419,17=20@@=20schemes.")=0A=20= =20=20=20=20=20=20=20=20(base32=0A=20=20=20=20=20=20=20=20=20=20= "0pvfpvb36djvqlcc3lq7si0c5xpb2cqndjg8wvzg35ygnwqs5ngj"))))=0A=20=20=20=20= =20(build-system=20cmake-build-system)=0A-=20=20=20=20(native-inputs=20= `(("gcc"=20,gcc)=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20("openmpi"=20,openmpi)))=0A+=20=20=20=20(native-inputs=20= `(("openmpi"=20,openmpi)))=0A=20=20=20=20=20(arguments=0A=20=20=20=20=20=20= `(#:tests?=20#f=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20;no=20tests=0A=20=20=20=20=20=20=20=20#:configure-flags=20= `("-DSHARED=3DON"=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20,"-DCMAKE_C_COMPILER=3Dmpicc"=0A=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ,"-DCMAKE_CXX_COMPILER=3Dmpic++"=0A=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ,"-DCMAKE_VERBOSE_MAKEFILE=3D1"=0A-=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20,(string-append=20= "-DGKLIB_PATH=3D../parmetis-4.0.3/metis/GKlib")=0A-=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20,(string-append=20= "-DMETIS_PATH=3D../parmetis-4.0.3/metis"=20))))=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20,(string-append=20= "-DGKLIB_PATH=3D../parmetis-"=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20,(package-version=20parmetis)=20"/metis/GKlib")=0A+=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= ,(string-append=20"-DMETIS_PATH=3D../parmetis-"=0A+=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20,(package-version=20parmetis)=20= "/metis"))))=0A=20=20=20=20=20(home-page=20= "http://glaros.dtc.umn.edu/gkhome/metis/parmetis/overview")=0A=20=20=20=20= =20(synopsis=20"Parallel=20Graph=20Partitioning=20and=20Fill-reducing=20= Matrix=20Ordering")=0A=20=20=20=20=20(description=0A--=20=0A2.25.1=0A=0A= --Apple-Mail=_90C5B577-3474-4852-8B28-2477E473CEC9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > Le 6 avr. 2021 =C3=A0 19:43, Leo Famulari a =C3=A9cr= it : >=20 > Subject: [PATCH] [PATCH] Add parmetis >=20 > Thanks! >=20 >=20 > + (build-system cmake-build-system) > + (native-inputs `(("gcc" ,gcc) > + ("openmpi" ,openmpi))) >=20 > GCC is made available via the cmake-build-system, so I think we could > leave it out of native-inputs. Or am I missing something? >=20 > + (arguments > + `(#:tests? #f ;no tests > + #:configure-flags `("-DSHARED=3DON" > + ,"-DCMAKE_C_COMPILER=3Dmpicc" > + ,"-DCMAKE_CXX_COMPILER=3Dmpic++" > + ,"-DCMAKE_VERBOSE_MAKEFILE=3D1" > + ,(string-append = "-DGKLIB_PATH=3D../parmetis-4.0.3/metis/GKlib") > + ,(string-append = "-DMETIS_PATH=3D../parmetis-4.0.3/metis" )))) >=20 > We can avoid hard-coding the version string here, like this: >=20 > ------ > diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm > index bdfa051db1..f0ebdd6009 100644 > --- a/gnu/packages/maths.scm > +++ b/gnu/packages/maths.scm > @@ -3348,8 +3348,10 @@ schemes.") > ,"-DCMAKE_C_COMPILER=3Dmpicc" > ,"-DCMAKE_CXX_COMPILER=3Dmpic++" > ,"-DCMAKE_VERBOSE_MAKEFILE=3D1" > - ,(string-append = "-DGKLIB_PATH=3D../parmetis-4.0.3/metis/GKlib") > - ,(string-append = "-DMETIS_PATH=3D../parmetis-4.0.3/metis" )))) > + ,(string-append = "-DGKLIB_PATH=3D../parmetis-" > + ,(package-version = this-version) "/metis/GKlib")) > + ,(string-append = "-DMETIS_PATH=3D../parmetis-" > + ,(package-version = this-version) "/metis")))) > (home-page = "http://glaros.dtc.umn.edu/gkhome/metis/parmetis/overview") > (synopsis "Parallel Graph Partitioning and Fill-reducing Matrix = Ordering") > (description > ------ >=20 > + (license license:asl2.0))) >=20 > There is a problem with the licensing, however. In the source code, > LICENSE.txt contains this: >=20 > ------ > Copyright & License Notice > -------------------------- >=20 > The ParMETIS package is copyrighted by the Regents of the=20 > University of Minnesota. It can be freely used for educational and=20 > research purposes by non-profit institutions and US government=20 > agencies only. Other organizations are allowed to use ParMETIS=20 > only for evaluation purposes, and any further uses will require prior=20= > approval. The software may not be sold or redistributed without prior=20= > approval. One may make copies of the software for their use provided=20= > that the copies, are not sold or distributed, are used under the same=20= > terms and conditions. >=20 > As unestablished research software, this code is provided on an =20 > ``as is'' basis without warranty of any kind, either expressed or > implied. The downloading, or executing any part of this software > constitutes an implicit agreement to these terms. These terms and=20 > conditions are subject to change at any time without prior notice. > ------ >=20 > I saw in 'metis/Changelog' that a relicensing to Apache 2 was done for > the "metis" program in version 5.0.3. But, this is "parmetis", version > 4.0.3. >=20 > If the copyright owners intend to release this as free software, they > need to change the 'LICENSE.txt' file. --Apple-Mail=_90C5B577-3474-4852-8B28-2477E473CEC9--