From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hartmut Goebel Subject: Re: [PATCH 1/3] gnu: Add python-pypdf2. Date: Wed, 9 Nov 2016 22:59:54 +0100 Message-ID: <33c86134-e453-109e-febe-2ad9b2414ab0@crazy-compilers.com> References: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com> <20161108235524.GA25046@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4aua-0004sP-52 for guix-devel@gnu.org; Wed, 09 Nov 2016 17:00:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4auV-0006gn-B8 for guix-devel@gnu.org; Wed, 09 Nov 2016 17:00:04 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:56244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c4auV-0006gg-4t for guix-devel@gnu.org; Wed, 09 Nov 2016 16:59:59 -0500 In-Reply-To: <20161108235524.GA25046@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Am 09.11.2016 um 00:55 schrieb Leo Famulari: >> + '(#:tests? #f)) ; no tests > Are these files not relevant? > https://github.com/mstamy2/PyPDF2/tree/master/Tests Ubs, I missed them. This is negligible and fails in Python 3. nevertheless I added them. > I would replace the hyphen in "Pure-Python" with a space. > We have to use enumerate instead of itemize due to a limitation in Done. I'll send updates patches since again it's late at night :-) -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |