From: Maxime Devos <maximedevos@telenet.be>
To: "Ludovic Courtès" <ludo@gnu.org>, 53964@debbugs.gnu.org
Subject: [bug#53964] [PATCH 3/4] gnu: ghc@4: Build without referring to packages in commencement.scm.
Date: Sat, 12 Feb 2022 23:49:43 +0100 [thread overview]
Message-ID: <3379bd03d68d5941b14de1791aeaf5284442e9cd.camel@telenet.be> (raw)
In-Reply-To: <20220212214532.23087-3-ludo@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
Ludovic Courtès schreef op za 12-02-2022 om 22:45 [+0100]:
> - (patches (list (search-patch "ghc-4.patch")))))
> + (patches (search-patches "ghc-4.patch"))))
Looks like an unrelated change to me. From (guix)Submitting Patches:
13. Verify that your patch contains only one set of related changes.
Bundling unrelated changes together makes reviewing harder and
slower.
Examples of unrelated changes include the addition of several
packages, or a package update along with fixes to that package.
Perhaps this is acceptable though for the same reasons removing
trailing #t from phases is acceptable ...
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2022-02-12 22:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-12 21:43 [bug#53964] [PATCH 0/4] Build nhc98 and ghc@4 with regular dependencies Ludovic Courtès
2022-02-12 21:45 ` [bug#53964] [PATCH 1/4] gnu: nhc98: Build with the current tool chain Ludovic Courtès
2022-02-12 21:45 ` [bug#53964] [PATCH 2/4] gnu: gcc: Add 2.95 Ludovic Courtès
2022-02-12 22:35 ` Maxime Devos
2022-02-12 22:37 ` Maxime Devos
2022-02-14 9:23 ` Ludovic Courtès
2022-02-12 22:40 ` Maxime Devos
2022-02-14 9:25 ` Ludovic Courtès
2022-02-12 22:43 ` Maxime Devos
2022-02-12 22:45 ` Maxime Devos
2022-02-14 9:26 ` Ludovic Courtès
2022-02-12 22:47 ` Maxime Devos
2022-02-14 9:33 ` Ludovic Courtès
2022-02-14 11:22 ` [bug#53964] [PATCH 0/4] Build nhc98 and ghc@4 with regular dependencies Ludovic Courtès
2022-02-12 21:45 ` [bug#53964] [PATCH 3/4] gnu: ghc@4: Build without referring to packages in commencement.scm Ludovic Courtès
2022-02-12 22:49 ` Maxime Devos [this message]
2022-02-14 9:35 ` Ludovic Courtès
2022-02-12 22:52 ` Maxime Devos
2022-02-14 9:36 ` Ludovic Courtès
2022-02-12 21:45 ` [bug#53964] [PATCH 4/4] gnu: Remove glibc@2.2.5 and gcc-2.95-wrapper Ludovic Courtès
2022-02-12 22:14 ` [bug#53964] [PATCH 0/4] Build nhc98 and ghc@4 with regular dependencies Ricardo Wurmus
2022-02-14 14:58 ` bug#53964: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3379bd03d68d5941b14de1791aeaf5284442e9cd.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=53964@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.