From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EGTxJgVPwV/ZXgAA0tVLHw (envelope-from ) for ; Fri, 27 Nov 2020 19:09:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id kDWzIgVPwV8pHAAAB5/wlQ (envelope-from ) for ; Fri, 27 Nov 2020 19:09:57 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2AA3D94036A for ; Fri, 27 Nov 2020 19:09:57 +0000 (UTC) Received: from localhost ([::1]:40064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kij7z-0002Ya-V9 for larch@yhetil.org; Fri, 27 Nov 2020 14:09:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kij4E-0006g4-SJ for guix-patches@gnu.org; Fri, 27 Nov 2020 14:06:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34674) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kij4E-0002Zo-Je for guix-patches@gnu.org; Fri, 27 Nov 2020 14:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kij4E-0001PQ-A9 for guix-patches@gnu.org; Fri, 27 Nov 2020 14:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44880] [PATCH] gnu: ruby-rubocop: Update to 1.4.2. References: <31afd594-481c-38ba-8929-26b74693eb73@mailbox.org> In-Reply-To: <31afd594-481c-38ba-8929-26b74693eb73@mailbox.org> Resent-From: =?UTF-8?Q?Tom=C3=A1s_?= =?UTF-8?Q?Ort=C3=ADn_?= =?UTF-8?Q?Fern=C3=A1ndez?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 Nov 2020 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44880 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44880@debbugs.gnu.org Received: via spool by 44880-submit@debbugs.gnu.org id=B44880.16065039195368 (code B ref 44880); Fri, 27 Nov 2020 19:06:02 +0000 Received: (at 44880) by debbugs.gnu.org; 27 Nov 2020 19:05:19 +0000 Received: from localhost ([127.0.0.1]:46220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kij3X-0001OV-6H for submit@debbugs.gnu.org; Fri, 27 Nov 2020 14:05:19 -0500 Received: from mout-p-201.mailbox.org ([80.241.56.171]:53020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kij3V-0001OF-0t for 44880@debbugs.gnu.org; Fri, 27 Nov 2020 14:05:18 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4CjPFy6J3zzQlDC for <44880@debbugs.gnu.org>; Fri, 27 Nov 2020 20:05:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= content-transfer-encoding:content-language:content-type :content-type:mime-version:date:date:message-id:subject:subject :from:from:received; s=mail20150812; t=1606503907; bh=GNpO4GACd8 fc0kk0A7XPk7LUSwn44ZJOyt3NNxYRPaw=; b=Fwdv/grs+0I+q30besraMmSSdq q2mWbIbzfS4cspTwS+nTkCv3qCSWanElCd28w18vp91dGBH0NYeTYqWgumfZEQFe L6jeYnx387L7mV4O1/UKZIWrlg1uRhRFw20BigZEvsiOEi+KLsz0DMMkDaGk7fkW paRicDY9KZeVaw4N7OcApa9RgeuEGg8FVkKszDvLudztq2td+HUv2dJFM5slVz2e TfXab15hj5/xjSOAk0d6HM5WuWCXOX5Yj0DFdd0KZt1pXZExqD+jKpnUNwWC83lM iaxVWkEuCbu06vKw+x6R0hL98ZaVjlswCgsv6byeXWWbjVrdUFi5bSO6EBgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1606503908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QfMBZFStCUgffDzIvYWwNja6L1//rFyMhdhuW08xNjQ=; b=PuREQsbLyuIDYZlwJ1VSOG6DaXai3KlCtRN6YJ73YjjEB1YCNadVdLW8DeMZZP/7GH/mVh OQumJX2R/aeKYyn167Zyd276eDPhVTKgfHH00+59a58f5o6sIv6oQ5z0LQd1VUNEkgVkK+ ny1K15drIZx88OGz4PD99PFfwP4lr2S/XEjOXjiqShrfwi9G1RoPLBqmutI33nwTDiguMn S/7dibbs2V/Q5TVAQZbivXYzwOF7ZoGFhY5Xr1FGvlby9ErMmvwQCvEJFa5D/em/BTKyAw IUuntYg+Y54nPBZ9qVusOgGCs3h7baB+vaizvgwQtys/ZNgmHITrzY13hFxewQ== X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id sn7kUoOd5gZq for <44880@debbugs.gnu.org>; Fri, 27 Nov 2020 20:05:07 +0100 (CET) Message-ID: <3298b708-515f-5ef2-3198-6395749da8d6@mailbox.org> Date: Fri, 27 Nov 2020 20:05:06 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -5.05 / 15.00 / 15.00 X-Rspamd-Queue-Id: 949A21843 X-Rspamd-UID: 303514 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tomás Ortín Fernández , Tomás Ortín Fernández via Guix-patches From: Tomás Ortín Fernández via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.77 X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=mailbox.org header.s=mail20150812 header.b=Fwdv/grs; dkim=fail (headers rsa verify failed) header.d=mailbox.org header.s=mail20150812 header.b=PuREQsbL; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-TUID: xxFsfTPdWzUe I'm finding it very difficult to package the updated rubocop from git, so here is a patch with rubocop 1.4.2 packaged from the gem. It was packaged from git because the gem doesn't include tests, but I can't figure out how to make the tests work. I have already asked for help at help-guix, and I'm sending this patch in the meanwhile because the current rubocop version is too outdated to be useful at all. As soon as I have the tests figured out, I will send a patch enabling the tests. Tomás * gnu/packages/ruby.scm (ruby-rubocop): Update to 1.4.2, fetch from gem, disable tests --- gnu/packages/ruby.scm | 51 +++++---------------------------------------------- 1 file changed, 5 insertions(+), 46 deletions(-) diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm index 2753403834..eeabedf3d1 100644 --- a/gnu/packages/ruby.scm +++ b/gnu/packages/ruby.scm @@ -7052,58 +7052,17 @@ run.") (define-public ruby-rubocop (package (name "ruby-rubocop") - (version "0.88.0") + (version "1.4.2") (source (origin - (method git-fetch) ;no tests in distributed gem - (uri (git-reference - (url "https://github.com/rubocop-hq/rubocop") - (commit (string-append "v" version)))) - (file-name (git-file-name name version)) + (method url-fetch) + (uri (rubygems-uri "rubocop" version)) (sha256 (base32 - "1d06893jp8pd85fvgp5d16vqcf31bafi430v4f4y746ihyvhzz5r")) - (patches (search-patches "ruby-rubocop-break-dependency-cycle.patch")))) + "1kvzhzhzcdd5bqwjilb0fpp51sqjniww2b0g713n0cvhnlgchn2y")))) (build-system ruby-build-system) (arguments - '(#:test-target "default" - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'remove-problematic-tests - ;; These tests depend on Rubocop extensions, which cannot be - ;; included as they cause a dependency cycle with Rubocop itself. - (lambda _ - (delete-file "spec/rubocop/config_loader_spec.rb") - (substitute* "Gemfile" - ((".*'rubocop-performance'.*") "") - ((".*'rubocop-rspec'.*") "")) - ;; Prevent "Unnecessary disabling of RSpec/* (unknown cop)" - ;; errors. - (substitute* (find-files "spec/rubocop/cop/" "_spec\\.rb$") - (("# (rubocop:(enable|disable) RSpec.*)" _ what) - (string-append "# Disabled: " what))) - #t)) - (add-after 'unpack 'disable-bundler - (lambda _ - (substitute* "Rakefile" - (("Bundler\\.setup.*") "nil\n")) - #t)) - (replace 'replace-git-ls-files - (lambda _ - (substitute* "rubocop.gemspec" - (("`git ls-files(.*)`" _ files) - (format #f "`find ~a -type f| sort`" files))) - #t)) - (add-before 'check 'set-home - (lambda _ - (setenv "HOME" (getcwd)) - #t)) - (add-before 'check 'make-adoc-files-writable - (lambda _ - (let ((adoc-files (find-files "docs/modules/ROOT/pages" - "\\.adoc$"))) - (for-each make-file-writable adoc-files)) - #t))))) + '(#:tests? #f)) ;no tests in distributed gem (native-inputs `(("ruby-bump" ,ruby-bump) ("ruby-pry" ,ruby-pry)