From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cA7UETqdnWLXWAEAbAwnHQ (envelope-from ) for ; Mon, 06 Jun 2022 08:22:50 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kGHuEDqdnWIeTAEAG6o9tA (envelope-from ) for ; Mon, 06 Jun 2022 08:22:50 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A953528165 for ; Mon, 6 Jun 2022 08:22:49 +0200 (CEST) Received: from localhost ([::1]:59448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ny68W-0005MY-Bn for larch@yhetil.org; Mon, 06 Jun 2022 02:22:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ny606-0000Vm-6i for guix-patches@gnu.org; Mon, 06 Jun 2022 02:14:08 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ny602-0000I2-2W for guix-patches@gnu.org; Mon, 06 Jun 2022 02:14:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ny601-0008JX-Sl for guix-patches@gnu.org; Mon, 06 Jun 2022 02:14:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55814] [PATCH] Updated python-flake8 and inputs to reenable build. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Jun 2022 06:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55814 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Rodriguez , 55814@debbugs.gnu.org Received: via spool by 55814-submit@debbugs.gnu.org id=B55814.165449603531940 (code B ref 55814); Mon, 06 Jun 2022 06:14:01 +0000 Received: (at 55814) by debbugs.gnu.org; 6 Jun 2022 06:13:55 +0000 Received: from localhost ([127.0.0.1]:34236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny5zv-0008J6-Fl for submit@debbugs.gnu.org; Mon, 06 Jun 2022 02:13:55 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:33579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ny5zq-0008Iq-S9 for 55814@debbugs.gnu.org; Mon, 06 Jun 2022 02:13:53 -0400 Received: by mail-ed1-f68.google.com with SMTP id h19so17435961edj.0 for <55814@debbugs.gnu.org>; Sun, 05 Jun 2022 23:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=GNf+yOl1bxEZ4hcKp8+xc1v9jYiIh05G2Ga9zY62AqI=; b=q5tbLWUSYa0g+CkodTmsErtOzt6LTs30yxomfuo47VfIDiSBPwccfuvG4S0wm5yqoZ qgjJPAml02GkZjh7zHXhAJNmS1S/5dYEXER2U9rwuKy4hAErai1jnGGeLx2XkFDfSQJO Wod7CtEgeFwS3izjwSb7WzIrGaZUAa+Z/wJ4dvYM/t+0x7qH5UugVwK/AElOb4/i5HwU oFeD/Eg29K/q+xyLyRRTyvbsLPkBz26puhveFE/IfTt6GHJHE4/Mr8PkKgSZlji7Elfr 6PVdOzoZEy4n2EFp0u2eXxBSbTrP8M6YE3zR6vjv8jic/EQ7P1oNRwS3BmQhfxbGGbmq dlmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=GNf+yOl1bxEZ4hcKp8+xc1v9jYiIh05G2Ga9zY62AqI=; b=hQL7upkcSh+bm65MxrLUNXbgLEaCKvNc7iaPFs8mR5nEqafaZC37L40nZ8MPNc1fk6 CM30FwPjS58IIaHUJmJLwUOItXQQufCh+/PavJ4fbwB12F0ZglZ8i7pMzNCdc8E7+JuN ScQeH6Qq7Tzk//NNV7hDfUDniuAWxnDikNRg6bH1FKF5aojbTprOcwx90KL03s2CGM1h 9XB/5hi/3l1A8DOHykAjvGFBHPUuBjuk8eHMdxXVGZNkQrEOgIPEY19gBWFIrHGnXDci GfShP9j5G4/62NWRwtCFeZZEOJG/Sll1hz8K5P9EO3Na5pxaws6gUCwQI5OgZtDExHbo rf/Q== X-Gm-Message-State: AOAM532FxDHtfw9CKYVtUxFM9jofmQzBsFIB4qJlzL6HivWkPc7PfZTf 5EBiPAk1/Tj3ugsds6OhqmU= X-Google-Smtp-Source: ABdhPJznW+8tZwbFJYCzYFrf8M+oPTGuEydZujpyse+tP848RofnbGCKFFcwMZJuwqYrAk0vmE3SXA== X-Received: by 2002:a05:6402:459:b0:431:665f:11ce with SMTP id p25-20020a056402045900b00431665f11cemr2657143edw.35.1654496024759; Sun, 05 Jun 2022 23:13:44 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b23-20020a17090630d700b0070e1adff390sm3856696ejb.34.2022.06.05.23.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jun 2022 23:13:44 -0700 (PDT) Message-ID: <2fe5b2c4a0eb1a65a04addaba74a3b578ede58b4.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 06 Jun 2022 08:13:43 +0200 In-Reply-To: <20220606014315.280227-1-yewscion@gmail.com> References: <20220606014315.280227-1-yewscion@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654496569; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=GNf+yOl1bxEZ4hcKp8+xc1v9jYiIh05G2Ga9zY62AqI=; b=gwk/Ke2P/JCl6Li0nuJES1dIAxiO8oIfDbugHAnVOQJ+kYS1AE5MHP3a5zoaOA/K9PeB8z juJLFgg8k/qfzKRJFrco4xeRQHK21c69zpuadJG3dIqSXeGcMMOg40dqP1IRDJrBSjsKFd pfc8k9jhcenW0fgCeroCvddR9DZicmH8Lrg6bG9qED7Ln8Kz0UOHwlxNd6bQyBe8IaK4Kt 9wCWRbzKlwZM2eAvvo3y//9W3oPIAEjVoRH2Fo50zM/ah4uzOpdkC2h2zPc2yM+C4Wy2s+ LCPJJzoN/ypBauES1gP3uVsV1xAtJjkzaw4wgJl1onuUqLDhNJp4FExW2nBN7w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654496569; a=rsa-sha256; cv=none; b=ddBsYcWRw0xKBuh3qZfSF8X0ouGWL/UsJZUKzO+MRI+S5D9ckC776wPKE8BXoigAC4CpgB vFZPDG3BdqJRL6aBgOKr6OcbhwXj0VSu1H4FlEE6Jr8r+bzdqSeVyZkAgF/X0Y0KHBT86w 8MhAUlf84V4ccVyNebKz/vAlR3Vodg99Kl4ZdEgGZuNzEwYVjjoeuaeUH/8JGhl+6yzUt8 9ahJmGSolw5SYTm8K6/n+yjylZXmyFsn7U7REOXOvkXuYxEFabjTwrOAoTTNSPHFqXC8Yt rZYBUV6EokHHrx2R/3ddy0qGujjAaEzC12ypRXDDR4bCu4YnIHZ7kpyWY/5psw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=q5tbLWUS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.39 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=q5tbLWUS; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A953528165 X-Spam-Score: 6.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: JcAzHSbfUlnd Am Sonntag, dem 05.06.2022 um 21:43 -0400 schrieb Christopher Rodriguez: > It builds in my local tree, and had been linted/styled/tested/etc. Did you also check that all the packages referring to it build? The upgrade to python-pyflakes ignored this important check as well as the call not to update packages with more than 300 dependents on master. >  gnu/packages/python-xyz.scm | 54 ++++++++++++++++++----------------- > -- >  1 file changed, 26 insertions(+), 28 deletions(-) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python- > xyz.scm > index 0dfc6ca7e0..77f2c88235 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -6443,23 +6443,21 @@ (define-public python-socksipychain >  (define-public python-pycodestyle >    (package >      (name "python-pycodestyle") > -    (version "2.7.0") > -    (source > -     (origin > -       (method url-fetch) > -       (uri (pypi-uri "pycodestyle" version)) > -       (sha256 > -        (base32 > -         "1vqwmzmjdv331kmfq3q9j3as2x7r2r49lf83r9w4147pdg8c32f3")))) > +    (version "2.8.0") > +    (source (origin > +              (method url-fetch) > +              (uri (pypi-uri "pycodestyle" version)) > +              (sha256 > +               (base32 > +                > "0zxyrg8029lzjhima6l5nk6y0z6lm5wfp9qchz3s33j3xx3mipgd")))) Factor out into a single patch. >      (build-system python-build-system) >      (arguments > -     `(#:phases > -       (modify-phases %standard-phases > -         (replace 'check > -           (lambda _ > -             (invoke "pytest" "-vv")))))) > +     `(#:phases (modify-phases %standard-phases > +                  (replace 'check > +                    (lambda (#:keys input output tests? #:allow- > other-keys) > +                      (if tests? > +                          (invoke "pytest" "-vv"))))))) IIUC this is fixing an already existing problem; thus factor out into its own patch. > - (native-inputs > - (list python-pytest)) > +    (native-inputs (list python-pytest)) I'd recommend not mixing updates and semantic fixes with style fixes. >      (home-page "https://pycodestyle.readthedocs.io/") >      (synopsis "Python style guide checker") >      (description "@code{pycodestyle} (formerly pep8) is a tool to > check > @@ -10143,18 +10141,17 @@ (define-public python-pyflakes >    (package >      (name "python-pyflakes") >      (version "2.4.0") > -    (source > -      (origin > -        (method url-fetch) > -        (uri (pypi-uri "pyflakes" version)) > -        (sha256 > -         (base32 > -          "0k5jn8jpxni264wxf6cc3xcd1qckc0pww30bsd77mwzdf8l5ra05")))) > +    (source (origin > +              (method url-fetch) > +              (uri (pypi-uri "pyflakes" version)) > +              (sha256 > +               (base32 > +                > "0k5jn8jpxni264wxf6cc3xcd1qckc0pww30bsd77mwzdf8l5ra05")))) >      (build-system python-build-system) >      (home-page "https://github.com/PyCQA/pyflakes") >      (synopsis "Passive checker of Python programs") >      (description > -      "Pyflakes statically checks Python source code for common > errors.") > +     "Pyflakes statically checks Python source code for common > errors.") >      (license license:expat))) Nothing to do here. >  (define-public python-pyflakes-2.2 > @@ -10193,20 +10190,21 @@ (define-public python-mccabe >  (define-public python-flake8 >    (package >      (name "python-flake8") > -    (version "3.9.2") > +    (version "4.0.1") Note that 4.0.1 is a semver break from 3.9 – also, we still supply 3.8. Thus, you might want to keep python-flake8-3.9 as a variant. >      (source (origin >                (method url-fetch) >                (uri (pypi-uri "flake8" version)) >                (sha256 >                 (base32 > -                > "0sspgh2ph7bb5fmf49mrdhi7n5m421kfkxk1n0vn4akgg20q6lh7")))) > +                > "03c7mnk34wfz7a0m5zq0273y94awz69fy5iww8alh4a4v96h6vl0")))) >      (build-system python-build-system) >      (arguments >       `(#:phases (modify-phases %standard-phases >                    (replace 'check > -                    (lambda* (#:key inputs outputs #:allow-other- > keys) > -                      (add-installed-pythonpath inputs outputs) > -                      (invoke "pytest" "-v")))))) > +                    (lambda* (#:key inputs outputs tests? #:allow- > other-keys) > +                      (if tests? > +                          (add-installed-pythonpath inputs outputs) > +                          (invoke "pytest" "-v"))))))) Again, should be its own patch. Cheers