From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id yCZmGQKR7GI0GgAAbAwnHQ (envelope-from ) for ; Fri, 05 Aug 2022 05:39:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IN5MGQKR7GK09gAAauVa8A (envelope-from ) for ; Fri, 05 Aug 2022 05:39:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43C6D39F34 for ; Fri, 5 Aug 2022 05:39:46 +0200 (CEST) Received: from localhost ([::1]:42174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJoBd-0000bz-9Z for larch@yhetil.org; Thu, 04 Aug 2022 23:39:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55176) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJoAO-00073c-QY for guix-devel@gnu.org; Thu, 04 Aug 2022 23:38:28 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJoAM-0002Su-FE; Thu, 04 Aug 2022 23:38:28 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 85E7B5C012A; Thu, 4 Aug 2022 23:38:25 -0400 (EDT) Received: from imap52 ([10.202.2.102]) by compute4.internal (MEProxy); Thu, 04 Aug 2022 23:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1659670705; x= 1659757105; bh=gy6Yn8J/WYVeuCl07q6YH9nIGlowjL8nW8/LbmUCP8Q=; b=s B51rgHduFSmGVDgxLKP0+tgi/j9qK9wXwpNuRxq7Hgw0yMYeB9m7paFz04ryHwls PMxvyxzkpEApeW2bQkbJdhZMJTk3ZoVXkh90vv015FoKWoePpqbApx37b3SPEYg1 FtFg0gVgjhyE1oRGITF0zOIel1octlXdpcx6850M5dOF12CbYgpBh8p88DEm+ucB o7Caec4mikEeIdhUThxVIAifaKWqFZXpKsC1mCAptoRrIzXTsDgEys/0LPmPTpr1 YQAfNFF7qG5CAQxy1yyYXTAbMIPZWtzPAjwHUWmeHBg5Df32gCxaEqIOBLD28LEF DSXtoAPeVpK27FwZBseaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1659670705; x=1659757105; bh=gy6Yn8J/WYVeuCl07q6YH9nIGlow jL8nW8/LbmUCP8Q=; b=XbbQZICGu27IELraKo4OANVaQRVka9dcaE6fYb07H8P3 o6DE0xkQVX39YpOfrfgV8YztMckAPEz1T374F3PsRFgIQ8Q/PZ70ieye8zip//GC 5pkxPAJwlJVFDIwaSi0/Qexek1xpX7jfYCj8Zro++um+TELZx1rkcesWdScSFtzm 96aTUCYVnq8n5i/cKoYTKL+5pxAWygMV0mgdB+JWv0WypK9PQH7cXZXbPIcDCJpy Vbk3vDlMxhoJbkI41+3HCJAfCeeSOz+de+zdQ4yIqtXJgW7Z2fD5rA1HeCt8RVv9 P1oGyawBvKvpvDrEn29OA6Dfx8dfmPKxk/V9BuTnrQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeftddgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfrfhh ihhlihhpucfotgfirhgrthhhfdcuoehphhhilhhiphesphhhihhlihhpmhgtghhrrghthh drtghomheqnecuggftrfgrthhtvghrnhepvdejvdetfeeghfejleduieevleekfefhteeh jeevkeetffdvtddviedvgeeghfefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepphhhihhlihhpsehphhhilhhiphhmtghgrhgrthhhrdgtohhm X-ME-Proxy: Feedback-ID: i2b1146f3:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 305C3C6008B; Thu, 4 Aug 2022 23:38:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-758-ge0d20a54e1-fm-20220729.001-ge0d20a54 Mime-Version: 1.0 Message-Id: <2faf39b5-acf7-4044-83b2-8e1ba7d34383@www.fastmail.com> In-Reply-To: References: Date: Thu, 04 Aug 2022 23:38:04 -0400 From: "Philip McGrath" To: "Maxime Devos" , "Brian Cully" Cc: "Julien Lepiller" , =?UTF-8?Q?Ludovic_Court=C3=A8s?= Subject: Re: A proposal of a consistent set of clear rules and guidelines involving snippets, phases and patches. Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.26; envelope-from=philip@philipmcgrath.com; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659670786; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=gy6Yn8J/WYVeuCl07q6YH9nIGlowjL8nW8/LbmUCP8Q=; b=kU9HceYjLsMBlm7NVgdZygyRT3uwOmvAf0oXQD9AYf3rs6vuSJsLHZ6+2T9z0IOfp+PkOf id17sqILzT+8TlD7d2SEWpvUIzZ0KzzRap1ycoV+M4ehq+99eKaA2dPFuDUeBsvvpMPqpX 8YsWXdINIqExCCt+SyS/BDH1ZwNUGv2FcJPP3tmWxli4fl8JLJjO2cp4ZTUkWa/+Q9d1my bJRH+Hckb6a1pWKp1IxTunkmZKcJY6YMereu0uIYN2uPk8s5tPHcwZ1wGtwbfLl3RQhzEf uPcQLDL55vnHHxCNTWghUFyE4j4h2OVYoXoXnGg1aEVoM0f5hO6a02NuTW6GUA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659670786; a=rsa-sha256; cv=none; b=GbslHz9bxRrOrARa5r+54qHFafZTHwA/fRnay/0L+biKYg7dYQJvS0zxYUKkpVF0SbgWev utE/TwvgZfNCALVH3SqVCmlzMqK2kqBfw9WL7eWtj9MKSUb6ILKFvBAi+MdOru/dUdFKGr erhC0cuQDtx0HmSXg6ebBcT7Ajwh8STxsJel6YJ3hiYmpqEQSfLhpJeNCAOkuOSgSV8aO0 xI9iaMCoBEgaBzy2XSPAOmEylewH+i1MziP+HYiZZMNjByYxpfFLGhEbPhbKZqKDTSi1vq W69g7vBkAuL2NKkX8jRNdxvgp1f9DpduOcwNSJ5MetJg+DqTyp428c4vEVY/rg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm3 header.b="s B51rgH"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=XbbQZICG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 1.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=fm3 header.b="s B51rgH"; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm3 header.b=XbbQZICG; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 43C6D39F34 X-Spam-Score: 1.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: IqUO1LNjgIqp On Sun, Jul 24, 2022, at 11:17 PM, Maxime Devos wrote: > * In principle, you can apply a patch from a phase. However, this causes the result of "guix build --source" to not correspond to the actual source code anymore (i.e., it doesn't act as corresponding source anymore), so consider this a last resort for situations such as avoiding causing a world-rebuild for a patch fixing a target-specific bug by making the patching conditional upon target-foo?. If you apply a patch from a phase, make sure that the patch appears in the inputs or native-inputs, such that "guix build --source=all" will include the patch. Should we have an option for "guix build --source=all" to also include the Guix "scripts used to control compilation and installation"? -Philip