From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Tildesley Subject: Re: [PATCH] gnu: Add libicns Date: Sun, 4 Sep 2016 05:38:15 +1000 Message-ID: <2f6589d3-5cba-0e2b-5576-d2d6f8ee3d2e@openmailbox.org> References: <3b92e609-3e2f-9f3e-3294-0e8f7a3ae558@openmailbox.org> <87a8fpqnvx.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <874m5xqhu6.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <6d93862f-c86e-e064-2392-3726c92e06e8@openmailbox.org> <87zinoq06p.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgGlo-00040L-Fr for guix-devel@gnu.org; Sat, 03 Sep 2016 15:38:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgGlk-0002DF-6g for guix-devel@gnu.org; Sat, 03 Sep 2016 15:38:27 -0400 Received: from smtp7.openmailbox.org ([62.4.1.41]:51340) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgGlj-0002D6-Sa for guix-devel@gnu.org; Sat, 03 Sep 2016 15:38:24 -0400 In-Reply-To: <87zinoq06p.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org On 2016-09-04 04:59, Marius Bakke wrote: > Brendan Tildesley writes: > >> On 2016-09-03 22:38, Marius Bakke wrote: >>> Marius Bakke writes: >>> >>>> Additionally this package bundles "m4" even if it doesn't use it. Can >>>> you remove it with a "origin" snippet? See e.g. "xcb-util-xrm" for how >>>> that's done. >>> My mistake, it does appear to use those files, and it's not actually m4. >>> I think using the generated libtool is probably OK. >>> >>> Alternatively it can be re-generated by adding a phase that invokes >>> "autoreconf -vif". I'm not actually sure if this is desired, so just >>> leave it for now. >>> >>> Thank you, >>> Marius >> Ah, well that lost me a bit of time. > Sorry about that! Now it re-generates libtool and friends, so it doesn't > hurt, at least. I only have a couple of remarks, and then someone with > commit access can take a final glance. > >> From b04ad5e40ac5befe30832ffbcf3b4283b4ae1d63 Mon Sep 17 00:00:00 2001 >> From: Brendan Tildesley >> Date: Sat, 3 Sep 2016 05:53:56 +1000 >> Subject: [PATCH] gnu: Add libicns. >> >> * gnu/packages/image.scm (libicns): New variable. >> --- >> gnu/packages/image.scm | 40 ++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> >> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm >> index 4fdc4ae..1b21306 100644 >> --- a/gnu/packages/image.scm >> +++ b/gnu/packages/image.scm >> @@ -48,6 +48,7 @@ >> #:use-module (guix download) >> #:use-module (guix build-system gnu) >> #:use-module (guix build-system cmake) >> + #:use-module (guix utils) > I don't think this is required. > >> #:use-module (srfi srfi-1)) >> >> (define-public libpng >> @@ -147,6 +148,45 @@ maximum quality factor.") >> (license license:gpl2+) >> (home-page "http://www.kokkonen.net/tjko/projects.html#jpegoptim"))) >> >> +(define-public libicns >> + (package >> + (name "libicns") >> + (version "0.8.1") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append >> + "mirror://sourceforge/icns/libicns-" version ".tar.gz")) >> + (sha256 (base32 >> + "1hjm8lwap7bjyyxsyi94fh5817xzqhk4kb5y0b7mb6675xw10prk")))) >> + (build-system gnu-build-system) >> + (inputs >> + `(("libpng" ,libpng-1.2) > It built fine with the latest libpng, is there a specific reason to use > this version? > I just notice the configure script wasn't looking for any newer version. I was using icns2png to extract png file, but probably wasn't utilising libpng to do this? as you can see it is built without support for larger icons, but I never used that feature. This is old software that hasn't been updated since 2012. Perhaps it could be made to work but I wouldn't know myself. Depends on the standards of Guix developers. checking libpng/png.h usability... no checking libpng/png.h presence... no checking for libpng/png.h... no checking libpng10/png.h usability... no checking libpng10/png.h presence... no checking for libpng10/png.h... no checking libpng12/png.h usability... yes checking libpng12/png.h presence... yes checking for libpng12/png.h... yes checking for jas_init in -ljasper... no checking for opj_setup_decoder in -lopenjpeg2... no checking for opj_setup_decoder in -lopenjpeg... no configure: WARNING: libopenjpeg or libjasper jp2000 codec libraries not found configure: WARNING: libicns will be built without 256x256 and 512x512 support > > The rest of the patch looks good to me. > > Thanks again! > Marius Thanks. If I posted a fix, I'd just end up making some new mistakes, so I'll just leave it to be added!