From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KOGpJEkJkWKmLQAAbAwnHQ (envelope-from ) for ; Fri, 27 May 2022 19:24:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id GLaAJEkJkWJmIAAAauVa8A (envelope-from ) for ; Fri, 27 May 2022 19:24:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3BCB537BA1 for ; Fri, 27 May 2022 19:24:25 +0200 (CEST) Received: from localhost ([::1]:51774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nudhH-0001nH-Tu for larch@yhetil.org; Fri, 27 May 2022 13:24:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nudgw-0001n1-Hu for guix-patches@gnu.org; Fri, 27 May 2022 13:24:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nudgw-0003Zf-8f for guix-patches@gnu.org; Fri, 27 May 2022 13:24:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nudgw-0002xT-3i for guix-patches@gnu.org; Fri, 27 May 2022 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55673] [PATCH] cache: Catch valid integer for 'last-expiry-cleanup'. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 27 May 2022 17:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55673 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 55673@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 55673-submit@debbugs.gnu.org id=B55673.165367219711296 (code B ref 55673); Fri, 27 May 2022 17:24:02 +0000 Received: (at 55673) by debbugs.gnu.org; 27 May 2022 17:23:17 +0000 Received: from localhost ([127.0.0.1]:35725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nudgC-0002w8-O0 for submit@debbugs.gnu.org; Fri, 27 May 2022 13:23:16 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:57292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nudgB-0002w0-Er for 55673@debbugs.gnu.org; Fri, 27 May 2022 13:23:16 -0400 Received: from [172.20.10.9] ([188.189.228.36]) by laurent.telenet-ops.be with bizsmtp id btPC2700M0nlcFw01tPDPT; Fri, 27 May 2022 19:23:13 +0200 Message-ID: <2ed60126c5ea7d7cffcad77082feba74ddab7517.camel@telenet.be> From: Maxime Devos Date: Fri, 27 May 2022 19:23:05 +0200 In-Reply-To: References: <20220527082519.501697-1-zimon.toutoune@gmail.com> <9432b1161007faacc0bd0e58da0bf839e2e8ec39.camel@telenet.be> <24883447c6f3d9b27bcc6e11e117ee974916e091.camel@telenet.be> <9483424cc3c89e5fa83ccc1e22b1f6cc7d04dd95.camel@telenet.be> <02f4e72bba800a2f59064a8bf628357b5a96f1d6.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-vk4RnnUo4QAY6dnT250b" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1653672193; bh=rGruYoLHU2RKhRvbJEiamAUMVfd7xNL6aCtPaa1PnI8=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Op+yNeSlnMXuXPjBLs/F+/i08ApW5SKivVPQ9njc2MA1RYncQwPfWC+SDnx93Q0HL YObl0mfljoP7RoTCiBZcx9mX5vX9Eoy/BfzJ3EVZoNWrRKaV75DuPsVSgLPvfv07Xw aakh6EY6EqFuaTl8Zs/ofdgQpucQi4OCPQbKo02gfsqLpybsF+U56JzBugjlaXCJ+k EiChDoLhr6oEIpM9AVpN4Hf33GmGumKx9X8IK5ggrrA99iH46ZqL2z9GFPZUEsA8RW C/co0Cpe0h/kxfoQSt2cRNU7tY/Po9ChLPjE+17ac0AUZrpGvZYMbNAH2XSMHQdyb9 qACNa5bdKb9dQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1653672265; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rGruYoLHU2RKhRvbJEiamAUMVfd7xNL6aCtPaa1PnI8=; b=AV/m+M4SeTJscXMxf3PyEVqoH9y5hNwO8LdQoFINLmRNmDeH1YOzPOsbYVK6YqJk5KxI3Y WhLWe3JZ6mi3FrrsO3C0sImq8YGwIVPZWiy+fDbyKns3B6qd//cmwrBZzbTKBGc46JjLMx VXk6nSj3iUvu28ekT9K2hDRzcoVeNSLAn3CY1jpSbZeUIqTi9Eh6RQVprAc6sAmpMBUJBM kvB6xtgcN5qhJNjAnfZTXFqvUZr9TSDG2Ba5dKKizOp1Q9nZUyqKmTBI8q/VW4UlJudJsT uFja5Ze3dXARHLG4NqBB1uzKHYJCvdE3jV7jfkhKTvqLb6nidJQNl6CVSp8SjQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1653672265; a=rsa-sha256; cv=none; b=HuXh/Bu0qPRY3bTd3xKp7DMBfM9lzkPM4pxS5pJnCHyvSYqBJQwU5csRKBLg/rl8m6NDCL CNnJtdKaAc2c/cUxKkrY1URz7HmblENOE9jblmnClZZF6FsgkDoeCvunrinM33s1iB8hFG 2NxzyloHc3ySsZ2adeoQeNyoXVQ6tfIjSS7Hv5A3t2ZD1dHYhbWXHzuMyh/XnPjrK8EYG4 TxunQgEhV+bbQO2GeqS1gNXU1n9R1lA0fEjp7FUON4vuj/DSt2w7WbttbLQzf5fsy1DfHq 0K/Zh7RiiJu8XAYEaEgYvhk8OiEyKw31jU4l4iMBvYpOiUzTsCHDyAENmjp/DA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=Op+yNeSl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.06 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=Op+yNeSl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 3BCB537BA1 X-Spam-Score: 3.06 X-Migadu-Scanner: scn0.migadu.com X-TUID: I05/9mYgIDwn --=-vk4RnnUo4QAY6dnT250b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable zimoun schreef op vr 27-05-2022 om 18:19 [+0200]: > I miss why such lengthy discussion about these theoretical > failures of last-expiry-cleanup when it is also true each time 'read' > is used, see least-authority or ui.scm etc. (guix ui) cannot do anything about corruption except report the read failure, whereas (guix cache) has a=C2=A0very strict file format so it is feasible to detect whether it's corruption or just the user making a typo (because those files aren't directly written by a user) and additionally it can very easily handle the corruption. For (guix authority), there is already a corruption detection mechanism ("guix gc --verify=3Dcontents") -- there even already is a repair mechanism: "guix gc --verify=3Dcontents,repair". > It is not resistance but pragmatic: the only case of interest is > the empty file, which happens -- all the others, I am still waiting > at least one bug report about them i.e., a user runs "guix time- > machine" and suddenly the file last-expiry-cleanup is corrupted and > "guix time-machine" unusable. * The general issue of file system corruption in Guix is already known (the Guix daemon never calls fsync or sync except on the SQLite database), though I don't know if a formal bug report exists about that. There have been many bug reports on individual cases though. * This bug report already exists: . (You say the file system is not corrupted, but how would you know? Even if not, the symptoms are almost identical.) * I do not see the point of waiting for any known suffering users reporting the bug before fixing the bug. Seems negligent to me if the fix is easy and known, and not very pragmatic for those future (or maybe current and shy) users. Also has a risk of rebase conflicts, which does not seem pragmatic to me. Greetings, Maxime --=-vk4RnnUo4QAY6dnT250b Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYpEI+hccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7maLAP9BLkLrLMDf5+Uy5jugnE7WH/PX 8V9clB6T6gAePKwcjwEA0NUbqRToI/WCiqFiWs4AqzuIjUfZNUDwvOfp2tWZCgw= =MEW/ -----END PGP SIGNATURE----- --=-vk4RnnUo4QAY6dnT250b--