From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AHoCHxjw+mECGwEAgWs5BA (envelope-from ) for ; Wed, 02 Feb 2022 21:56:56 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eKDPFxjw+mFr5wAAG6o9tA (envelope-from ) for ; Wed, 02 Feb 2022 21:56:56 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CB65C8368 for ; Wed, 2 Feb 2022 21:56:55 +0100 (CET) Received: from localhost ([::1]:51114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nFMgQ-00076m-V0 for larch@yhetil.org; Wed, 02 Feb 2022 15:56:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42266) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nFMU2-0003Yt-QV for guix-patches@gnu.org; Wed, 02 Feb 2022 15:44:06 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:59871) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nFMTy-0000jf-Go for guix-patches@gnu.org; Wed, 02 Feb 2022 15:44:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nFMTy-0001Nw-99 for guix-patches@gnu.org; Wed, 02 Feb 2022 15:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53676] [PATCH 3/5] gnu: pulseaudio: Graft to adjust configuration. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Feb 2022 20:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53676 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 53676@debbugs.gnu.org Received: via spool by 53676-submit@debbugs.gnu.org id=B53676.16438346055260 (code B ref 53676); Wed, 02 Feb 2022 20:44:02 +0000 Received: (at 53676) by debbugs.gnu.org; 2 Feb 2022 20:43:25 +0000 Received: from localhost ([127.0.0.1]:53768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFMTN-0001Mm-4T for submit@debbugs.gnu.org; Wed, 02 Feb 2022 15:43:25 -0500 Received: from mail-ej1-f68.google.com ([209.85.218.68]:36382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nFMTK-0001MW-UQ for 53676@debbugs.gnu.org; Wed, 02 Feb 2022 15:43:24 -0500 Received: by mail-ej1-f68.google.com with SMTP id s13so1093949ejy.3 for <53676@debbugs.gnu.org>; Wed, 02 Feb 2022 12:43:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=hZ5ykrL6BjGj3jMJsYX+2edoph7uCiPjoFvHSyzwI8s=; b=EK/F/Fxr6wzZ5++SNpTS8BWKDeZOcOXYkVk6xW2HDJkvWunzodBq0TBTCqrrn901kY GW9h/DgwTUEV7gV3YMeOoJheDcyG8YF03NbfpBssFj9Oy/w9zrxgj5t7xt20YF+tvBOd /YnRzMTWwVqplHyFtcLP6Nc3Q+VkRAkkJHF6Q5FsNHDX1aDcNGP+BgBWeH0YHSyf1dW0 9ThR1Nu1g7FBr0hqtFUWIvf7vaRxdyyCCE6/Ftk2lG88tCN23y9M9Rrgmk8Eajgl50oe BH+Qg9uWNLhX6a/t7ix9MZTVEbZqNvCQstv99bS8g0VhWBPqHI4seU9M+wnUFR9513Vn uDUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=hZ5ykrL6BjGj3jMJsYX+2edoph7uCiPjoFvHSyzwI8s=; b=ty4SFm260MU0xsK56JpGLcHjfVriCsSZ9V9MJfPmvEIOmtq0ivd88VkghbNRkm/Ow2 xB4rIBnTJ8MUK+sMwBslLEpWudVktrcYdabmrtNQ2G4LG5fRh+DgY+RI5spjw9ckaAET VP2eu38GYw86dUKB40P1gijcz4ItZwBcyR53xW82QHq+sARqxRvhaQCIF9Td1vZC3u9P slVv2xf8MOCnrjKAGbcYkhlpclFZfS/dq45n582maU9IHnt0mrEzR40weU/hFEMuh2V+ 2n950JwDpSuw8tjhWha8nhhl6C+4VMy5VOReyvSUyLAgPdB81LNTPRwsLaTaJAU5I08Q XIUQ== X-Gm-Message-State: AOAM530F4zh4kI9rRKwsAyEF0ZmsRTriGjX6VFeXj/EmAf+egftmtzwI /juyfpi7JKa+kmZjMG2gGNs= X-Google-Smtp-Source: ABdhPJx42dyReH/WDYvEDkcN8MhpQfNLeIVDmFIjrxC3LO1SvC8Hxn9/FJ5J52MzJ9bTmR5Yxsk/tg== X-Received: by 2002:a17:906:1291:: with SMTP id k17mr26254198ejb.451.1643834596833; Wed, 02 Feb 2022 12:43:16 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id d25sm12464707eje.41.2022.02.02.12.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Feb 2022 12:43:16 -0800 (PST) Message-ID: <2ed5ef40ecc06c783af81de129a62d3c42d87fec.camel@gmail.com> From: Liliana Marie Prikler Date: Wed, 02 Feb 2022 21:43:14 +0100 In-Reply-To: <87k0edzy8j.fsf@gmail.com> References: <20220201041933.16603-1-maxim.cournoyer@gmail.com> <20220201041933.16603-3-maxim.cournoyer@gmail.com> <693cc82d449395853247c7fbf1b44d0a3c979c87.camel@gmail.com> <875ypy1gqd.fsf@gmail.com> <87k0edzy8j.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643835415; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hZ5ykrL6BjGj3jMJsYX+2edoph7uCiPjoFvHSyzwI8s=; b=pqTGz7Jfu29q3vsBLoHGktRblLDrro3NPltjf6CUzr0NRgkvQhzR2M9HH+c/SuDvLwlRn3 mv3aGrz31g9eCD75Z3JXROtA/NOoChyiYarPy9R2rSujevhc+hsgC+0e1zCG5DgPxbSQjc Df4DK7E4QOEAqNxtdxYYrQ8y2dIg6Lz6LaxkfCpBqUeHRzQueKHvm2jmrN+bJZeNIzJfOu 5LgM8JPkvTNIvMJc+k3qJRwWR/dw98eFhLPlE89p6hqSz31WzkRoVgYpJtCEw5UjxxgZpH UZM8VKbW/ezmiDswBYiXZmCZpF9+P5aheLH/Wy9qBiulIn6fTEZzDDwR7An7Iw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643835415; a=rsa-sha256; cv=none; b=BwL/Ef3S5Qq9+EmithwgMcPH1pkalTiJMkjAvi5qV+m+0mSgKr6MATCg0/Nncg3Rm9HOup V1DmsupkWJ3Oa8W+2RZqJrUATBIrLUgSDn0xp4BWqxJbU7HizNw0HEYNA09Z+QNR5W3+kY fFTwAqguclJ2hvLuckpFLVIfZV907cH79SjZUFBgYKLNeiUzomsNtAgPeRrvcuFamXGxy8 YWJLyWQkQyLV3rfHk2XIFQ/QHrc+c5u5t1reRryBtIuszDTdZv+Qpf2TntY2SxUr4CofwK tFX0vNJ2/Uk1Sd4eX859ff5L0mf5Rg3H1ebPEKM20lqCZ6r6p+ErFcOlDfHwFw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="EK/F/Fxr"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="EK/F/Fxr"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CB65C8368 X-Spam-Score: -2.53 X-Migadu-Scanner: scn0.migadu.com X-TUID: g/nEp6c3PcXo Hi, Am Dienstag, dem 01.02.2022 um 23:30 -0500 schrieb Maxim Cournoyer: > If someone was to append something to default.pa (the exact one shipped > with PulseAudio), they'd have to add the .fail themselves to undo > PulseAudio's own .nofail, right?  I don't see why we should go out of > our way to change that. Didn't you add that .nofail on your own? If not, why include the directive? > With the proposed 'extra-script-files', I'd argue that appending > something to default.pa should be considered an anti-pattern; as the > new field would be the more natural option to *extend* 'default.pa' > (and having a field to override default.pa is still useful if you don't > like any of the default behavior). I don't think you're making a good case here. Why do you want appending to default.pa to be an anti-pattern? > > > > > Can you define "simplicity" here?  In my opinion, services/stuff.scm > > or > > /etc/config.scm provide an easier point of change/extension than > > packages do -- particularly also because pulseaudio-service-type > > (even with this patch set) does not allow changing the pulseaudio > > package. > > The default behavior of default.pa is to allow loading extra files from > 'pulsesysconfdir', which in our case corresponds to output/etc > of pulseaudio; e.g.: > > --8<---------------cut here---------------start------------->8--- > ### Allow including a default.pa.d directory, which if present, can be > used > ### for additional configuration snippets. > .nofail > .include /gnu/store/7xwgz4bavb1i8sfx1lm55hlrr3ngjkdx-pulseaudio- > 15.0/etc/pulse/default.pa.d > --8<---------------cut here---------------end--------------->8--- > > That's not very useful, but is preserved in case pulseaudio ever > decides to drop their own scripts in there.  Adjusting this path is > more natural and straightforwardly done from the package description > than from the service, in my opinion. Well, by Hyrum's Law we can be sure that someone inherited pulseaudio to put files into pulsesysconfdir. That aside, I think substitute* would be expressing your intent better here, because what you actually want is to match that line and then append an .include /etc/pulse/default.pa.d hardcoded. I still don't agree that that's a good idea, however. Particularly, it would lead to including files from an "old distro" that was infected with Guix when that probably wasn't asked for. If at all enabled, I'd prefer if pulseaudio-service-type magically inserted that snippet for configurations that add files to default.pa.d. Note also that default.pa.d has no history [1] in traditional distros, so it's a feature that likely won't be missed by anyone, at least not out of nostalgia. In addition, I'd be careful with claims towards our intent of including this snippet at all. As far as I know, it simply wasn't removed, which might just as well mean that it didn't break the build for anyone. Cheers [1] https://cgit.freedesktop.org/pulseaudio/pulseaudio/tree/src/daemon/default.pa.in?h=v14.2#n175