From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id kDjsDpoDgWBcNgEAgWs5BA (envelope-from ) for ; Thu, 22 Apr 2021 07:03:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KJaWCpoDgWC8BAAA1q6Kng (envelope-from ) for ; Thu, 22 Apr 2021 05:03:22 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C6185274CA for ; Thu, 22 Apr 2021 07:03:21 +0200 (CEST) Received: from localhost ([::1]:45452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lZRUm-0000AC-VH for larch@yhetil.org; Thu, 22 Apr 2021 01:03:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52228) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZRUb-00009i-NQ for guix-devel@gnu.org; Thu, 22 Apr 2021 01:03:09 -0400 Received: from out0.migadu.com ([2001:41d0:2:267::]:29295) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lZRUY-0008Ny-7m for guix-devel@gnu.org; Thu, 22 Apr 2021 01:03:09 -0400 To: Mark H Weaver , Guix Devel DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raghavgururajan.name; s=key1; t=1619067782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KnXaIv7grS5dwSJNZkr5PqnfVdWek6Qsozlh3zEzLmU=; b=RqVd+0PNqvgxkpiLcu2gpBU15mI0Pd7+8P99Mc2YjXst0PpBi3a4crDes5sV8TqTk/9Nvv oJFaEunXSaQE39qWw+hcC/R4vCdZseR8r449uk7O1Gq4fV9zVMUL+mwQhvvMfTiz0H6tzH Si1fuPt5I5+QC7CZ+zdjfCIwp77MC88UPOSZ1XDbZDQrMAhb0XfQssCViY7SGdhSlLn1dM FPAXsUmjnoDg8WG5g3Qh74MzJR9m6mB7Myyzh9EwoLXgpmqEqzegdyGi43WqqBUaa132mw AZydC14wzm8jSL43VSSNs7mkdGEupN5ACuZS3KOtfbhrwh+kbK+QT0L/+E5rrw== Cc: Tobias Geerinckx-Rice , Leo Prikler , Leo Famulari , =?UTF-8?Q?L=c3=a9o_Le_Bouter?= References: <87tunz11mf.fsf@netris.org> <87o8e70wgx.fsf@netris.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Raghav Gururajan Subject: Re: A "cosmetic changes" commit that removes security fixes Message-ID: <2eb8dde2-1fce-4dfd-7d1f-f32a12715dc4@raghavgururajan.name> Date: Thu, 22 Apr 2021 01:02:59 -0400 MIME-Version: 1.0 In-Reply-To: <87o8e70wgx.fsf@netris.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3a2Oy516fUerLrQze5TnT7wy7juk0fkXj" X-Migadu-Auth-User: rg@raghavgururajan.name Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=rg@raghavgururajan.name; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619067801; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=KnXaIv7grS5dwSJNZkr5PqnfVdWek6Qsozlh3zEzLmU=; b=kV33mSpNScpaXttG/emeeILWQlXZZOphMwMfohn64xO4+EsEgos5bXKagcOl/JpFjWfqlF bz57O6RjPL3RQpuwI76+H87XzSij2Uur+20OwYp4308s0v+4BRfOls/T81B18OtT+W08mC N1Ioca0JCyYMEuREhcp5LPNn2AhJ9Dblbfb64Aza566sodCIuNtuR7UtwSiAgx72UEZ7E8 lpZ+wjYZ4sdiJ+VRSpviVmBWOAee9ia6CSE23aJksBQe+kQfLvEYk2txoQgeZbEhKxynaf mBjNvnJBcK/DpcLFpd+92hp7NikF+z8rAtlQFe79gphUuG3TRQusLZZJOgM7DQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619067801; a=rsa-sha256; cv=none; b=Db7auptLZN0jdLSAyEpcVS6BMUSC4zjLtd9R9UANCYF+f95Hubnn04A9BULiZmVz4O88fS 9JkIP4I3UXevb5CDteQRoPVmCWTKvIXO9zO7SF+S3fLXqCaLRv3/hrKWEodKdfnOSixo7o XoItuszx5B4IfnjSPzKwc0Ssu+v73wbm78078EAImRbCgYsk91E9gihkHuozFOCf/L6hJ2 pk3SO071SsqlS5qmNCs+eFTTEpSexePWz6PblYKKzRlHwKtSWb5cI97wSfHSprNTOdDKKs kD9vAc6HHTdC7qiRazfZOZsU+jCGykWQHa8QnASAxUTMt+C9XtmG7jIt6UOd5Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=raghavgururajan.name header.s=key1 header.b=RqVd+0PN; dmarc=pass (policy=quarantine) header.from=raghavgururajan.name; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Spam-Score: -5.24 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=raghavgururajan.name header.s=key1 header.b=RqVd+0PN; dmarc=pass (policy=quarantine) header.from=raghavgururajan.name; spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org X-Migadu-Queue-Id: C6185274CA X-Spam-Score: -5.24 X-Migadu-Scanner: scn0.migadu.com X-TUID: nDnLR4yAKx5V This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3a2Oy516fUerLrQze5TnT7wy7juk0fkXj Content-Type: multipart/mixed; boundary="2E6FZ4jY1IgezHyaC6bFOmtCImxktDOwu"; protected-headers="v1" From: Raghav Gururajan To: Mark H Weaver , Guix Devel Cc: Tobias Geerinckx-Rice , Leo Prikler , Leo Famulari , =?UTF-8?Q?L=c3=a9o_Le_Bouter?= Message-ID: <2eb8dde2-1fce-4dfd-7d1f-f32a12715dc4@raghavgururajan.name> Subject: Re: A "cosmetic changes" commit that removes security fixes References: <87tunz11mf.fsf@netris.org> <87o8e70wgx.fsf@netris.org> In-Reply-To: <87o8e70wgx.fsf@netris.org> --2E6FZ4jY1IgezHyaC6bFOmtCImxktDOwu Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Mark! > (1) These original summary lines are still misleading, because "ungraft= " > means to integrate the fixes from the replacement into the origina= l, > but here, the fixes are simply being deleted. I see. Now I get the idea. Thanks for explaining this. > (2) These original commit logs are still misleading, for the same reaso= n > I gave in my previous reply. Agreed. > (3) The 'cairo' commit still re-introduces security flaws into our > 'cairo' package. Agreed. > What worries me as much as anything is that your responses so far seem > to indicate that you are failing to understand what you and L=C3=A9o ha= ve > done wrong here. I never said nothing wrong was done. I was trying to retrace the steps=20 and putting all the information out. I was not sure why Leo added these=20 changes and I failed to elicit questions at that time. Let us try to fix = it. I don't know what else to say. @Leo, Shall we add a new commit to fix this? Regards, RG. --2E6FZ4jY1IgezHyaC6bFOmtCImxktDOwu-- --3a2Oy516fUerLrQze5TnT7wy7juk0fkXj Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYIEDgwUDAAAAAAAKCRBfWBZkf4vlUd06 AQD18qvXK5pYrdVrcus56z39mLxdeBLO8bRMRIKj1hRqSQD7B9X6aoKInISDnASV3wZRHbyA9Ks7 O0Lca/gnlO0DKAI= =VHpL -----END PGP SIGNATURE----- --3a2Oy516fUerLrQze5TnT7wy7juk0fkXj--