From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KH/GFDWXGmKYKAEAgWs5BA (envelope-from ) for ; Sat, 26 Feb 2022 22:10:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OCKJDTWXGmIOLwAAG6o9tA (envelope-from ) for ; Sat, 26 Feb 2022 22:10:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B67D115E65 for ; Sat, 26 Feb 2022 22:10:12 +0100 (CET) Received: from localhost ([::1]:49090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nO4KR-00044X-Hx for larch@yhetil.org; Sat, 26 Feb 2022 16:10:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nO4KI-000447-GV for guix-patches@gnu.org; Sat, 26 Feb 2022 16:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34255) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nO4KI-0005q7-6p for guix-patches@gnu.org; Sat, 26 Feb 2022 16:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nO4KI-0000iy-0z for guix-patches@gnu.org; Sat, 26 Feb 2022 16:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53878] [PATCH v5 03/22] gnu: racket: Use Git origins for Racket packages. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 26 Feb 2022 21:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53878 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath , 53878@debbugs.gnu.org, zimoun , Liliana Marie Prikler Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , Maxime Devos , Attila Lendvai , Malte Gerdes , raingloom Received: via spool by 53878-submit@debbugs.gnu.org id=B53878.16459097752741 (code B ref 53878); Sat, 26 Feb 2022 21:10:01 +0000 Received: (at 53878) by debbugs.gnu.org; 26 Feb 2022 21:09:35 +0000 Received: from localhost ([127.0.0.1]:56385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO4Jr-0000i8-BJ for submit@debbugs.gnu.org; Sat, 26 Feb 2022 16:09:35 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:46804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nO4Jq-0000hv-4A for 53878@debbugs.gnu.org; Sat, 26 Feb 2022 16:09:34 -0500 Received: by mail-wm1-f68.google.com with SMTP id p184-20020a1c29c1000000b0037f76d8b484so3744266wmp.5 for <53878@debbugs.gnu.org>; Sat, 26 Feb 2022 13:09:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=dCYwVsvV/DKujusD3t2sGsUGjcNPE+s9I8fWLUG1cGk=; b=WL3YMghQreemp212XbQVagQ071eDXzT+0bMfb559mPzJfhwg1ASDAHc01lvqrj0y1u NSE2d9usX7J1Ioj/17cXXFBwhjFmf/xP2hT1aaDZubpOEfrEp3k5BxIsr9gSW8NwRiOp oknwb3ghZnaxE4K/FGrnRd/bAF3xUU4TkICz2kJ0ShCoS1Q68+4s56I0KCtRULoxQY48 Qvld2RpSrvZWOHy/I5febpHJHJEaGrFsfBqenSWZt3L9fy1zgouvB86KLcV4hN9eIFjc M5IhWmTfMcd14ia8tiecxH1l5aFc5O2DxSPDNZQNS3OAT2QyAz5aghlyDoOAu2we1NrJ yFQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=dCYwVsvV/DKujusD3t2sGsUGjcNPE+s9I8fWLUG1cGk=; b=mEFq3s1exp2kzqDFTDwimvcnYV+2KZ/k/Ch4NNqD2RBFXiUbm0NAcIqw3HBfbnsTgm 3w6VwKUqrEj0gGXbHQ/iayCVOPJ8sHEdCzJjcInRfZMBmPkj982yZYyx21L0zCQR8Hf4 eSqPSsxMfpxkuIVBY3R3kNZilYCa2vjjkrnw2QftWAXUdKwFZl5M2+CBz0u4MV5/5Is8 x7BG56Kj1jQGAZxZTR6JpEdwUjpkb64nA1H6b6FDKjzlASiITIlJ2TmqWQxv2P0T7Hje W/PIZ906gNbE2qgz281pFyqBe5S9kFRo7ZsLplKOWstCxirERa4puLBOb3QlX57G870r 9n1w== X-Gm-Message-State: AOAM533qhVziN2nDdl16iVBo+54iOTB83dY9xm6hQfSCv1Gg8D2mUcpX siDuQiTzuUWDMlw3M9aQEbo= X-Google-Smtp-Source: ABdhPJzotSwRLaJuHopAtkguhtdDnb7KYfos65BPPyI/UrP59J8L+XVLXzHOpELsXrqecM5XUvqi4w== X-Received: by 2002:a1c:4604:0:b0:381:139:e54e with SMTP id t4-20020a1c4604000000b003810139e54emr7812719wma.151.1645909768173; Sat, 26 Feb 2022 13:09:28 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id m18-20020a5d56d2000000b001edc00dbeeasm5709253wrw.69.2022.02.26.13.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Feb 2022 13:09:27 -0800 (PST) Message-ID: <2dc808eb7328149b3974d4dac50d3da1b8e4d416.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 26 Feb 2022 22:09:26 +0100 In-Reply-To: <3566149.rYT2d9vS2d@bastet> References: <20220220060610.178131-1-philip@philipmcgrath.com> <19823080.dSP1spjjOr@bastet> <6a35fdea04cdf461a662830efc5bfd84fee60ec1.camel@gmail.com> <3566149.rYT2d9vS2d@bastet> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1645909812; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dCYwVsvV/DKujusD3t2sGsUGjcNPE+s9I8fWLUG1cGk=; b=n/Ou/Y2oyfGEfC0pg62fwnk/wu2G/bIwbhPVC0dmdpisK/tLp5WWWWWhLI2GaPvWdYFXOJ HB/qUYzQmcm+bNhtZahqHheN7uaQr5acE0dVqKOlNZ5S6k8rLOV4IRtUkShrdZNj1F/sIM PhuTgrMR7f87PT8PSYBL4ruaHwsElPs5UrXCvDeorNlH8lojUk+J2zypKqUUzH8TUMC6eB /RT1PLgZ84hwg1N9blLDzozQYD7vtRruKv4ESKb4RZiUNWyvWeGX2ZPPf5Q5LBMhhtOzq2 K+XnpZuZZho7rG1xzcFTxkOeF7D6GhsIBSeR7HURMqn4h+fSmv+UWJ6Mxypulw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1645909812; a=rsa-sha256; cv=none; b=PGDP15at+Y/RQXKtEMympwTE07NMTBg/h/esQcVz0zd+buZ1ruqapiE5eYeL1UgAMw5P/8 W/74Sm3Qm1A9pbqfcxJiv/fRazSSFplOmxyA9BMMIaBrL2XKtsRZhlMBPJ1n+YywdupHZV PP+7S6lVdwZccWM9XtgQ8aCbVKmhe1mbF9aWWt66x3+uppKeuf6dnPeWOQzvsxlQSEcxYX 9xH//784I4BT2Tbzxrb7QgBxLUdtCAep5XPAz8OvbsvYe0yk8k3cWRZp+M4+wPln42nNO+ GY4rpJubxJoRc5p4jnteNt8MfYi1Xyu0pUJhvrbywtA6/kusMox1lYppXsoLOA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=WL3YMghQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.28 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=WL3YMghQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B67D115E65 X-Spam-Score: 6.28 X-Migadu-Scanner: scn0.migadu.com X-TUID: SzqAQPqE/el1 Hi, Am Samstag, dem 26.02.2022 um 14:55 -0500 schrieb Philip McGrath: > "configure-layer.rkt" seems fine. I do see the potential for confusion > about whether this was "making" an "installation-layer.rkt". configure-layer.rkt it is then :) > > > > > > I think some way to shorten those origins would do wonders in > > > > > > terms of the number of lines this patch adds. > > > > > > > > > > At one point, I had abbreviated the origins as something like: > > > > > > > > > >   (REPO-SPEC SHA256 [COMMIT]) > > > > > > > > > > [...] > > > > > > > > I wouldn't do this inside of extract-package-source, but define a > > > > one or two liner for adding specifically packages hosted on > > > > racket's github.  WDYT? > > > > > > > > > I wasn't sure about the trade-off between being slightly more > > > > > cryptic > > > > > than explicit origins, but a lot shorter. > > > > > > > > Note that the goal is not to code golf, but to be understandable. > > > > When adding a bunch of origins as inputs, understandability > > > > suffers > > > > by induced scrolling. > > > > > > I've done this, and it was a very good idea. In particular, it > > > helped > > > find some places where I hadn't switched to using `%racket-commit` > > > once the release was tagged. > > > > That is better, but can still be improved.  As hinted at in my > > comment > > to your tree, origin snippets might be a better solution here unless > > I'm missing something in the heat of the moment. > > Could you give an example of what you imagine the result might look > like in use? E.g. (but I'm not sure this would really be an > improvement): > > > (cons* > >  ... > >  libedit > >  racket-minimal > >  (append > >   (racket-package-sources > >    "2d" (base32 > > "1zzcz5qyjv7syi41vb8jkxjp1rqgj61zbsdrg0nlc4qy9qsafzgr") > >    "2d" "2d-doc" "2d-lib") > >   (racket-package-sources > >    "algol60" (base32 > > "09kj6asypmc24n29w0izc9p0q8hpga2hpkchsypfwn5c8zpvihlx") > >    '("algol60" ".")) > >   ...)) I'd write this as  --8<---------------cut here---------------start------------->8--- (list ... libedit racket-minimal (simple-racket-origin "2d" (base32 "1zzcz5qyjv7syi41vb8jkxjp1rqgj61zbsdrg0nlc4qy9qsafzgr") '("2d" "2d-doc" "2d-lib") (simple-racket-origin "algol60" (base32 "09kj6asypmc24n29w0izc9p0q8hpga2hpkchsypfwn5c8zpvihlx") '("algol60" ".") ...) --8<---------------cut here---------------end--------------->8--- I do wonder whether these packages can further be modularized (i.e. so that they build as packages) with configure-layer.rkt acting as a profile hook and some racket meta package simply adding racket-minimal and all the base stuff into the profile, but for now let's just have an easy way of formulating origins. Cheers