* [bug#71653] [PATCH] import/github: Honor upstream-name property.
@ 2024-06-19 16:26 Dariqq
2024-06-23 6:21 ` Zheng Junjie
2024-06-23 8:03 ` [bug#71653] [PATCH v2] " Dariqq
0 siblings, 2 replies; 5+ messages in thread
From: Dariqq @ 2024-06-19 16:26 UTC (permalink / raw)
To: 71653; +Cc: Dariqq
* guix/import/github.scm (import-release): Use 'upstream-name if available.
Change-Id: I9a4999a01156ce02584270837ceab70996b49106
---
guix/import/github.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guix/import/github.scm b/guix/import/github.scm
index c5556d78ee..164fcde458 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -328,8 +328,9 @@ (define* (import-release pkg #:key (version #f))
(let* ((original-uri (origin-uri (package-source pkg)))
(source-uri (github-uri original-uri))
(name (package-name pkg))
+ (upstream-name (assoc-ref (package-properties pkg) 'upstream-name))
(newest-version version-tag
- (latest-released-version source-uri name
+ (latest-released-version source-uri (or upstream-name name)
#:version version)))
(if newest-version
(upstream-source
base-commit: c551e406a75273583ae3fef92f32468f905cc07f
--
2.45.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#71653] [PATCH] import/github: Honor upstream-name property.
2024-06-19 16:26 [bug#71653] [PATCH] import/github: Honor upstream-name property Dariqq
@ 2024-06-23 6:21 ` Zheng Junjie
2024-06-23 8:05 ` Dariqq
2024-06-23 8:03 ` [bug#71653] [PATCH v2] " Dariqq
1 sibling, 1 reply; 5+ messages in thread
From: Zheng Junjie @ 2024-06-23 6:21 UTC (permalink / raw)
To: Dariqq; +Cc: 71653
[-- Attachment #1: Type: text/plain, Size: 1199 bytes --]
Dariqq <dariqq@posteo.net> writes:
> * guix/import/github.scm (import-release): Use 'upstream-name if available.
>
> Change-Id: I9a4999a01156ce02584270837ceab70996b49106
> ---
> guix/import/github.scm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/import/github.scm b/guix/import/github.scm
> index c5556d78ee..164fcde458 100644
> --- a/guix/import/github.scm
> +++ b/guix/import/github.scm
> @@ -328,8 +328,9 @@ (define* (import-release pkg #:key (version #f))
> (let* ((original-uri (origin-uri (package-source pkg)))
> (source-uri (github-uri original-uri))
> (name (package-name pkg))
^------------ I think maybe just use "package-upstream-name" on this?
> + (upstream-name (assoc-ref (package-properties pkg) 'upstream-name))
> (newest-version version-tag
> - (latest-released-version source-uri name
> + (latest-released-version source-uri (or upstream-name name)
> #:version version)))
> (if newest-version
> (upstream-source
>
> base-commit: c551e406a75273583ae3fef92f32468f905cc07f
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* [bug#71653] [PATCH] import/github: Honor upstream-name property.
2024-06-23 6:21 ` Zheng Junjie
@ 2024-06-23 8:05 ` Dariqq
2024-07-06 10:08 ` bug#71653: " Nicolas Goaziou via Guix-patches via
0 siblings, 1 reply; 5+ messages in thread
From: Dariqq @ 2024-06-23 8:05 UTC (permalink / raw)
To: Zheng Junjie; +Cc: 71653
On 23.06.24 08:21, Zheng Junjie wrote:
> Dariqq <dariqq@posteo.net> writes:
>
>> * guix/import/github.scm (import-release): Use 'upstream-name if available.
>>
>> Change-Id: I9a4999a01156ce02584270837ceab70996b49106
>> ---
>> guix/import/github.scm | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/guix/import/github.scm b/guix/import/github.scm
>> index c5556d78ee..164fcde458 100644
>> --- a/guix/import/github.scm
>> +++ b/guix/import/github.scm
>> @@ -328,8 +328,9 @@ (define* (import-release pkg #:key (version #f))
>> (let* ((original-uri (origin-uri (package-source pkg)))
>> (source-uri (github-uri original-uri))
>> (name (package-name pkg))
> ^------------ I think maybe just use "package-upstream-name" on this?
>
Thanks, i think this is better. Have sent a v2 now. THis will also
change the package field of the resulting upstream-source to the
upstream name, but this matches what other updaters do (i have checked
with gnu-maintenance)
>> + (upstream-name (assoc-ref (package-properties pkg) 'upstream-name))
>> (newest-version version-tag
>> - (latest-released-version source-uri name
>> + (latest-released-version source-uri (or upstream-name name)
>> #:version version)))
>> (if newest-version
>> (upstream-source
>>
>> base-commit: c551e406a75273583ae3fef92f32468f905cc07f
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#71653: [PATCH] import/github: Honor upstream-name property.
2024-06-23 8:05 ` Dariqq
@ 2024-07-06 10:08 ` Nicolas Goaziou via Guix-patches via
0 siblings, 0 replies; 5+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-07-06 10:08 UTC (permalink / raw)
To: 71653-done; +Cc: Dariqq, Zheng Junjie
Hello,
> On 23.06.24 08:21, Zheng Junjie wrote:
> > Dariqq <dariqq@posteo.net> writes:
> >
> >> * guix/import/github.scm (import-release): Use 'upstream-name if
> >available.
Applied. Thank you!
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#71653] [PATCH v2] import/github: Honor upstream-name property.
2024-06-19 16:26 [bug#71653] [PATCH] import/github: Honor upstream-name property Dariqq
2024-06-23 6:21 ` Zheng Junjie
@ 2024-06-23 8:03 ` Dariqq
1 sibling, 0 replies; 5+ messages in thread
From: Dariqq @ 2024-06-23 8:03 UTC (permalink / raw)
To: 71653; +Cc: Dariqq
* guix/import/github.scm (import-release): Use package-upstream-name instead
of package-name.
Change-Id: I9a4999a01156ce02584270837ceab70996b49106
---
guix/import/github.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guix/import/github.scm b/guix/import/github.scm
index c5556d78ee..7be29ca151 100644
--- a/guix/import/github.scm
+++ b/guix/import/github.scm
@@ -327,7 +327,7 @@ (define* (import-release pkg #:key (version #f))
(let* ((original-uri (origin-uri (package-source pkg)))
(source-uri (github-uri original-uri))
- (name (package-name pkg))
+ (name (package-upstream-name pkg))
(newest-version version-tag
(latest-released-version source-uri name
#:version version)))
base-commit: dd5ef2cbddd76cf048a9b514cdcea6d22411a2cb
--
2.45.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-06 10:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-19 16:26 [bug#71653] [PATCH] import/github: Honor upstream-name property Dariqq
2024-06-23 6:21 ` Zheng Junjie
2024-06-23 8:05 ` Dariqq
2024-07-06 10:08 ` bug#71653: " Nicolas Goaziou via Guix-patches via
2024-06-23 8:03 ` [bug#71653] [PATCH v2] " Dariqq
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.